Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39175 )
Change subject: mb/**/dsdt.asl: Remove "Some generic macros" comment, again ......................................................................
mb/**/dsdt.asl: Remove "Some generic macros" comment, again
It provides no useful information, so it might as well vanish.
This follows commit 0142d441c63a9bb1a7955ea0ba764a2ddbc38d48.
Change-Id: Iad41d8d39c6712cebfa5245f37bc69061b5ac552 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/dedede/dsdt.asl M src/mainboard/google/volteer/dsdt.asl M src/mainboard/intel/jasperlake_rvp/dsdt.asl M src/mainboard/intel/tglrvp/dsdt.asl 4 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/39175/1
diff --git a/src/mainboard/google/dedede/dsdt.asl b/src/mainboard/google/dedede/dsdt.asl index 3d17017..4134b03 100644 --- a/src/mainboard/google/dedede/dsdt.asl +++ b/src/mainboard/google/dedede/dsdt.asl @@ -19,7 +19,6 @@ 0x20110725 /* OEM revision */ ) { - /* Some generic macros */ #include <soc/intel/tigerlake/acpi/platform.asl>
/* global NVS and variables */ diff --git a/src/mainboard/google/volteer/dsdt.asl b/src/mainboard/google/volteer/dsdt.asl index 489d2f0..e4bbe90 100644 --- a/src/mainboard/google/volteer/dsdt.asl +++ b/src/mainboard/google/volteer/dsdt.asl @@ -19,7 +19,6 @@ 0x20110725 // OEM revision ) { - // Some generic macros #include <soc/intel/tigerlake/acpi/platform.asl>
// global NVS and variables diff --git a/src/mainboard/intel/jasperlake_rvp/dsdt.asl b/src/mainboard/intel/jasperlake_rvp/dsdt.asl index 559e1e3..8788a1f 100644 --- a/src/mainboard/intel/jasperlake_rvp/dsdt.asl +++ b/src/mainboard/intel/jasperlake_rvp/dsdt.asl @@ -26,7 +26,6 @@ 0x20110725 /* OEM revision */ ) { - /* Some generic macros */ #include <soc/intel/tigerlake/acpi/platform.asl>
/* global NVS and variables */ diff --git a/src/mainboard/intel/tglrvp/dsdt.asl b/src/mainboard/intel/tglrvp/dsdt.asl index f21ba5d..a17f597 100644 --- a/src/mainboard/intel/tglrvp/dsdt.asl +++ b/src/mainboard/intel/tglrvp/dsdt.asl @@ -26,7 +26,6 @@ 0x20110725 /* OEM revision */ ) { - /* Some generic macros */ #include <soc/intel/tigerlake/acpi/platform.asl>
/* global NVS and variables */
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39175 )
Change subject: mb/**/dsdt.asl: Remove "Some generic macros" comment, again ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39175 )
Change subject: mb/**/dsdt.asl: Remove "Some generic macros" comment, again ......................................................................
mb/**/dsdt.asl: Remove "Some generic macros" comment, again
It provides no useful information, so it might as well vanish.
This follows commit 0142d441c63a9bb1a7955ea0ba764a2ddbc38d48.
Change-Id: Iad41d8d39c6712cebfa5245f37bc69061b5ac552 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39175 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/google/dedede/dsdt.asl M src/mainboard/google/volteer/dsdt.asl M src/mainboard/intel/jasperlake_rvp/dsdt.asl M src/mainboard/intel/tglrvp/dsdt.asl 4 files changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/dsdt.asl b/src/mainboard/google/dedede/dsdt.asl index 3d17017..4134b03 100644 --- a/src/mainboard/google/dedede/dsdt.asl +++ b/src/mainboard/google/dedede/dsdt.asl @@ -19,7 +19,6 @@ 0x20110725 /* OEM revision */ ) { - /* Some generic macros */ #include <soc/intel/tigerlake/acpi/platform.asl>
/* global NVS and variables */ diff --git a/src/mainboard/google/volteer/dsdt.asl b/src/mainboard/google/volteer/dsdt.asl index 489d2f0..e4bbe90 100644 --- a/src/mainboard/google/volteer/dsdt.asl +++ b/src/mainboard/google/volteer/dsdt.asl @@ -19,7 +19,6 @@ 0x20110725 // OEM revision ) { - // Some generic macros #include <soc/intel/tigerlake/acpi/platform.asl>
// global NVS and variables diff --git a/src/mainboard/intel/jasperlake_rvp/dsdt.asl b/src/mainboard/intel/jasperlake_rvp/dsdt.asl index 559e1e3..8788a1f 100644 --- a/src/mainboard/intel/jasperlake_rvp/dsdt.asl +++ b/src/mainboard/intel/jasperlake_rvp/dsdt.asl @@ -26,7 +26,6 @@ 0x20110725 /* OEM revision */ ) { - /* Some generic macros */ #include <soc/intel/tigerlake/acpi/platform.asl>
/* global NVS and variables */ diff --git a/src/mainboard/intel/tglrvp/dsdt.asl b/src/mainboard/intel/tglrvp/dsdt.asl index f21ba5d..a17f597 100644 --- a/src/mainboard/intel/tglrvp/dsdt.asl +++ b/src/mainboard/intel/tglrvp/dsdt.asl @@ -26,7 +26,6 @@ 0x20110725 /* OEM revision */ ) { - /* Some generic macros */ #include <soc/intel/tigerlake/acpi/platform.asl>
/* global NVS and variables */
-
Angel Pons (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)