Attention is currently required from: Jakub Czapiga, Jan Dabros. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57555 )
Change subject: tests: Add lib/lzma-test test case ......................................................................
Patch Set 6: Code-Review+1
(3 comments)
File tests/lib/lzma-test.c:
https://review.coreboot.org/c/coreboot/+/57555/comment/99cc4885_608fdb9e PS6, Line 48: /* 9 -> strlen(".lzma.bin") */ nit: Now that you have moved on to ARRAY_SIZE this '9' is a bit confusing.
https://review.coreboot.org/c/coreboot/+/57555/comment/614d88fb_58926cb9 PS6, Line 81: test_free(s->raw_filename); : test_free(s->comp_filename); : test_free(s) How about calling teardown_ulzman_file() here?
https://review.coreboot.org/c/coreboot/+/57555/comment/8ac18415_480085ee PS6, Line 120: assert_non_null(raw_buf); : assert_non_null(comp_buf); I guess this test is here for making sure that test_malloc was successful in getting some memory, right? Then why not add the same test her for dcomp_buf?