Attention is currently required from: Jakub Czapiga, Jan Dabros.

Patch set 6:Code-Review +1

View Change

3 comments:

• File tests/lib/lzma-test.c:

  • Patch Set #6, Line 48: /* 9 -> strlen(".lzma.bin") */

    nit: Now that you have moved on to ARRAY_SIZE this '9' is a bit confusing.

  • Patch Set #6, Line 81:

    test_free(s->raw_filename);
    	test_free(s->comp_filename);
    	test_free(s)
    

    How about calling teardown_ulzman_file() here?

  • Patch Set #6, Line 120:

    assert_non_null(raw_buf);
    	assert_non_null(comp_buf);
    

    I guess this test is here for making sure that test_malloc was successful in getting some memory, right? Then why not add the same test her for dcomp_buf?

To view, visit change 57555. To unsubscribe, or for help writing mail filters, visit settings.