Change in coreboot[master]: [NOTFORMERGE]: drivers/pc80/tpm: Probe for tpm multiple times
Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42510 )
Change subject: [NOTFORMERGE]: drivers/pc80/tpm: Probe for tpm multiple times ......................................................................
[NOTFORMERGE]: drivers/pc80/tpm: Probe for tpm multiple times
Change-Id: Icdd675c0978173755d9ee18c20d8c314c1537a7a Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/drivers/pc80/tpm/tis.c 1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/42510/1
diff --git a/src/drivers/pc80/tpm/tis.c b/src/drivers/pc80/tpm/tis.c index 185df34..ef556fe 100644 --- a/src/drivers/pc80/tpm/tis.c +++ b/src/drivers/pc80/tpm/tis.c @@ -393,7 +393,11 @@ if (vendor_dev_id) return 0; /* Already probed. */
- didvid = tpm_read_did_vid(0); + for (i = 0; i < 10000; i++) { + didvid = tpm_read_did_vid(0); + if (didvid && didvid != 0xffffffff) + break; + } if (!didvid || (didvid == 0xffffffff)) { printf("%s: No TPM device found\n", __FUNCTION__); return TPM_DRIVER_ERR;
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42510 )
Change subject: [NOTFORMERGE]: drivers/pc80/tpm: Probe for tpm multiple times ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42510/1/src/drivers/pc80/tpm/tis.c File src/drivers/pc80/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/42510/1/src/drivers/pc80/tpm/tis.c@... PS1, Line 400: } Please use the stopwatch framework.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42510 )
Change subject: [NOTFORMERGE]: drivers/pc80/tpm: Probe for tpm multiple times ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42510/1/src/drivers/pc80/tpm/tis.c File src/drivers/pc80/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/42510/1/src/drivers/pc80/tpm/tis.c@... PS1, Line 400: }
Please use the stopwatch framework.
There aren't delays, though?
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42510 )
Change subject: [NOTFORMERGE]: drivers/pc80/tpm: Probe for tpm multiple times ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42510/1/src/drivers/pc80/tpm/tis.c File src/drivers/pc80/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/42510/1/src/drivers/pc80/tpm/tis.c@... PS1, Line 400: }
There aren't delays, though?
It is all about generating some traffic on the bus
Patrick Rudolph has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42510 )
Change subject: [NOTFORMERGE]: drivers/pc80/tpm: Probe for tpm multiple times ......................................................................
Abandoned
was for testing only
-
Angel Pons (Code Review) -
Christian Walter (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)