Change in coreboot[master]: mb/facebook/fbg1701: Remove confusing text boxes from menu

[Wim Vervoorn (Code Review)]

Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36481 )

Change subject: mb/facebook/fbg1701: Remove confusing text boxes from menu
......................................................................

mb/facebook/fbg1701: Remove confusing text boxes from menu

The Kconfig contained some items that were only intended to
set a default and that now were displayed in two locations
in the menuconfig.

BUG=N/A
TEST=build

Change-Id: If5d9c993c03a0e901fd6c2a2107a6be6b94d063b
Signed-off-by: Wim Vervoorn 
---
M src/mainboard/facebook/fbg1701/Kconfig
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/36481/1

diff --git a/src/mainboard/facebook/fbg1701/Kconfig b/src/mainboard/facebook/fbg1701/Kconfig
index a607705..e80b7fe 100644
--- a/src/mainboard/facebook/fbg1701/Kconfig
+++ b/src/mainboard/facebook/fbg1701/Kconfig
@@ -73,7 +73,7 @@
    default n

config VENDORCODE_ELTAN_OEM_MANIFEST_LOC
-	hex "OEM Manifest working dflt"
+	hex
    default 0xFFFE9000

config SPI_FLASH_INCLUDE_ALL_DRIVERS
@@ -101,7 +101,7 @@
    default "mainboard/facebook/fbg1701/manifest.h"

config VENDORCODE_ELTAN_VBOOT_KEY_LOCATION
-	hex "Key Location working dflt"
+	hex
    default 0xFFFF9C00

endif # BOARD_FACEBOOK_FBG1701

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36481 )

Change subject: mb/facebook/fbg1701: Remove confusing text boxes from menu
......................................................................

Patch Set 1: Code-Review+2

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36481 )

Change subject: mb/facebook/fbg1701: Remove confusing text boxes from menu
......................................................................

Patch Set 2: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36481 )

Change subject: mb/facebook/fbg1701: Remove confusing text boxes from menu
......................................................................

mb/facebook/fbg1701: Remove confusing text boxes from menu

The Kconfig contained some items that were only intended to
set a default and that now were displayed in two locations
in the menuconfig.

BUG=N/A
TEST=build

Change-Id: If5d9c993c03a0e901fd6c2a2107a6be6b94d063b
Signed-off-by: Wim Vervoorn 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36481
Reviewed-by: Frans Hendriks 
Reviewed-by: Arthur Heymans 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/facebook/fbg1701/Kconfig
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved
  Frans Hendriks: Looks good to me, approved

diff --git a/src/mainboard/facebook/fbg1701/Kconfig b/src/mainboard/facebook/fbg1701/Kconfig
index d74a294..a6c2846 100644
--- a/src/mainboard/facebook/fbg1701/Kconfig
+++ b/src/mainboard/facebook/fbg1701/Kconfig
@@ -73,7 +73,7 @@
    default n

config VENDORCODE_ELTAN_OEM_MANIFEST_LOC
-	hex "OEM Manifest working dflt"
+	hex
    default 0xFFFE9000

config SPI_FLASH_INCLUDE_ALL_DRIVERS
@@ -101,7 +101,7 @@
    default "mainboard/facebook/fbg1701/manifest.h"

config VENDORCODE_ELTAN_VBOOT_KEY_LOCATION
-	hex "Key Location working dflt"
+	hex
    default 0xFFFF9C00

config DRIVERS_INTEL_WIFI