Change in coreboot[master]: qualcomm/sc7280: gpio: Support eGPIO scheme - coreboot-gerrit

13 Jul 2021


      Attention is currently required from: Ravi kumar, Taniya Das, Paul Menzel, Julius Werner, mturney mturney.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55078 )
Change subject: qualcomm/sc7280: gpio: Support eGPIO scheme
......................................................................
Patch Set 11:
(1 comment)
File src/soc/qualcomm/sc7280/sc7280_egpio.c:
https://review.coreboot.org/c/coreboot/+/55078/comment/b70c771b_1a00e9ae 
PS3, Line 56: 		setbits32(&regs->cfg, BIT(EGPIO_CFG_EN));
...
The kernel should always do its own GPIO setup and not rely on firmware to prepare things correctly. […]
Hi Taniya,  was wondering if Qualcomm can respond to Julius' comment above?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/55078
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c54a14c50fb7b5921d1961d2de83098ed2d4358
Gerrit-Change-Number: 55078
Gerrit-PatchSet: 11
Gerrit-Owner: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Taniya Das tdas@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar rbokka@codeaurora.org
Gerrit-Attention: Taniya Das tdas@codeaurora.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: mturney mturney mturney@codeaurora.org
Gerrit-Comment-Date: Tue, 13 Jul 2021 20:29:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Taniya Das tdas@codeaurora.org
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment