Change in coreboot[master]: util/kconfig: Uprev to Linux 5.3's kconfig

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Patrick Georgi (Code Review)

22 Nov 2019 22 Nov '19

6:16 p.m.

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37152 )

Change subject: util/kconfig: Uprev to Linux 5.3's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.3's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

TODO: - more commits that bring back our modifications, both directly in the code and as a diff in a patches/ subdirectory.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/1

Attachments:

attachment.htm (text/html — 3.6 KB)

Show replies by date

Patrick Georgi (Code Review)

22 Nov 22 Nov

9:05 p.m.

Hello build bot (Jenkins), Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#2).

Change subject: util/kconfig: Uprev to Linux 5.3's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.3's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

- one to remove everything that wasn't our own code, leaving only regex.[ch], toada.c, description.md and Makefile.inc - one to copy in Linux 5.3's scripts/kconfig and adapt Makefile.inc to make the original Makefile work again. - apply: Kconfig: Add KCONFIG_STRICT mode - apply: Kconfig: Change symbol override from warning to notice - apply: util/kconfig/conf.c: Fix newline in error printf - apply: {src,util}: Use NULL instead of 0 for pointer - apply: util/kconfig: Ignore extra symbols in configs instead of failing - apply: util/kconfig: Set parameter of mkdir to only one for mingw. - apply: kconfig: Allow KCONFIG_STRICT outside of confdata.c - apply: kconfig: Add wildcard support for "source"

Change-Id: Ia0e8fe4e9022b278f34ab113a433ef4d45e5c355 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/kconfig/Makefile M util/kconfig/Makefile.inc D util/kconfig/POTFILES.in D util/kconfig/check.sh M util/kconfig/conf.c M util/kconfig/confdata.c M util/kconfig/expr.c M util/kconfig/expr.h A util/kconfig/gconf-cfg.sh M util/kconfig/gconf.c M util/kconfig/images.c A util/kconfig/images.h D util/kconfig/kxgettext.c A util/kconfig/lexer.l M util/kconfig/list.h M util/kconfig/lkc.h M util/kconfig/lkc_proto.h D util/kconfig/lxdialog/.gitignore M util/kconfig/lxdialog/BIG.FAT.WARNING D util/kconfig/lxdialog/check-lxdialog.sh M util/kconfig/lxdialog/checklist.c M util/kconfig/lxdialog/dialog.h M util/kconfig/lxdialog/inputbox.c M util/kconfig/lxdialog/menubox.c M util/kconfig/lxdialog/textbox.c M util/kconfig/lxdialog/util.c M util/kconfig/lxdialog/yesno.c A util/kconfig/mconf-cfg.sh M util/kconfig/mconf.c M util/kconfig/menu.c A util/kconfig/merge_config.sh A util/kconfig/nconf-cfg.sh M util/kconfig/nconf.c M util/kconfig/nconf.gui.c M util/kconfig/nconf.h R util/kconfig/parser.y A util/kconfig/patches/0001-Kconfig-Add-KCONFIG_STRICT-mode.patch A util/kconfig/patches/0002-Kconfig-Change-symbol-override-from-warning-to-notic.patch A util/kconfig/patches/0003-util-kconfig-conf.c-Fix-newline-in-error-printf.patch A util/kconfig/patches/0004-src-util-Use-NULL-instead-of-0-for-pointer.patch A util/kconfig/patches/0005-util-kconfig-Ignore-extra-symbols-in-configs-instead.patch A util/kconfig/patches/0006-util-kconfig-Set-parameter-of-mkdir-to-only-one-for-.patch A util/kconfig/patches/0007-kconfig-Allow-KCONFIG_STRICT-outside-of-confdata.c.patch A util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch A util/kconfig/preprocess.c A util/kconfig/qconf-cfg.sh M util/kconfig/qconf.cc M util/kconfig/qconf.h A util/kconfig/streamline_config.pl M util/kconfig/symbol.c M util/kconfig/util.c D util/kconfig/zconf.gperf D util/kconfig/zconf.hash.c_shipped D util/kconfig/zconf.l D util/kconfig/zconf.lex.c_shipped D util/kconfig/zconf.tab.c_shipped 56 files changed, 4,857 insertions(+), 8,152 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/2

Patrick Georgi (Code Review)

9:55 p.m.

Hello build bot (Jenkins), Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#3).

Change subject: util/kconfig: Uprev to Linux 5.3's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.3's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/3

Stefan Reinauer (Code Review)

10:41 p.m.

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37152 )

Change subject: util/kconfig: Uprev to Linux 5.3's kconfig ......................................................................

Patch Set 3: Code-Review+1

(1 comment)

This change is ready for review.

https://review.coreboot.org/c/coreboot/+/37152/3/util/kconfig/patches/0001-K... File util/kconfig/patches/0001-Kconfig-Add-KCONFIG_STRICT-mode.patch:

https://review.coreboot.org/c/coreboot/+/37152/3/util/kconfig/patches/0001-K... PS3, Line 1: From Wow, this is really great.

Stefan Reinauer (Code Review)

10:42 p.m.

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37152 )

Change subject: util/kconfig: Uprev to Linux 5.3's kconfig ......................................................................

Patch Set 3:

make[1]: Entering directory '.../workspace/coreboot-gerrit' make[1]: *** No rule to make target 'oldconfig'. Stop. make[1]: Leaving directory '.../workspace/coreboot-gerrit'

Patrick Georgi (Code Review)

10:45 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37152 )

Change subject: util/kconfig: Uprev to Linux 5.3's kconfig ......................................................................

Patch Set 3:

this still has known bugs, but the parent commits should be fine to go in

Patrick Georgi (Code Review)

25 Nov 25 Nov

12:44 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.4's kconfig

Hello Stefan Reinauer, build bot (Jenkins), Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#4).

Change subject: util/kconfig: Uprev to Linux 5.4's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.4's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

The patches are now in util/kconfig/patches/, reverse applying them should lead to a util/kconfig/ tree that contains exactly the Linux version + our own 5 files.

TODO: apply more patches to make the new kconfig functionally equivalent to our old one. Main missing item is emitting unchanged default-0/false values as #define, without which the tree won't build.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/4

Patrick Georgi (Code Review)

3:40 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.4's kconfig

Hello Stefan Reinauer, build bot (Jenkins), Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#5).

Change subject: util/kconfig: Uprev to Linux 5.4's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.4's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

The patches are now in util/kconfig/patches/, reverse applying them should lead to a util/kconfig/ tree that contains exactly the Linux version + our own 5 files.

TODO: apply more patches to make the new kconfig functionally equivalent to our old one. Main missing item is emitting unchanged default-0/false values as #define, without which the tree won't build.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/5

caveh jalali (Code Review)

10 Dec 10 Dec

5:59 a.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.4's kconfig

caveh jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37152 )

Change subject: util/kconfig: Uprev to Linux 5.4's kconfig ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37152/5//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37152/5//COMMIT_MSG@7 PS5, Line 7: 5.4 you mentioned 5.3 below. which version did you end up using?

Stefan Reinauer (Code Review)

18 Jan 18 Jan

6:40 a.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.4's kconfig

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37152 )

Change subject: util/kconfig: Uprev to Linux 5.4's kconfig ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37152/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37152/6//COMMIT_MSG@30 PS6, Line 30: Main missing item is emitting unchanged : default-0/false values as #define, without which the tree won't build. Alternatively, do we want to fix up the tree to no longer require this, instead? This "hack" survived since the Config.lb/yapps2 times

Stefan Reinauer (Code Review)

6:54 a.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.4's kconfig

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37152 )

Change subject: util/kconfig: Uprev to Linux 5.4's kconfig ......................................................................

Patch Set 6:

In file included from <command-line>: /home/coreboot/slave-root/workspace/coreboot-gerrit/src/include/kconfig.h:4:10: fatal error: config.h: No such file or directory #include <config.h> ^~~~~~~~~~ compilation terminated.

Patrick Georgi (Code Review)

16 Jun 16 Jun

4:36 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.7's kconfig

Hello build bot (Jenkins), Martin Roth, Stefan Reinauer,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#7).

Change subject: util/kconfig: Uprev to Linux 5.7's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.7's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

- one to remove everything that wasn't our own code, leaving only regex.[ch], toada.c, description.md and Makefile.inc - one to copy in Linux 5.7's scripts/kconfig and adapt Makefile.inc to make the original Makefile work again. - apply: Kconfig: Add KCONFIG_STRICT mode - apply: Kconfig: Change symbol override from warning to notice - apply: util/kconfig/conf.c: Fix newline in error printf - apply: {src,util}: Use NULL instead of 0 for pointer - apply: util/kconfig: Ignore extra symbols in configs instead of failing - apply: util/kconfig: Set parameter of mkdir to only one for mingw. - apply: kconfig: Allow KCONFIG_STRICT outside of confdata.c - apply: kconfig: Add wildcard support for "source" - apply: util/kconfig: Allow emitting false booleans into kconfig output

The patches are now in util/kconfig/patches/, reverse applying them should lead to a util/kconfig/ tree that contains exactly the Linux version + our own 5 files.

TODO: apply more patches to make the new kconfig functionally equivalent to our old one. Main missing item is emitting unchanged default-0/false values as #define, without which the tree won't build.

Change-Id: Ia0e8fe4e9022b278f34ab113a433ef4d45e5c355 Signed-off-by: Patrick Georgi pgeorgi@google.com --- A util/kconfig/.gitignore M util/kconfig/Makefile M util/kconfig/Makefile.inc D util/kconfig/POTFILES.in D util/kconfig/check.sh M util/kconfig/conf.c M util/kconfig/confdata.c M util/kconfig/expr.c M util/kconfig/expr.h A util/kconfig/gconf-cfg.sh M util/kconfig/gconf.c M util/kconfig/images.c A util/kconfig/images.h D util/kconfig/kxgettext.c A util/kconfig/lexer.l M util/kconfig/list.h M util/kconfig/lkc.h M util/kconfig/lkc_proto.h D util/kconfig/lxdialog/.gitignore M util/kconfig/lxdialog/BIG.FAT.WARNING D util/kconfig/lxdialog/check-lxdialog.sh M util/kconfig/lxdialog/checklist.c M util/kconfig/lxdialog/dialog.h M util/kconfig/lxdialog/inputbox.c M util/kconfig/lxdialog/menubox.c M util/kconfig/lxdialog/textbox.c M util/kconfig/lxdialog/util.c M util/kconfig/lxdialog/yesno.c A util/kconfig/mconf-cfg.sh M util/kconfig/mconf.c M util/kconfig/menu.c A util/kconfig/merge_config.sh A util/kconfig/nconf-cfg.sh M util/kconfig/nconf.c M util/kconfig/nconf.gui.c M util/kconfig/nconf.h R util/kconfig/parser.y A util/kconfig/patches/0001-Kconfig-Add-KCONFIG_STRICT-mode.patch A util/kconfig/patches/0002-Kconfig-Change-symbol-override-from-warning-to-notic.patch A util/kconfig/patches/0003-util-kconfig-conf.c-Fix-newline-in-error-printf.patch A util/kconfig/patches/0004-src-util-Use-NULL-instead-of-0-for-pointer.patch A util/kconfig/patches/0005-util-kconfig-Ignore-extra-symbols-in-configs-instead.patch A util/kconfig/patches/0006-util-kconfig-Set-parameter-of-mkdir-to-only-one-for-.patch A util/kconfig/patches/0007-kconfig-Allow-KCONFIG_STRICT-outside-of-confdata.c.patch A util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch A util/kconfig/patches/0009-util-kconfig-Allow-emitting-false-booleans-into-kconfig-output.patch A util/kconfig/patches/series A util/kconfig/preprocess.c A util/kconfig/qconf-cfg.sh M util/kconfig/qconf.cc M util/kconfig/qconf.h A util/kconfig/streamline_config.pl M util/kconfig/symbol.c M util/kconfig/util.c D util/kconfig/zconf.gperf D util/kconfig/zconf.hash.c_shipped D util/kconfig/zconf.l D util/kconfig/zconf.lex.c_shipped D util/kconfig/zconf.tab.c_shipped 59 files changed, 5,150 insertions(+), 8,313 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/7

Stefan Reinauer (Code Review)

17 Jun 17 Jun

1:33 a.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.7's kconfig

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37152 )

Change subject: util/kconfig: Uprev to Linux 5.7's kconfig ......................................................................

Patch Set 7:

Looking pretty good except for the side line projects

util.all: toolchain.inc:147: *** The toolchain architecture for decompressor is unknown. toolchain.inc:147: *** Check your .config file for CONFIG_ARCH_decompressor_* settings. Stop.

coreinfo.coreinfo: make[3]: *** No rule to make target 'build/conf', needed by 'olddefconfig'. Stop.

libpayload.configs: make[3]: *** No rule to make target 'build/conf', needed by 'oldconfig'. Stop.

nvramcui.nvramcui: make[3]: *** No rule to make target '/home/coreboot/slave-root/workspace/coreboot-gerrit/payloads/nvramcui/build/conf', needed by 'defconfig'. Stop.

Patrick Georgi (Code Review)

9:15 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.7's kconfig

Hello build bot (Jenkins), Martin Roth, Stefan Reinauer,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#8).

Change subject: util/kconfig: Uprev to Linux 5.7's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.7's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

The patches are now in util/kconfig/patches/, reverse applying them should lead to a util/kconfig/ tree that contains exactly the Linux version + our own 5 files.

TODO: apply more patches to make the new kconfig functionally equivalent to our old one. Main missing item is emitting unchanged default-0/false values as #define, without which the tree won't build.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/8

Paul Menzel (Code Review)

18 Jun 18 Jun

1:53 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.7's kconfig

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37152 )

Change subject: util/kconfig: Uprev to Linux 5.7's kconfig ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37152/9/util/kconfig/patches/0009-u... File util/kconfig/patches/0009-util-kconfig-Allow-emitting-false-booleans-into-kconfig-output.patch:

https://review.coreboot.org/c/coreboot/+/37152/9/util/kconfig/patches/0009-u... PS9, Line 11: Signed-off-by: Patrick Georgi pgeorgi@google.com It’d be great of you formatted the patches with `git format-patch`.

Patrick Georgi (Code Review)

2:04 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.7's kconfig

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37152 )

Change subject: util/kconfig: Uprev to Linux 5.7's kconfig ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37152/9/util/kconfig/patches/0009-u... File util/kconfig/patches/0009-util-kconfig-Allow-emitting-false-booleans-into-kconfig-output.patch:

https://review.coreboot.org/c/coreboot/+/37152/9/util/kconfig/patches/0009-u... PS9, Line 11: Signed-off-by: Patrick Georgi pgeorgi@google.com

...

It’d be great of you formatted the patches with `git format-patch`.

I don't really maintain them with git anymore, but with quilt. This is historical baggage.

Patrick Georgi (Code Review)

24 Jun 24 Jun

3:33 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.7's kconfig

Hello build bot (Jenkins), Martin Roth, Stefan Reinauer,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#10).

Change subject: util/kconfig: Uprev to Linux 5.7's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.7's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

The patches are now in util/kconfig/patches/, reverse applying them should lead to a util/kconfig/ tree that contains exactly the Linux version + our own 5 files.

TODO: apply more patches to make the new kconfig functionally equivalent to our old one. Main missing item is emitting unchanged default-0/false values as #define, without which the tree won't build.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/10

Patrick Georgi (Code Review)

4:54 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.7's kconfig

Hello build bot (Jenkins), Martin Roth, Stefan Reinauer,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#11).

Change subject: util/kconfig: Uprev to Linux 5.7's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.7's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

The patches are now in util/kconfig/patches/, reverse applying them should lead to a util/kconfig/ tree that contains exactly the Linux version + our own 5 files.

TODO: apply more patches to make the new kconfig functionally equivalent to our old one. Main missing item is emitting unchanged default-0/false values as #define, without which the tree won't build.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/11

Patrick Georgi (Code Review)

5:29 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.7's kconfig

Hello build bot (Jenkins), Martin Roth, Stefan Reinauer,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#12).

Change subject: util/kconfig: Uprev to Linux 5.7's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.7's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

The patches are now in util/kconfig/patches/, reverse applying them should lead to a util/kconfig/ tree that contains exactly the Linux version + our own 5 files.

TODO: apply more patches to make the new kconfig functionally equivalent to our old one. Main missing item is emitting unchanged default-0/false values as #define, without which the tree won't build.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/12

Stefan Reinauer (Code Review)

25 Jun 25 Jun

5:17 a.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.7's kconfig

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37152 )

Change subject: util/kconfig: Uprev to Linux 5.7's kconfig ......................................................................

Patch Set 12:

/home/coreboot/slave-root/workspace/coreboot-gerrit/src/include/kconfig.h:4:10: fatal error: config.h: No such file or directory #include <config.h> ^~~~~~~~~~

Patrick Georgi (Code Review)

9:56 a.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.7's kconfig

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37152 )

Change subject: util/kconfig: Uprev to Linux 5.7's kconfig ......................................................................

Patch Set 12:

...

Patch Set 12:

/home/coreboot/slave-root/workspace/coreboot-gerrit/src/include/kconfig.h:4:10: fatal error: config.h: No such file or directory #include <config.h> ^~~~~~~~~~

The current status of this patch is that it works when building with no parallelism, but creates slightly different images because some CONFIG_* strings are defined empty (e.g. the board family one) that were undefined before.

Patrick Georgi (Code Review)

8:57 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.7's kconfig

Hello build bot (Jenkins), Martin Roth, Stefan Reinauer,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#13).

Change subject: util/kconfig: Uprev to Linux 5.7's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.7's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

The patches are now in util/kconfig/patches/, reverse applying them should lead to a util/kconfig/ tree that contains exactly the Linux version + our own 5 files.

TODO: - Investigate and fix race conditions - Sort out kconfig differences around choice defaults

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/13

Patrick Georgi (Code Review)

18 Aug 18 Aug

9:17 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.8's kconfig

Hello build bot (Jenkins), Martin Roth, Stefan Reinauer,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#14).

Change subject: util/kconfig: Uprev to Linux 5.8's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.8's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

- one to remove everything that wasn't our own code, leaving only regex.[ch], toada.c, description.md and Makefile.inc - one to copy in Linux 5.8's scripts/kconfig and adapt Makefile.inc to make the original Makefile work again. - adapt abuild to use olddefconfig, simplifying matters - apply: Kconfig: Add KCONFIG_STRICT mode - apply: Kconfig: Change symbol override from warning to notice - apply: util/kconfig/conf.c: Fix newline in error printf - apply: {src,util}: Use NULL instead of 0 for pointer - apply: util/kconfig: Ignore extra symbols in configs instead of failing - apply: util/kconfig: Set parameter of mkdir to only one for mingw. - apply: kconfig: Allow KCONFIG_STRICT outside of confdata.c - apply: kconfig: Add wildcard support for "source" - apply: util/kconfig: Allow emitting false booleans into kconfig output

The patches are now in util/kconfig/patches/, reverse applying them should lead to a util/kconfig/ tree that contains exactly the Linux version + our own 5 files.

TODO: - Investigate and fix race conditions - Sort out kconfig differences around choice defaults

Change-Id: Ia0e8fe4e9022b278f34ab113a433ef4d45e5c355 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/abuild/abuild A util/kconfig/.gitignore M util/kconfig/Makefile M util/kconfig/Makefile.inc D util/kconfig/POTFILES.in D util/kconfig/check.sh M util/kconfig/conf.c M util/kconfig/confdata.c M util/kconfig/expr.c M util/kconfig/expr.h A util/kconfig/gconf-cfg.sh M util/kconfig/gconf.c M util/kconfig/images.c A util/kconfig/images.h D util/kconfig/kxgettext.c A util/kconfig/lexer.l M util/kconfig/list.h M util/kconfig/lkc.h M util/kconfig/lkc_proto.h D util/kconfig/lxdialog/.gitignore M util/kconfig/lxdialog/BIG.FAT.WARNING D util/kconfig/lxdialog/check-lxdialog.sh M util/kconfig/lxdialog/checklist.c M util/kconfig/lxdialog/dialog.h M util/kconfig/lxdialog/inputbox.c M util/kconfig/lxdialog/menubox.c M util/kconfig/lxdialog/textbox.c M util/kconfig/lxdialog/util.c M util/kconfig/lxdialog/yesno.c A util/kconfig/mconf-cfg.sh M util/kconfig/mconf.c M util/kconfig/menu.c A util/kconfig/merge_config.sh A util/kconfig/nconf-cfg.sh M util/kconfig/nconf.c M util/kconfig/nconf.gui.c M util/kconfig/nconf.h R util/kconfig/parser.y A util/kconfig/patches/0001-Kconfig-Add-KCONFIG_STRICT-mode.patch A util/kconfig/patches/0002-Kconfig-Change-symbol-override-from-warning-to-notic.patch A util/kconfig/patches/0003-util-kconfig-conf.c-Fix-newline-in-error-printf.patch A util/kconfig/patches/0004-src-util-Use-NULL-instead-of-0-for-pointer.patch A util/kconfig/patches/0005-util-kconfig-Ignore-extra-symbols-in-configs-instead.patch A util/kconfig/patches/0006-util-kconfig-Set-parameter-of-mkdir-to-only-one-for-.patch A util/kconfig/patches/0007-kconfig-Allow-KCONFIG_STRICT-outside-of-confdata.c.patch A util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch A util/kconfig/patches/0009-util-kconfig-Allow-emitting-false-booleans-into-kconfig-output.patch A util/kconfig/patches/series A util/kconfig/preprocess.c A util/kconfig/qconf-cfg.sh M util/kconfig/qconf.cc M util/kconfig/qconf.h A util/kconfig/streamline_config.pl M util/kconfig/symbol.c M util/kconfig/util.c D util/kconfig/zconf.gperf D util/kconfig/zconf.hash.c_shipped D util/kconfig/zconf.l D util/kconfig/zconf.lex.c_shipped D util/kconfig/zconf.tab.c_shipped 60 files changed, 5,339 insertions(+), 8,395 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/14

Patrick Georgi (Code Review)

19 Aug 19 Aug

5:28 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.8's kconfig

Hello build bot (Jenkins), Martin Roth, Stefan Reinauer, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#15).

Change subject: util/kconfig: Uprev to Linux 5.8's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.8's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

The patches are now in util/kconfig/patches/, reverse applying them should lead to a util/kconfig/ tree that contains exactly the Linux version + our own 5 files.

TODO: - Investigate and fix race conditions - Sort out kconfig differences around choice defaults

Change-Id: Ia0e8fe4e9022b278f34ab113a433ef4d45e5c355 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/abuild/abuild A util/kconfig/.gitignore M util/kconfig/Makefile M util/kconfig/Makefile.inc D util/kconfig/POTFILES.in D util/kconfig/check.sh M util/kconfig/conf.c M util/kconfig/confdata.c M util/kconfig/expr.c M util/kconfig/expr.h A util/kconfig/gconf-cfg.sh M util/kconfig/gconf.c M util/kconfig/images.c A util/kconfig/images.h D util/kconfig/kxgettext.c A util/kconfig/lexer.l M util/kconfig/list.h M util/kconfig/lkc.h M util/kconfig/lkc_proto.h D util/kconfig/lxdialog/.gitignore M util/kconfig/lxdialog/BIG.FAT.WARNING D util/kconfig/lxdialog/check-lxdialog.sh M util/kconfig/lxdialog/checklist.c M util/kconfig/lxdialog/dialog.h M util/kconfig/lxdialog/inputbox.c M util/kconfig/lxdialog/menubox.c M util/kconfig/lxdialog/textbox.c M util/kconfig/lxdialog/util.c M util/kconfig/lxdialog/yesno.c A util/kconfig/mconf-cfg.sh M util/kconfig/mconf.c M util/kconfig/menu.c A util/kconfig/merge_config.sh A util/kconfig/nconf-cfg.sh M util/kconfig/nconf.c M util/kconfig/nconf.gui.c M util/kconfig/nconf.h R util/kconfig/parser.y A util/kconfig/patches/0001-Kconfig-Add-KCONFIG_STRICT-mode.patch A util/kconfig/patches/0002-Kconfig-Change-symbol-override-from-warning-to-notic.patch A util/kconfig/patches/0003-util-kconfig-conf.c-Fix-newline-in-error-printf.patch A util/kconfig/patches/0004-src-util-Use-NULL-instead-of-0-for-pointer.patch A util/kconfig/patches/0005-util-kconfig-Ignore-extra-symbols-in-configs-instead.patch A util/kconfig/patches/0006-util-kconfig-Set-parameter-of-mkdir-to-only-one-for-.patch A util/kconfig/patches/0007-kconfig-Allow-KCONFIG_STRICT-outside-of-confdata.c.patch A util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch A util/kconfig/patches/0009-util-kconfig-Allow-emitting-false-booleans-into-kconfig-output.patch A util/kconfig/patches/0010-reenable-source-in-choice.patch A util/kconfig/patches/series A util/kconfig/preprocess.c A util/kconfig/qconf-cfg.sh M util/kconfig/qconf.cc M util/kconfig/qconf.h A util/kconfig/streamline_config.pl M util/kconfig/symbol.c M util/kconfig/util.c D util/kconfig/zconf.gperf D util/kconfig/zconf.hash.c_shipped D util/kconfig/zconf.l D util/kconfig/zconf.lex.c_shipped D util/kconfig/zconf.tab.c_shipped 61 files changed, 5,357 insertions(+), 8,395 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/15

Patrick Georgi (Code Review)

11:03 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.8's kconfig

Hello build bot (Jenkins), Martin Roth, Stefan Reinauer, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#17).

Change subject: util/kconfig: Uprev to Linux 5.8's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.8's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

The patches are now in util/kconfig/patches/, reverse applying them should lead to a util/kconfig/ tree that contains exactly the Linux version + our own 5 files.

TODO: - Investigate and fix race conditions - Sort out kconfig differences around choice defaults

Change-Id: Ia0e8fe4e9022b278f34ab113a433ef4d45e5c355 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/abuild/abuild A util/kconfig/.gitignore M util/kconfig/Makefile M util/kconfig/Makefile.inc D util/kconfig/POTFILES.in D util/kconfig/check.sh M util/kconfig/conf.c M util/kconfig/confdata.c M util/kconfig/expr.c M util/kconfig/expr.h A util/kconfig/gconf-cfg.sh M util/kconfig/gconf.c M util/kconfig/images.c A util/kconfig/images.h D util/kconfig/kxgettext.c A util/kconfig/lexer.l M util/kconfig/list.h M util/kconfig/lkc.h M util/kconfig/lkc_proto.h D util/kconfig/lxdialog/.gitignore M util/kconfig/lxdialog/BIG.FAT.WARNING D util/kconfig/lxdialog/check-lxdialog.sh M util/kconfig/lxdialog/checklist.c M util/kconfig/lxdialog/dialog.h M util/kconfig/lxdialog/inputbox.c M util/kconfig/lxdialog/menubox.c M util/kconfig/lxdialog/textbox.c M util/kconfig/lxdialog/util.c M util/kconfig/lxdialog/yesno.c A util/kconfig/mconf-cfg.sh M util/kconfig/mconf.c M util/kconfig/menu.c A util/kconfig/merge_config.sh A util/kconfig/nconf-cfg.sh M util/kconfig/nconf.c M util/kconfig/nconf.gui.c M util/kconfig/nconf.h R util/kconfig/parser.y A util/kconfig/patches/0001-Kconfig-Add-KCONFIG_STRICT-mode.patch A util/kconfig/patches/0002-Kconfig-Change-symbol-override-from-warning-to-notic.patch A util/kconfig/patches/0003-util-kconfig-conf.c-Fix-newline-in-error-printf.patch A util/kconfig/patches/0004-src-util-Use-NULL-instead-of-0-for-pointer.patch A util/kconfig/patches/0005-util-kconfig-Ignore-extra-symbols-in-configs-instead.patch A util/kconfig/patches/0006-util-kconfig-Set-parameter-of-mkdir-to-only-one-for-.patch A util/kconfig/patches/0007-kconfig-Allow-KCONFIG_STRICT-outside-of-confdata.c.patch A util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch A util/kconfig/patches/0009-util-kconfig-Allow-emitting-false-booleans-into-kconfig-output.patch A util/kconfig/patches/0010-reenable-source-in-choice.patch A util/kconfig/patches/series A util/kconfig/preprocess.c A util/kconfig/qconf-cfg.sh M util/kconfig/qconf.cc M util/kconfig/qconf.h A util/kconfig/streamline_config.pl M util/kconfig/symbol.c M util/kconfig/util.c D util/kconfig/zconf.gperf D util/kconfig/zconf.hash.c_shipped D util/kconfig/zconf.l D util/kconfig/zconf.lex.c_shipped D util/kconfig/zconf.tab.c_shipped 61 files changed, 5,357 insertions(+), 8,395 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/17

Patrick Georgi (Code Review)

20 Aug 20 Aug

12:28 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.8's kconfig

Hello build bot (Jenkins), Martin Roth, Stefan Reinauer, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#19).

Change subject: util/kconfig: Uprev to Linux 5.8's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.8's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

The patches are now in util/kconfig/patches/, reverse applying them should lead to a util/kconfig/ tree that contains exactly the Linux version + our own 5 files.

TODO: - Investigate and fix race conditions - Sort out kconfig differences around choice defaults

Change-Id: Ia0e8fe4e9022b278f34ab113a433ef4d45e5c355 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Documentation/getting_started/kconfig.md M Makefile M tests/Makefile.inc M util/abuild/abuild A util/kconfig/.gitignore M util/kconfig/Makefile M util/kconfig/Makefile.inc D util/kconfig/POTFILES.in D util/kconfig/check.sh M util/kconfig/conf.c M util/kconfig/confdata.c M util/kconfig/expr.c M util/kconfig/expr.h A util/kconfig/gconf-cfg.sh M util/kconfig/gconf.c M util/kconfig/images.c A util/kconfig/images.h D util/kconfig/kxgettext.c A util/kconfig/lexer.l M util/kconfig/list.h M util/kconfig/lkc.h M util/kconfig/lkc_proto.h D util/kconfig/lxdialog/.gitignore M util/kconfig/lxdialog/BIG.FAT.WARNING D util/kconfig/lxdialog/check-lxdialog.sh M util/kconfig/lxdialog/checklist.c M util/kconfig/lxdialog/dialog.h M util/kconfig/lxdialog/inputbox.c M util/kconfig/lxdialog/menubox.c M util/kconfig/lxdialog/textbox.c M util/kconfig/lxdialog/util.c M util/kconfig/lxdialog/yesno.c A util/kconfig/mconf-cfg.sh M util/kconfig/mconf.c M util/kconfig/menu.c A util/kconfig/merge_config.sh A util/kconfig/nconf-cfg.sh M util/kconfig/nconf.c M util/kconfig/nconf.gui.c M util/kconfig/nconf.h R util/kconfig/parser.y A util/kconfig/patches/0001-Kconfig-Add-KCONFIG_STRICT-mode.patch A util/kconfig/patches/0002-Kconfig-Change-symbol-override-from-warning-to-notic.patch A util/kconfig/patches/0003-util-kconfig-conf.c-Fix-newline-in-error-printf.patch A util/kconfig/patches/0004-src-util-Use-NULL-instead-of-0-for-pointer.patch A util/kconfig/patches/0005-util-kconfig-Ignore-extra-symbols-in-configs-instead.patch A util/kconfig/patches/0006-util-kconfig-Set-parameter-of-mkdir-to-only-one-for-.patch A util/kconfig/patches/0007-kconfig-Allow-KCONFIG_STRICT-outside-of-confdata.c.patch A util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch A util/kconfig/patches/0009-util-kconfig-Allow-emitting-false-booleans-into-kconfig-output.patch A util/kconfig/patches/0010-reenable-source-in-choice.patch A util/kconfig/patches/series A util/kconfig/preprocess.c A util/kconfig/qconf-cfg.sh M util/kconfig/qconf.cc M util/kconfig/qconf.h A util/kconfig/streamline_config.pl M util/kconfig/symbol.c M util/kconfig/util.c D util/kconfig/zconf.gperf D util/kconfig/zconf.hash.c_shipped D util/kconfig/zconf.l D util/kconfig/zconf.lex.c_shipped D util/kconfig/zconf.tab.c_shipped 64 files changed, 5,360 insertions(+), 8,401 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/19

Patrick Georgi (Code Review)

1:09 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.8's kconfig

Hello build bot (Jenkins), Martin Roth, Stefan Reinauer, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#20).

Change subject: util/kconfig: Uprev to Linux 5.8's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.8's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

The patches are now in util/kconfig/patches/, reverse applying them should lead to a util/kconfig/ tree that contains exactly the Linux version + our own 5 files.

TODO: - Investigate and fix race conditions - Sort out kconfig differences around choice defaults

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/20

Patrick Georgi (Code Review)

1:43 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.8's kconfig

Hello build bot (Jenkins), Martin Roth, Stefan Reinauer, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#21).

Change subject: util/kconfig: Uprev to Linux 5.8's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.8's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

The patches are now in util/kconfig/patches/, reverse applying them should lead to a util/kconfig/ tree that contains exactly the Linux version + our own 5 files.

TODO: - Investigate and fix race conditions - Sort out kconfig differences around choice defaults

Change-Id: Ia0e8fe4e9022b278f34ab113a433ef4d45e5c355 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Documentation/getting_started/kconfig.md M Makefile M tests/Makefile.inc M util/abuild/abuild A util/kconfig/.gitignore M util/kconfig/Makefile M util/kconfig/Makefile.inc D util/kconfig/POTFILES.in D util/kconfig/check.sh M util/kconfig/conf.c M util/kconfig/confdata.c M util/kconfig/expr.c M util/kconfig/expr.h A util/kconfig/gconf-cfg.sh M util/kconfig/gconf.c M util/kconfig/images.c A util/kconfig/images.h D util/kconfig/kxgettext.c A util/kconfig/lexer.l M util/kconfig/list.h M util/kconfig/lkc.h M util/kconfig/lkc_proto.h D util/kconfig/lxdialog/.gitignore M util/kconfig/lxdialog/BIG.FAT.WARNING D util/kconfig/lxdialog/check-lxdialog.sh M util/kconfig/lxdialog/checklist.c M util/kconfig/lxdialog/dialog.h M util/kconfig/lxdialog/inputbox.c M util/kconfig/lxdialog/menubox.c M util/kconfig/lxdialog/textbox.c M util/kconfig/lxdialog/util.c M util/kconfig/lxdialog/yesno.c A util/kconfig/mconf-cfg.sh M util/kconfig/mconf.c M util/kconfig/menu.c A util/kconfig/merge_config.sh A util/kconfig/nconf-cfg.sh M util/kconfig/nconf.c M util/kconfig/nconf.gui.c M util/kconfig/nconf.h R util/kconfig/parser.y A util/kconfig/patches/0001-Kconfig-Add-KCONFIG_STRICT-mode.patch A util/kconfig/patches/0002-Kconfig-Change-symbol-override-from-warning-to-notic.patch A util/kconfig/patches/0003-util-kconfig-conf.c-Fix-newline-in-error-printf.patch A util/kconfig/patches/0004-src-util-Use-NULL-instead-of-0-for-pointer.patch A util/kconfig/patches/0005-util-kconfig-Ignore-extra-symbols-in-configs-instead.patch A util/kconfig/patches/0006-util-kconfig-Set-parameter-of-mkdir-to-only-one-for-.patch A util/kconfig/patches/0007-kconfig-Allow-KCONFIG_STRICT-outside-of-confdata.c.patch A util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch A util/kconfig/patches/0009-util-kconfig-Allow-emitting-false-booleans-into-kconfig-output.patch A util/kconfig/patches/0010-reenable-source-in-choice.patch A util/kconfig/patches/0011-remove-include-config-hardcodes.patch A util/kconfig/patches/series A util/kconfig/preprocess.c A util/kconfig/qconf-cfg.sh M util/kconfig/qconf.cc M util/kconfig/qconf.h A util/kconfig/streamline_config.pl M util/kconfig/symbol.c M util/kconfig/util.c D util/kconfig/zconf.gperf D util/kconfig/zconf.hash.c_shipped D util/kconfig/zconf.l D util/kconfig/zconf.lex.c_shipped D util/kconfig/zconf.tab.c_shipped 65 files changed, 5,407 insertions(+), 8,398 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/21

Patrick Georgi (Code Review)

8 Sep 8 Sep

10:14 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.8's kconfig

Hello build bot (Jenkins), Martin Roth, Stefan Reinauer, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#22).

Change subject: util/kconfig: Uprev to Linux 5.8's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.8's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

The patches are now in util/kconfig/patches/, reverse applying them should lead to a util/kconfig/ tree that contains exactly the Linux version + our own 5 files.

TODO: - Investigate and fix race conditions - Sort out kconfig differences around choice defaults

Change-Id: Ia0e8fe4e9022b278f34ab113a433ef4d45e5c355 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Documentation/getting_started/kconfig.md M Makefile M tests/Makefile.inc M util/abuild/abuild A util/kconfig/.gitignore M util/kconfig/Makefile M util/kconfig/Makefile.inc D util/kconfig/POTFILES.in D util/kconfig/check.sh M util/kconfig/conf.c M util/kconfig/confdata.c M util/kconfig/expr.c M util/kconfig/expr.h A util/kconfig/gconf-cfg.sh M util/kconfig/gconf.c M util/kconfig/images.c A util/kconfig/images.h D util/kconfig/kxgettext.c A util/kconfig/lexer.l M util/kconfig/list.h M util/kconfig/lkc.h M util/kconfig/lkc_proto.h D util/kconfig/lxdialog/.gitignore M util/kconfig/lxdialog/BIG.FAT.WARNING D util/kconfig/lxdialog/check-lxdialog.sh M util/kconfig/lxdialog/checklist.c M util/kconfig/lxdialog/dialog.h M util/kconfig/lxdialog/inputbox.c M util/kconfig/lxdialog/menubox.c M util/kconfig/lxdialog/textbox.c M util/kconfig/lxdialog/util.c M util/kconfig/lxdialog/yesno.c A util/kconfig/mconf-cfg.sh M util/kconfig/mconf.c M util/kconfig/menu.c A util/kconfig/merge_config.sh A util/kconfig/nconf-cfg.sh M util/kconfig/nconf.c M util/kconfig/nconf.gui.c M util/kconfig/nconf.h R util/kconfig/parser.y A util/kconfig/patches/0001-Kconfig-Add-KCONFIG_STRICT-mode.patch A util/kconfig/patches/0002-Kconfig-Change-symbol-override-from-warning-to-notic.patch A util/kconfig/patches/0003-util-kconfig-conf.c-Fix-newline-in-error-printf.patch A util/kconfig/patches/0004-src-util-Use-NULL-instead-of-0-for-pointer.patch A util/kconfig/patches/0005-util-kconfig-Ignore-extra-symbols-in-configs-instead.patch A util/kconfig/patches/0006-util-kconfig-Set-parameter-of-mkdir-to-only-one-for-.patch A util/kconfig/patches/0007-kconfig-Allow-KCONFIG_STRICT-outside-of-confdata.c.patch A util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch A util/kconfig/patches/0009-util-kconfig-Allow-emitting-false-booleans-into-kconfig-output.patch A util/kconfig/patches/0010-reenable-source-in-choice.patch A util/kconfig/patches/0011-remove-include-config-hardcodes.patch A util/kconfig/patches/series A util/kconfig/preprocess.c A util/kconfig/qconf-cfg.sh M util/kconfig/qconf.cc M util/kconfig/qconf.h A util/kconfig/streamline_config.pl M util/kconfig/symbol.c M util/kconfig/util.c D util/kconfig/zconf.gperf D util/kconfig/zconf.hash.c_shipped D util/kconfig/zconf.l D util/kconfig/zconf.lex.c_shipped D util/kconfig/zconf.tab.c_shipped 65 files changed, 5,408 insertions(+), 8,399 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/22

Patrick Georgi (Code Review)

20 Jan 20 Jan

7:57 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.10's kconfig

Hello build bot (Jenkins), Martin Roth, Stefan Reinauer, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#23).

Change subject: util/kconfig: Uprev to Linux 5.10's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.10's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

The patches are now in util/kconfig/patches/, reverse applying them should lead to a util/kconfig/ tree that contains exactly the Linux version + our own 5 files.

TODO: - Investigate and fix race conditions - Sort out kconfig differences around choice defaults

Change-Id: Ia0e8fe4e9022b278f34ab113a433ef4d45e5c355 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Documentation/getting_started/kconfig.md M Makefile M tests/Makefile.inc M util/abuild/abuild A util/kconfig/.gitignore M util/kconfig/Makefile M util/kconfig/Makefile.inc D util/kconfig/POTFILES.in D util/kconfig/check.sh M util/kconfig/conf.c M util/kconfig/confdata.c M util/kconfig/expr.c M util/kconfig/expr.h A util/kconfig/gconf-cfg.sh M util/kconfig/gconf.c M util/kconfig/images.c A util/kconfig/images.h D util/kconfig/kxgettext.c A util/kconfig/lexer.l M util/kconfig/list.h M util/kconfig/lkc.h M util/kconfig/lkc_proto.h D util/kconfig/lxdialog/.gitignore M util/kconfig/lxdialog/BIG.FAT.WARNING D util/kconfig/lxdialog/check-lxdialog.sh M util/kconfig/lxdialog/checklist.c M util/kconfig/lxdialog/dialog.h M util/kconfig/lxdialog/inputbox.c M util/kconfig/lxdialog/menubox.c M util/kconfig/lxdialog/textbox.c M util/kconfig/lxdialog/util.c M util/kconfig/lxdialog/yesno.c A util/kconfig/mconf-cfg.sh M util/kconfig/mconf.c M util/kconfig/menu.c A util/kconfig/merge_config.sh A util/kconfig/nconf-cfg.sh M util/kconfig/nconf.c M util/kconfig/nconf.gui.c M util/kconfig/nconf.h R util/kconfig/parser.y A util/kconfig/patches/0001-Kconfig-Add-KCONFIG_STRICT-mode.patch A util/kconfig/patches/0002-Kconfig-Change-symbol-override-from-warning-to-notic.patch A util/kconfig/patches/0003-util-kconfig-conf.c-Fix-newline-in-error-printf.patch A util/kconfig/patches/0004-src-util-Use-NULL-instead-of-0-for-pointer.patch A util/kconfig/patches/0005-util-kconfig-Ignore-extra-symbols-in-configs-instead.patch A util/kconfig/patches/0006-util-kconfig-Set-parameter-of-mkdir-to-only-one-for-.patch A util/kconfig/patches/0007-kconfig-Allow-KCONFIG_STRICT-outside-of-confdata.c.patch A util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch A util/kconfig/patches/0009-util-kconfig-Allow-emitting-false-booleans-into-kconfig-output.patch A util/kconfig/patches/0010-reenable-source-in-choice.patch A util/kconfig/patches/0011-remove-include-config-hardcodes.patch A util/kconfig/patches/series A util/kconfig/preprocess.c A util/kconfig/qconf-cfg.sh M util/kconfig/qconf.cc M util/kconfig/qconf.h A util/kconfig/streamline_config.pl M util/kconfig/symbol.c M util/kconfig/util.c D util/kconfig/zconf.gperf D util/kconfig/zconf.hash.c_shipped D util/kconfig/zconf.l D util/kconfig/zconf.lex.c_shipped D util/kconfig/zconf.tab.c_shipped 65 files changed, 5,750 insertions(+), 8,881 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/23

Patrick Georgi (Code Review)

25 Jan 25 Jan

12:41 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.10's kconfig

Hello build bot (Jenkins), Martin Roth, Stefan Reinauer, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#24).

Change subject: util/kconfig: Uprev to Linux 5.10's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.10's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

The patches are now in util/kconfig/patches/, reverse applying them should lead to a util/kconfig/ tree that contains exactly the Linux version + our own 5 files.

TODO: - Investigate and fix race conditions - Sort out kconfig differences around choice defaults

Change-Id: Ia0e8fe4e9022b278f34ab113a433ef4d45e5c355 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Documentation/getting_started/kconfig.md M Makefile M tests/Makefile.inc M util/abuild/abuild A util/kconfig/.gitignore M util/kconfig/Makefile M util/kconfig/Makefile.inc D util/kconfig/POTFILES.in D util/kconfig/check.sh M util/kconfig/conf.c M util/kconfig/confdata.c M util/kconfig/expr.c M util/kconfig/expr.h A util/kconfig/gconf-cfg.sh M util/kconfig/gconf.c M util/kconfig/images.c A util/kconfig/images.h D util/kconfig/kxgettext.c A util/kconfig/lexer.l M util/kconfig/list.h M util/kconfig/lkc.h M util/kconfig/lkc_proto.h D util/kconfig/lxdialog/.gitignore M util/kconfig/lxdialog/BIG.FAT.WARNING D util/kconfig/lxdialog/check-lxdialog.sh M util/kconfig/lxdialog/checklist.c M util/kconfig/lxdialog/dialog.h M util/kconfig/lxdialog/inputbox.c M util/kconfig/lxdialog/menubox.c M util/kconfig/lxdialog/textbox.c M util/kconfig/lxdialog/util.c M util/kconfig/lxdialog/yesno.c A util/kconfig/mconf-cfg.sh M util/kconfig/mconf.c M util/kconfig/menu.c A util/kconfig/merge_config.sh A util/kconfig/nconf-cfg.sh M util/kconfig/nconf.c M util/kconfig/nconf.gui.c M util/kconfig/nconf.h R util/kconfig/parser.y A util/kconfig/patches/0001-Kconfig-Add-KCONFIG_STRICT-mode.patch A util/kconfig/patches/0002-Kconfig-Change-symbol-override-from-warning-to-notic.patch A util/kconfig/patches/0003-util-kconfig-conf.c-Fix-newline-in-error-printf.patch A util/kconfig/patches/0004-src-util-Use-NULL-instead-of-0-for-pointer.patch A util/kconfig/patches/0005-util-kconfig-Ignore-extra-symbols-in-configs-instead.patch A util/kconfig/patches/0006-util-kconfig-Set-parameter-of-mkdir-to-only-one-for-.patch A util/kconfig/patches/0007-kconfig-Allow-KCONFIG_STRICT-outside-of-confdata.c.patch A util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch A util/kconfig/patches/0009-util-kconfig-Allow-emitting-false-booleans-into-kconfig-output.patch A util/kconfig/patches/0010-reenable-source-in-choice.patch A util/kconfig/patches/0011-remove-include-config-hardcodes.patch A util/kconfig/patches/series A util/kconfig/preprocess.c A util/kconfig/qconf-cfg.sh M util/kconfig/qconf.cc M util/kconfig/qconf.h A util/kconfig/streamline_config.pl M util/kconfig/symbol.c M util/kconfig/util.c D util/kconfig/zconf.gperf D util/kconfig/zconf.hash.c_shipped D util/kconfig/zconf.l D util/kconfig/zconf.lex.c_shipped D util/kconfig/zconf.tab.c_shipped 65 files changed, 5,750 insertions(+), 8,881 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/24

Patrick Georgi (Code Review)

9 May 9 May

10:04 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.12's kconfig

Hello build bot (Jenkins), Martin Roth, Stefan Reinauer, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#25).

Change subject: util/kconfig: Uprev to Linux 5.12's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.12's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

- one to remove everything that wasn't our own code, leaving only regex.[ch], toada.c, description.md and Makefile.inc - one to copy in Linux 5.12's scripts/kconfig and adapt Makefile.inc to make the original Makefile work again. - adapt abuild to use olddefconfig, simplifying matters - apply patches in util/kconfig/patches/

The patches are now in util/kconfig/patches/, reverse applying them should lead to a util/kconfig/ tree that contains exactly the Linux version + our own 5 files.

TODO: - Investigate and fix race conditions - Sort out kconfig differences around choice defaults

Change-Id: Ia0e8fe4e9022b278f34ab113a433ef4d45e5c355 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Documentation/getting_started/kconfig.md M Makefile M tests/Makefile.inc M util/abuild/abuild A util/kconfig/.gitignore M util/kconfig/Makefile M util/kconfig/Makefile.inc D util/kconfig/POTFILES.in D util/kconfig/check.sh M util/kconfig/conf.c M util/kconfig/confdata.c M util/kconfig/expr.c M util/kconfig/expr.h A util/kconfig/gconf-cfg.sh M util/kconfig/gconf.c M util/kconfig/images.c A util/kconfig/images.h D util/kconfig/kxgettext.c A util/kconfig/lexer.l M util/kconfig/list.h M util/kconfig/lkc.h M util/kconfig/lkc_proto.h D util/kconfig/lxdialog/.gitignore D util/kconfig/lxdialog/check-lxdialog.sh M util/kconfig/lxdialog/checklist.c M util/kconfig/lxdialog/dialog.h M util/kconfig/lxdialog/inputbox.c M util/kconfig/lxdialog/menubox.c M util/kconfig/lxdialog/textbox.c M util/kconfig/lxdialog/util.c M util/kconfig/lxdialog/yesno.c A util/kconfig/mconf-cfg.sh M util/kconfig/mconf.c M util/kconfig/menu.c A util/kconfig/merge_config.sh A util/kconfig/nconf-cfg.sh M util/kconfig/nconf.c M util/kconfig/nconf.gui.c M util/kconfig/nconf.h R util/kconfig/parser.y A util/kconfig/patches/0001-Kconfig-Add-KCONFIG_STRICT-mode.patch A util/kconfig/patches/0002-Kconfig-Change-symbol-override-from-warning-to-notic.patch A util/kconfig/patches/0003-util-kconfig-conf.c-Fix-newline-in-error-printf.patch A util/kconfig/patches/0004-src-util-Use-NULL-instead-of-0-for-pointer.patch A util/kconfig/patches/0005-util-kconfig-Ignore-extra-symbols-in-configs-instead.patch A util/kconfig/patches/0006-util-kconfig-Set-parameter-of-mkdir-to-only-one-for-.patch A util/kconfig/patches/0007-kconfig-Allow-KCONFIG_STRICT-outside-of-confdata.c.patch A util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch A util/kconfig/patches/0009-util-kconfig-Allow-emitting-false-booleans-into-kconfig-output.patch A util/kconfig/patches/0010-reenable-source-in-choice.patch A util/kconfig/patches/0011-remove-include-config-hardcodes.patch A util/kconfig/patches/series A util/kconfig/preprocess.c A util/kconfig/qconf-cfg.sh M util/kconfig/qconf.cc M util/kconfig/qconf.h A util/kconfig/streamline_config.pl M util/kconfig/symbol.c M util/kconfig/util.c D util/kconfig/zconf.gperf D util/kconfig/zconf.hash.c_shipped D util/kconfig/zconf.l D util/kconfig/zconf.lex.c_shipped D util/kconfig/zconf.tab.c_shipped 64 files changed, 5,811 insertions(+), 8,950 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/25

Patrick Georgi (Code Review)

28 Jun 28 Jun

2:23 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.13's kconfig

Attention is currently required from: Jakub Czapiga. Hello build bot (Jenkins), Martin Roth, Jakub Czapiga, Stefan Reinauer, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#26).

Change subject: util/kconfig: Uprev to Linux 5.13's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.13's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

- one to remove everything that wasn't our own code, leaving only regex.[ch], toada.c, description.md and Makefile.inc - one to copy in Linux 5.13's scripts/kconfig and adapt Makefile.inc to make the original Makefile work again. - adapt abuild to use olddefconfig, simplifying matters - apply patches in util/kconfig/patches/

The patches are now in util/kconfig/patches/, reverse applying them should lead to a util/kconfig/ tree that contains exactly the Linux version + our own 5 files.

TODO: - Investigate and fix race conditions - Sort out kconfig differences around choice defaults

Change-Id: Ia0e8fe4e9022b278f34ab113a433ef4d45e5c355 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Documentation/getting_started/kconfig.md M Makefile M tests/Makefile.inc M util/abuild/abuild A util/kconfig/.gitignore M util/kconfig/Makefile M util/kconfig/Makefile.inc D util/kconfig/POTFILES.in D util/kconfig/check.sh M util/kconfig/conf.c M util/kconfig/confdata.c M util/kconfig/expr.c M util/kconfig/expr.h A util/kconfig/gconf-cfg.sh M util/kconfig/gconf.c M util/kconfig/images.c A util/kconfig/images.h A util/kconfig/internal.h D util/kconfig/kxgettext.c A util/kconfig/lexer.l M util/kconfig/list.h M util/kconfig/lkc.h M util/kconfig/lkc_proto.h D util/kconfig/lxdialog/.gitignore D util/kconfig/lxdialog/check-lxdialog.sh M util/kconfig/lxdialog/checklist.c M util/kconfig/lxdialog/dialog.h M util/kconfig/lxdialog/inputbox.c M util/kconfig/lxdialog/menubox.c M util/kconfig/lxdialog/textbox.c M util/kconfig/lxdialog/util.c M util/kconfig/lxdialog/yesno.c A util/kconfig/mconf-cfg.sh M util/kconfig/mconf.c M util/kconfig/menu.c A util/kconfig/merge_config.sh A util/kconfig/nconf-cfg.sh M util/kconfig/nconf.c M util/kconfig/nconf.gui.c M util/kconfig/nconf.h R util/kconfig/parser.y A util/kconfig/patches/0001-Kconfig-Add-KCONFIG_STRICT-mode.patch A util/kconfig/patches/0002-Kconfig-Change-symbol-override-from-warning-to-notic.patch A util/kconfig/patches/0003-util-kconfig-conf.c-Fix-newline-in-error-printf.patch A util/kconfig/patches/0004-src-util-Use-NULL-instead-of-0-for-pointer.patch A util/kconfig/patches/0005-util-kconfig-Ignore-extra-symbols-in-configs-instead.patch A util/kconfig/patches/0006-util-kconfig-Set-parameter-of-mkdir-to-only-one-for-.patch A util/kconfig/patches/0007-kconfig-Allow-KCONFIG_STRICT-outside-of-confdata.c.patch A util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch A util/kconfig/patches/0009-util-kconfig-Allow-emitting-false-booleans-into-kconfig-output.patch A util/kconfig/patches/0010-reenable-source-in-choice.patch A util/kconfig/patches/0011-remove-include-config-hardcodes.patch A util/kconfig/patches/series A util/kconfig/preprocess.c A util/kconfig/qconf-cfg.sh M util/kconfig/qconf.cc M util/kconfig/qconf.h A util/kconfig/streamline_config.pl M util/kconfig/symbol.c M util/kconfig/util.c D util/kconfig/zconf.gperf D util/kconfig/zconf.hash.c_shipped D util/kconfig/zconf.l D util/kconfig/zconf.lex.c_shipped D util/kconfig/zconf.tab.c_shipped 65 files changed, 6,254 insertions(+), 9,478 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/26

Patrick Georgi (Code Review)

6:19 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.13's kconfig

Attention is currently required from: Jakub Czapiga. Hello build bot (Jenkins), Martin Roth, Jakub Czapiga, Stefan Reinauer, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#27).

Change subject: util/kconfig: Uprev to Linux 5.13's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.13's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

The patches are now in util/kconfig/patches/, reverse applying them should lead to a util/kconfig/ tree that contains exactly the Linux version + our own 5 files.

Change-Id: Ia0e8fe4e9022b278f34ab113a433ef4d45e5c355 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Documentation/getting_started/kconfig.md M Makefile M tests/Makefile.inc M util/abuild/abuild A util/kconfig/.gitignore M util/kconfig/Makefile M util/kconfig/Makefile.inc D util/kconfig/POTFILES.in D util/kconfig/check.sh M util/kconfig/conf.c M util/kconfig/confdata.c M util/kconfig/expr.c M util/kconfig/expr.h A util/kconfig/gconf-cfg.sh M util/kconfig/gconf.c M util/kconfig/images.c A util/kconfig/images.h A util/kconfig/internal.h D util/kconfig/kxgettext.c A util/kconfig/lexer.l M util/kconfig/list.h M util/kconfig/lkc.h M util/kconfig/lkc_proto.h D util/kconfig/lxdialog/.gitignore D util/kconfig/lxdialog/check-lxdialog.sh M util/kconfig/lxdialog/checklist.c M util/kconfig/lxdialog/dialog.h M util/kconfig/lxdialog/inputbox.c M util/kconfig/lxdialog/menubox.c M util/kconfig/lxdialog/textbox.c M util/kconfig/lxdialog/util.c M util/kconfig/lxdialog/yesno.c A util/kconfig/mconf-cfg.sh M util/kconfig/mconf.c M util/kconfig/menu.c A util/kconfig/merge_config.sh A util/kconfig/nconf-cfg.sh M util/kconfig/nconf.c M util/kconfig/nconf.gui.c M util/kconfig/nconf.h R util/kconfig/parser.y A util/kconfig/patches/0001-Kconfig-Add-KCONFIG_STRICT-mode.patch A util/kconfig/patches/0002-Kconfig-Change-symbol-override-from-warning-to-notic.patch A util/kconfig/patches/0003-util-kconfig-conf.c-Fix-newline-in-error-printf.patch A util/kconfig/patches/0004-src-util-Use-NULL-instead-of-0-for-pointer.patch A util/kconfig/patches/0005-util-kconfig-Ignore-extra-symbols-in-configs-instead.patch A util/kconfig/patches/0006-util-kconfig-Set-parameter-of-mkdir-to-only-one-for-.patch A util/kconfig/patches/0007-kconfig-Allow-KCONFIG_STRICT-outside-of-confdata.c.patch A util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch A util/kconfig/patches/0009-util-kconfig-Allow-emitting-false-booleans-into-kconfig-output.patch A util/kconfig/patches/0010-reenable-source-in-choice.patch A util/kconfig/patches/0011-remove-include-config-hardcodes.patch A util/kconfig/patches/series A util/kconfig/preprocess.c A util/kconfig/qconf-cfg.sh M util/kconfig/qconf.cc M util/kconfig/qconf.h A util/kconfig/streamline_config.pl M util/kconfig/symbol.c M util/kconfig/util.c D util/kconfig/zconf.gperf D util/kconfig/zconf.hash.c_shipped D util/kconfig/zconf.l D util/kconfig/zconf.lex.c_shipped D util/kconfig/zconf.tab.c_shipped 65 files changed, 6,254 insertions(+), 9,478 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/27

Patrick Georgi (Code Review)

12 Jul 12 Jul

11:11 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.13's kconfig

Attention is currently required from: Jakub Czapiga. Hello build bot (Jenkins), Martin Roth, Jakub Czapiga, Stefan Reinauer, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#29).

Change subject: util/kconfig: Uprev to Linux 5.13's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.13's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

The patches are now in util/kconfig/patches/, reverse applying them should lead to a util/kconfig/ tree that contains exactly the Linux version + our own 5 files.

Change-Id: Ia0e8fe4e9022b278f34ab113a433ef4d45e5c355 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Documentation/getting_started/kconfig.md M Makefile M tests/Makefile.inc M util/abuild/abuild A util/kconfig/.gitignore M util/kconfig/Makefile M util/kconfig/Makefile.inc D util/kconfig/POTFILES.in D util/kconfig/check.sh M util/kconfig/conf.c M util/kconfig/confdata.c M util/kconfig/expr.c M util/kconfig/expr.h A util/kconfig/gconf-cfg.sh M util/kconfig/gconf.c M util/kconfig/images.c A util/kconfig/images.h A util/kconfig/internal.h D util/kconfig/kxgettext.c A util/kconfig/lexer.l M util/kconfig/list.h M util/kconfig/lkc.h M util/kconfig/lkc_proto.h D util/kconfig/lxdialog/.gitignore D util/kconfig/lxdialog/check-lxdialog.sh M util/kconfig/lxdialog/checklist.c M util/kconfig/lxdialog/dialog.h M util/kconfig/lxdialog/inputbox.c M util/kconfig/lxdialog/menubox.c M util/kconfig/lxdialog/textbox.c M util/kconfig/lxdialog/util.c M util/kconfig/lxdialog/yesno.c A util/kconfig/mconf-cfg.sh M util/kconfig/mconf.c M util/kconfig/menu.c A util/kconfig/merge_config.sh A util/kconfig/nconf-cfg.sh M util/kconfig/nconf.c M util/kconfig/nconf.gui.c M util/kconfig/nconf.h R util/kconfig/parser.y A util/kconfig/patches/0001-Kconfig-Add-KCONFIG_STRICT-mode.patch A util/kconfig/patches/0002-Kconfig-Change-symbol-override-from-warning-to-notic.patch A util/kconfig/patches/0003-util-kconfig-conf.c-Fix-newline-in-error-printf.patch A util/kconfig/patches/0004-src-util-Use-NULL-instead-of-0-for-pointer.patch A util/kconfig/patches/0005-util-kconfig-Ignore-extra-symbols-in-configs-instead.patch A util/kconfig/patches/0006-util-kconfig-Set-parameter-of-mkdir-to-only-one-for-.patch A util/kconfig/patches/0007-kconfig-Allow-KCONFIG_STRICT-outside-of-confdata.c.patch A util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch A util/kconfig/patches/0009-util-kconfig-Allow-emitting-false-booleans-into-kconfig-output.patch A util/kconfig/patches/0010-reenable-source-in-choice.patch A util/kconfig/patches/0011-remove-include-config-hardcodes.patch A util/kconfig/patches/0012-safer-tmpfiles.patch A util/kconfig/patches/series A util/kconfig/preprocess.c A util/kconfig/qconf-cfg.sh M util/kconfig/qconf.cc M util/kconfig/qconf.h A util/kconfig/streamline_config.pl M util/kconfig/symbol.c M util/kconfig/util.c D util/kconfig/zconf.gperf D util/kconfig/zconf.hash.c_shipped D util/kconfig/zconf.l D util/kconfig/zconf.lex.c_shipped D util/kconfig/zconf.tab.c_shipped 66 files changed, 6,376 insertions(+), 9,469 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/29

Patrick Georgi (Code Review)

11:37 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.13's kconfig

Attention is currently required from: Jakub Czapiga. Hello build bot (Jenkins), Martin Roth, Jakub Czapiga, Stefan Reinauer, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#30).

Change subject: util/kconfig: Uprev to Linux 5.13's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.13's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

The patches are now in util/kconfig/patches/, reverse applying them should lead to a util/kconfig/ tree that contains exactly the Linux version + our own 5 files.

Change-Id: Ia0e8fe4e9022b278f34ab113a433ef4d45e5c355 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Documentation/getting_started/kconfig.md M Makefile M tests/Makefile.inc M util/abuild/abuild A util/kconfig/.gitignore M util/kconfig/Makefile M util/kconfig/Makefile.inc D util/kconfig/POTFILES.in D util/kconfig/check.sh M util/kconfig/conf.c M util/kconfig/confdata.c M util/kconfig/expr.c M util/kconfig/expr.h A util/kconfig/gconf-cfg.sh M util/kconfig/gconf.c M util/kconfig/images.c A util/kconfig/images.h A util/kconfig/internal.h D util/kconfig/kxgettext.c A util/kconfig/lexer.l M util/kconfig/list.h M util/kconfig/lkc.h M util/kconfig/lkc_proto.h D util/kconfig/lxdialog/.gitignore D util/kconfig/lxdialog/check-lxdialog.sh M util/kconfig/lxdialog/checklist.c M util/kconfig/lxdialog/dialog.h M util/kconfig/lxdialog/inputbox.c M util/kconfig/lxdialog/menubox.c M util/kconfig/lxdialog/textbox.c M util/kconfig/lxdialog/util.c M util/kconfig/lxdialog/yesno.c A util/kconfig/mconf-cfg.sh M util/kconfig/mconf.c M util/kconfig/menu.c A util/kconfig/merge_config.sh A util/kconfig/nconf-cfg.sh M util/kconfig/nconf.c M util/kconfig/nconf.gui.c M util/kconfig/nconf.h R util/kconfig/parser.y A util/kconfig/patches/0001-Kconfig-Add-KCONFIG_STRICT-mode.patch A util/kconfig/patches/0002-Kconfig-Change-symbol-override-from-warning-to-notic.patch A util/kconfig/patches/0003-util-kconfig-conf.c-Fix-newline-in-error-printf.patch A util/kconfig/patches/0004-src-util-Use-NULL-instead-of-0-for-pointer.patch A util/kconfig/patches/0005-util-kconfig-Ignore-extra-symbols-in-configs-instead.patch A util/kconfig/patches/0006-util-kconfig-Set-parameter-of-mkdir-to-only-one-for-.patch A util/kconfig/patches/0007-kconfig-Allow-KCONFIG_STRICT-outside-of-confdata.c.patch A util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch A util/kconfig/patches/0009-util-kconfig-Allow-emitting-false-booleans-into-kconfig-output.patch A util/kconfig/patches/0010-reenable-source-in-choice.patch A util/kconfig/patches/0011-remove-include-config-hardcodes.patch A util/kconfig/patches/0012-safer-tmpfiles.patch A util/kconfig/patches/series A util/kconfig/preprocess.c A util/kconfig/qconf-cfg.sh M util/kconfig/qconf.cc M util/kconfig/qconf.h A util/kconfig/streamline_config.pl M util/kconfig/symbol.c M util/kconfig/util.c D util/kconfig/zconf.gperf D util/kconfig/zconf.hash.c_shipped D util/kconfig/zconf.l D util/kconfig/zconf.lex.c_shipped D util/kconfig/zconf.tab.c_shipped 66 files changed, 6,394 insertions(+), 9,470 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/30

Patrick Georgi (Code Review)

11:59 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.13's kconfig

Attention is currently required from: Raul Rangel, Jakub Czapiga. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37152 )

Change subject: util/kconfig: Uprev to Linux 5.13's kconfig ......................................................................

Patch Set 30:

(1 comment)

File util/kconfig/patches/0012-safer-tmpfiles.patch:

PS30: Raul, mind taking a look at this patch (also part of the changes to confdata.c) since it's derived from your commit? I kept conf_mktemp, but everything else was essentially rewritten from scratch because kconfig's file handling changed so much during the update.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37152 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0e8fe4e9022b278f34ab113a433ef4d45e5c355 Gerrit-Change-Number: 37152 Gerrit-PatchSet: 30 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Jakub Czapiga jacz@semihalf.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Caveh Jalali caveh@chromium.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Raul Rangel rrangel@chromium.org Gerrit-Attention: Jakub Czapiga jacz@semihalf.com Gerrit-Comment-Date: Mon, 12 Jul 2021 21:59:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

13 Jul 13 Jul

10:05 a.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.13's kconfig

Attention is currently required from: Raul Rangel, Jakub Czapiga. Hello build bot (Jenkins), Raul Rangel, Martin Roth, Jakub Czapiga, Stefan Reinauer, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#31).

Change subject: util/kconfig: Uprev to Linux 5.13's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.13's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

The patches are now in util/kconfig/patches/, reverse applying them should lead to a util/kconfig/ tree that contains exactly the Linux version + our own 5 files.

Change-Id: Ia0e8fe4e9022b278f34ab113a433ef4d45e5c355 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Documentation/getting_started/kconfig.md M Makefile M payloads/coreinfo/Makefile M payloads/libpayload/Makefile M tests/Makefile.inc M util/abuild/abuild A util/kconfig/.gitignore M util/kconfig/Makefile M util/kconfig/Makefile.inc D util/kconfig/POTFILES.in D util/kconfig/check.sh M util/kconfig/conf.c M util/kconfig/confdata.c M util/kconfig/expr.c M util/kconfig/expr.h A util/kconfig/gconf-cfg.sh M util/kconfig/gconf.c M util/kconfig/images.c A util/kconfig/images.h A util/kconfig/internal.h D util/kconfig/kxgettext.c A util/kconfig/lexer.l M util/kconfig/list.h M util/kconfig/lkc.h M util/kconfig/lkc_proto.h D util/kconfig/lxdialog/.gitignore D util/kconfig/lxdialog/check-lxdialog.sh M util/kconfig/lxdialog/checklist.c M util/kconfig/lxdialog/dialog.h M util/kconfig/lxdialog/inputbox.c M util/kconfig/lxdialog/menubox.c M util/kconfig/lxdialog/textbox.c M util/kconfig/lxdialog/util.c M util/kconfig/lxdialog/yesno.c A util/kconfig/mconf-cfg.sh M util/kconfig/mconf.c M util/kconfig/menu.c A util/kconfig/merge_config.sh A util/kconfig/nconf-cfg.sh M util/kconfig/nconf.c M util/kconfig/nconf.gui.c M util/kconfig/nconf.h R util/kconfig/parser.y A util/kconfig/patches/0001-Kconfig-Add-KCONFIG_STRICT-mode.patch A util/kconfig/patches/0002-Kconfig-Change-symbol-override-from-warning-to-notic.patch A util/kconfig/patches/0003-util-kconfig-conf.c-Fix-newline-in-error-printf.patch A util/kconfig/patches/0004-src-util-Use-NULL-instead-of-0-for-pointer.patch A util/kconfig/patches/0005-util-kconfig-Ignore-extra-symbols-in-configs-instead.patch A util/kconfig/patches/0006-util-kconfig-Set-parameter-of-mkdir-to-only-one-for-.patch A util/kconfig/patches/0007-kconfig-Allow-KCONFIG_STRICT-outside-of-confdata.c.patch A util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch A util/kconfig/patches/0009-util-kconfig-Allow-emitting-false-booleans-into-kconfig-output.patch A util/kconfig/patches/0010-reenable-source-in-choice.patch A util/kconfig/patches/0011-remove-include-config-hardcodes.patch A util/kconfig/patches/0012-safer-tmpfiles.patch A util/kconfig/patches/series A util/kconfig/preprocess.c A util/kconfig/qconf-cfg.sh M util/kconfig/qconf.cc M util/kconfig/qconf.h A util/kconfig/streamline_config.pl M util/kconfig/symbol.c M util/kconfig/util.c D util/kconfig/zconf.gperf D util/kconfig/zconf.hash.c_shipped D util/kconfig/zconf.l D util/kconfig/zconf.lex.c_shipped D util/kconfig/zconf.tab.c_shipped 68 files changed, 6,404 insertions(+), 9,475 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/31

Patrick Georgi (Code Review)

1:58 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.13's kconfig

Attention is currently required from: Raul Rangel, Jakub Czapiga. Hello build bot (Jenkins), Raul Rangel, Martin Roth, Jakub Czapiga, Stefan Reinauer, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#32).

Change subject: util/kconfig: Uprev to Linux 5.13's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.13's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

- one to remove everything that wasn't our own code, leaving only regex.[ch], toada.c, description.md and Makefile.inc. - one to copy in Linux 5.13's scripts/kconfig and adapt Makefile.inc to make the original Makefile work again. - adapt abuild to use olddefconfig, simplifying matters. - apply patches in util/kconfig/patches. - Some more adaptations to the libpayload build system.

The patches are now in util/kconfig/patches/, reverse applying them should lead to a util/kconfig/ tree that contains exactly the Linux version + our own 5 files.

Change-Id: Ia0e8fe4e9022b278f34ab113a433ef4d45e5c355 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Documentation/getting_started/kconfig.md M Makefile M payloads/coreinfo/Makefile M payloads/libpayload/Makefile M payloads/libpayload/Makefile.payload M tests/Makefile.inc M util/abuild/abuild A util/kconfig/.gitignore M util/kconfig/Makefile M util/kconfig/Makefile.inc D util/kconfig/POTFILES.in D util/kconfig/check.sh M util/kconfig/conf.c M util/kconfig/confdata.c M util/kconfig/expr.c M util/kconfig/expr.h A util/kconfig/gconf-cfg.sh M util/kconfig/gconf.c M util/kconfig/images.c A util/kconfig/images.h A util/kconfig/internal.h D util/kconfig/kxgettext.c A util/kconfig/lexer.l M util/kconfig/list.h M util/kconfig/lkc.h M util/kconfig/lkc_proto.h D util/kconfig/lxdialog/.gitignore D util/kconfig/lxdialog/check-lxdialog.sh M util/kconfig/lxdialog/checklist.c M util/kconfig/lxdialog/dialog.h M util/kconfig/lxdialog/inputbox.c M util/kconfig/lxdialog/menubox.c M util/kconfig/lxdialog/textbox.c M util/kconfig/lxdialog/util.c M util/kconfig/lxdialog/yesno.c A util/kconfig/mconf-cfg.sh M util/kconfig/mconf.c M util/kconfig/menu.c A util/kconfig/merge_config.sh A util/kconfig/nconf-cfg.sh M util/kconfig/nconf.c M util/kconfig/nconf.gui.c M util/kconfig/nconf.h R util/kconfig/parser.y A util/kconfig/patches/0001-Kconfig-Add-KCONFIG_STRICT-mode.patch A util/kconfig/patches/0002-Kconfig-Change-symbol-override-from-warning-to-notic.patch A util/kconfig/patches/0003-util-kconfig-conf.c-Fix-newline-in-error-printf.patch A util/kconfig/patches/0004-src-util-Use-NULL-instead-of-0-for-pointer.patch A util/kconfig/patches/0005-util-kconfig-Ignore-extra-symbols-in-configs-instead.patch A util/kconfig/patches/0006-util-kconfig-Set-parameter-of-mkdir-to-only-one-for-.patch A util/kconfig/patches/0007-kconfig-Allow-KCONFIG_STRICT-outside-of-confdata.c.patch A util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch A util/kconfig/patches/0009-util-kconfig-Allow-emitting-false-booleans-into-kconfig-output.patch A util/kconfig/patches/0010-reenable-source-in-choice.patch A util/kconfig/patches/0011-remove-include-config-hardcodes.patch A util/kconfig/patches/0012-safer-tmpfiles.patch A util/kconfig/patches/series A util/kconfig/preprocess.c A util/kconfig/qconf-cfg.sh M util/kconfig/qconf.cc M util/kconfig/qconf.h A util/kconfig/streamline_config.pl M util/kconfig/symbol.c M util/kconfig/util.c D util/kconfig/zconf.gperf D util/kconfig/zconf.hash.c_shipped D util/kconfig/zconf.l D util/kconfig/zconf.lex.c_shipped D util/kconfig/zconf.tab.c_shipped 69 files changed, 6,406 insertions(+), 9,475 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/32

Patrick Georgi (Code Review)

2:26 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.13's kconfig

Attention is currently required from: Raul Rangel, Jakub Czapiga. Hello build bot (Jenkins), Raul Rangel, Martin Roth, Jakub Czapiga, Stefan Reinauer, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37152

to look at the new patch set (#33).

Change subject: util/kconfig: Uprev to Linux 5.13's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.13's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

The patches are now in util/kconfig/patches/, reverse applying them should lead to a util/kconfig/ tree that contains exactly the Linux version + our own 5 files.

Change-Id: Ia0e8fe4e9022b278f34ab113a433ef4d45e5c355 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Documentation/getting_started/kconfig.md M Makefile M payloads/coreinfo/Makefile M payloads/libpayload/Makefile M payloads/libpayload/Makefile.payload M tests/Makefile.inc M util/abuild/abuild A util/kconfig/.gitignore M util/kconfig/Makefile M util/kconfig/Makefile.inc D util/kconfig/POTFILES.in D util/kconfig/check.sh M util/kconfig/conf.c M util/kconfig/confdata.c M util/kconfig/expr.c M util/kconfig/expr.h A util/kconfig/gconf-cfg.sh M util/kconfig/gconf.c M util/kconfig/images.c A util/kconfig/images.h A util/kconfig/internal.h D util/kconfig/kxgettext.c A util/kconfig/lexer.l M util/kconfig/list.h M util/kconfig/lkc.h M util/kconfig/lkc_proto.h D util/kconfig/lxdialog/.gitignore D util/kconfig/lxdialog/check-lxdialog.sh M util/kconfig/lxdialog/checklist.c M util/kconfig/lxdialog/dialog.h M util/kconfig/lxdialog/inputbox.c M util/kconfig/lxdialog/menubox.c M util/kconfig/lxdialog/textbox.c M util/kconfig/lxdialog/util.c M util/kconfig/lxdialog/yesno.c A util/kconfig/mconf-cfg.sh M util/kconfig/mconf.c M util/kconfig/menu.c A util/kconfig/merge_config.sh A util/kconfig/nconf-cfg.sh M util/kconfig/nconf.c M util/kconfig/nconf.gui.c M util/kconfig/nconf.h R util/kconfig/parser.y A util/kconfig/patches/0001-Kconfig-Add-KCONFIG_STRICT-mode.patch A util/kconfig/patches/0002-Kconfig-Change-symbol-override-from-warning-to-notic.patch A util/kconfig/patches/0003-util-kconfig-conf.c-Fix-newline-in-error-printf.patch A util/kconfig/patches/0004-src-util-Use-NULL-instead-of-0-for-pointer.patch A util/kconfig/patches/0005-util-kconfig-Ignore-extra-symbols-in-configs-instead.patch A util/kconfig/patches/0006-util-kconfig-Set-parameter-of-mkdir-to-only-one-for-.patch A util/kconfig/patches/0007-kconfig-Allow-KCONFIG_STRICT-outside-of-confdata.c.patch A util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch A util/kconfig/patches/0009-util-kconfig-Allow-emitting-false-booleans-into-kconfig-output.patch A util/kconfig/patches/0010-reenable-source-in-choice.patch A util/kconfig/patches/0011-remove-include-config-hardcodes.patch A util/kconfig/patches/0012-safer-tmpfiles.patch A util/kconfig/patches/series A util/kconfig/preprocess.c A util/kconfig/qconf-cfg.sh M util/kconfig/qconf.cc M util/kconfig/qconf.h A util/kconfig/streamline_config.pl M util/kconfig/symbol.c M util/kconfig/util.c D util/kconfig/zconf.gperf D util/kconfig/zconf.hash.c_shipped D util/kconfig/zconf.l D util/kconfig/zconf.lex.c_shipped D util/kconfig/zconf.tab.c_shipped 69 files changed, 6,407 insertions(+), 9,476 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37152/33

Patrick Georgi (Code Review)

2:45 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.13's kconfig

Attention is currently required from: Raul Rangel, Jakub Czapiga, Stefan Reinauer. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37152 )

Change subject: util/kconfig: Uprev to Linux 5.13's kconfig ......................................................................

Patch Set 33:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/37152/comment/a8bc8218_f7d2c229 PS5, Line 7: 5.4

...

you mentioned 5.3 below. which version did […]

Updated every now and then. Now 5.13.

Commit Message:

https://review.coreboot.org/c/coreboot/+/37152/comment/c318cc95_0fe5f5d2 PS6, Line 30: Main missing item is emitting unchanged : default-0/false values as #define, without which the tree won't build.

...

Alternatively, do we want to fix up the tree to no longer require this, instead? This "hack" survive […]

Maybe, maybe not? With this change we have a kconfig code base (+ patches) that enables doing such work with relative safety that we're not messing things up even more, but I don't think it should be part of this commit.

File util/kconfig/patches/0001-Kconfig-Add-KCONFIG_STRICT-mode.patch:

https://review.coreboot.org/c/coreboot/+/37152/comment/1374aaab_c6186e32 PS3, Line 1: From

...

Wow, this is really great.

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/37152 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0e8fe4e9022b278f34ab113a433ef4d45e5c355 Gerrit-Change-Number: 37152 Gerrit-PatchSet: 33 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Jakub Czapiga jacz@semihalf.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Caveh Jalali caveh@chromium.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Raul Rangel rrangel@chromium.org Gerrit-Attention: Jakub Czapiga jacz@semihalf.com Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Tue, 13 Jul 2021 12:45:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Caveh Jalali caveh@chromium.org Comment-In-Reply-To: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-MessageType: comment

Raul Rangel (Code Review)

4:58 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.13's kconfig

Attention is currently required from: Jakub Czapiga, Stefan Reinauer. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37152 )

Change subject: util/kconfig: Uprev to Linux 5.13's kconfig ......................................................................

Patch Set 33: Code-Review+2

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/37152/comment/0849f0aa_56f2c84f PS33, Line 20: patches Ugh, I should try and upstream my patch. Or we could also evaluate switching to Kconfiglib :)

-- To view, visit https://review.coreboot.org/c/coreboot/+/37152 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0e8fe4e9022b278f34ab113a433ef4d45e5c355 Gerrit-Change-Number: 37152 Gerrit-PatchSet: 33 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Jakub Czapiga jacz@semihalf.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Felix Singer felixsinger@posteo.net Gerrit-CC: Caveh Jalali caveh@chromium.org Gerrit-CC: Jack Rosenthal jrosenth@chromium.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Jakub Czapiga jacz@semihalf.com Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Tue, 13 Jul 2021 14:58:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

5:03 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.13's kconfig

Attention is currently required from: Jakub Czapiga, Stefan Reinauer. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37152 )

Change subject: util/kconfig: Uprev to Linux 5.13's kconfig ......................................................................

Patch Set 33:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/37152/comment/a89ccf9b_bd0851ed PS33, Line 20: patches

...

Ugh, I should try and upstream my patch. […]

Kconfiglib is python, so the answer on that is no.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37152 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0e8fe4e9022b278f34ab113a433ef4d45e5c355 Gerrit-Change-Number: 37152 Gerrit-PatchSet: 33 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Jakub Czapiga jacz@semihalf.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Felix Singer felixsinger@posteo.net Gerrit-CC: Caveh Jalali caveh@chromium.org Gerrit-CC: Jack Rosenthal jrosenth@chromium.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Jakub Czapiga jacz@semihalf.com Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Tue, 13 Jul 2021 15:03:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel rrangel@chromium.org Gerrit-MessageType: comment

Patrick Georgi (Code Review)

5:17 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.13's kconfig

Attention is currently required from: Jakub Czapiga, Stefan Reinauer. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37152 )

Change subject: util/kconfig: Uprev to Linux 5.13's kconfig ......................................................................

Patch Set 33:

(1 comment)

File util/kconfig/patches/0012-safer-tmpfiles.patch:

PS30:

...

Raul, mind taking a look at this patch (also part of the changes to confdata. […]

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/37152 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0e8fe4e9022b278f34ab113a433ef4d45e5c355 Gerrit-Change-Number: 37152 Gerrit-PatchSet: 33 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Jakub Czapiga jacz@semihalf.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Felix Singer felixsinger@posteo.net Gerrit-CC: Caveh Jalali caveh@chromium.org Gerrit-CC: Jack Rosenthal jrosenth@chromium.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Jakub Czapiga jacz@semihalf.com Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Tue, 13 Jul 2021 15:17:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

Jack Rosenthal (Code Review)

6:06 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.13's kconfig

Attention is currently required from: Raul Rangel, Jakub Czapiga, Stefan Reinauer. Jack Rosenthal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37152 )

Change subject: util/kconfig: Uprev to Linux 5.13's kconfig ......................................................................

Patch Set 33:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/37152/comment/7ae237e9_2f072aee PS33, Line 20: patches

...

Kconfiglib is python, so the answer on that is no.

I don't think we should throw out kconfiglib here

I worked with Martin Roth on this a while ago, and he was quite excited to adopt Kconfiglib ...

-- To view, visit https://review.coreboot.org/c/coreboot/+/37152 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0e8fe4e9022b278f34ab113a433ef4d45e5c355 Gerrit-Change-Number: 37152 Gerrit-PatchSet: 33 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Jakub Czapiga jacz@semihalf.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Felix Singer felixsinger@posteo.net Gerrit-CC: Caveh Jalali caveh@chromium.org Gerrit-CC: Jack Rosenthal jrosenth@chromium.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Raul Rangel rrangel@chromium.org Gerrit-Attention: Jakub Czapiga jacz@semihalf.com Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Tue, 13 Jul 2021 16:06:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel rrangel@chromium.org Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

10:27 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.13's kconfig

Attention is currently required from: Raul Rangel, Jakub Czapiga, Stefan Reinauer. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37152 )

Change subject: util/kconfig: Uprev to Linux 5.13's kconfig ......................................................................

Patch Set 33:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/37152/comment/a5811a71_69af514c PS33, Line 20: patches

...

I don't think we should throw out kconfiglib here […]

While I don't see that happening, it doesn't stop us from cleaning up the technical debt of our wildly massaged kconfig (without a clear base version!), either.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37152 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0e8fe4e9022b278f34ab113a433ef4d45e5c355 Gerrit-Change-Number: 37152 Gerrit-PatchSet: 33 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Jakub Czapiga jacz@semihalf.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Felix Singer felixsinger@posteo.net Gerrit-CC: Caveh Jalali caveh@chromium.org Gerrit-CC: Jack Rosenthal jrosenth@chromium.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Raul Rangel rrangel@chromium.org Gerrit-Attention: Jakub Czapiga jacz@semihalf.com Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Tue, 13 Jul 2021 20:27:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel rrangel@chromium.org Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Comment-In-Reply-To: Jack Rosenthal jrosenth@chromium.org Gerrit-MessageType: comment

Patrick Georgi (Code Review)

10:28 p.m.

New subject: Change in coreboot[master]: util/kconfig: Uprev to Linux 5.13's kconfig

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37152 )

Change subject: util/kconfig: Uprev to Linux 5.13's kconfig ......................................................................

util/kconfig: Uprev to Linux 5.13's kconfig

This was originally several commits that had to be squashed into one because the intermediate states weren't able to build coreboot:

The patches are now in util/kconfig/patches/, reverse applying them should lead to a util/kconfig/ tree that contains exactly the Linux version + our own 5 files.

Change-Id: Ia0e8fe4e9022b278f34ab113a433ef4d45e5c355 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37152 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Raul Rangel rrangel@chromium.org --- M Documentation/getting_started/kconfig.md M Makefile M payloads/coreinfo/Makefile M payloads/libpayload/Makefile M payloads/libpayload/Makefile.payload M tests/Makefile.inc M util/abuild/abuild A util/kconfig/.gitignore M util/kconfig/Makefile M util/kconfig/Makefile.inc D util/kconfig/POTFILES.in D util/kconfig/check.sh M util/kconfig/conf.c M util/kconfig/confdata.c M util/kconfig/expr.c M util/kconfig/expr.h A util/kconfig/gconf-cfg.sh M util/kconfig/gconf.c M util/kconfig/images.c A util/kconfig/images.h A util/kconfig/internal.h D util/kconfig/kxgettext.c A util/kconfig/lexer.l M util/kconfig/list.h M util/kconfig/lkc.h M util/kconfig/lkc_proto.h D util/kconfig/lxdialog/.gitignore D util/kconfig/lxdialog/check-lxdialog.sh M util/kconfig/lxdialog/checklist.c M util/kconfig/lxdialog/dialog.h M util/kconfig/lxdialog/inputbox.c M util/kconfig/lxdialog/menubox.c M util/kconfig/lxdialog/textbox.c M util/kconfig/lxdialog/util.c M util/kconfig/lxdialog/yesno.c A util/kconfig/mconf-cfg.sh M util/kconfig/mconf.c M util/kconfig/menu.c A util/kconfig/merge_config.sh A util/kconfig/nconf-cfg.sh M util/kconfig/nconf.c M util/kconfig/nconf.gui.c M util/kconfig/nconf.h R util/kconfig/parser.y A util/kconfig/patches/0001-Kconfig-Add-KCONFIG_STRICT-mode.patch A util/kconfig/patches/0002-Kconfig-Change-symbol-override-from-warning-to-notic.patch A util/kconfig/patches/0003-util-kconfig-conf.c-Fix-newline-in-error-printf.patch A util/kconfig/patches/0004-src-util-Use-NULL-instead-of-0-for-pointer.patch A util/kconfig/patches/0005-util-kconfig-Ignore-extra-symbols-in-configs-instead.patch A util/kconfig/patches/0006-util-kconfig-Set-parameter-of-mkdir-to-only-one-for-.patch A util/kconfig/patches/0007-kconfig-Allow-KCONFIG_STRICT-outside-of-confdata.c.patch A util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch A util/kconfig/patches/0009-util-kconfig-Allow-emitting-false-booleans-into-kconfig-output.patch A util/kconfig/patches/0010-reenable-source-in-choice.patch A util/kconfig/patches/0011-remove-include-config-hardcodes.patch A util/kconfig/patches/0012-safer-tmpfiles.patch A util/kconfig/patches/series A util/kconfig/preprocess.c A util/kconfig/qconf-cfg.sh M util/kconfig/qconf.cc M util/kconfig/qconf.h A util/kconfig/streamline_config.pl M util/kconfig/symbol.c M util/kconfig/util.c D util/kconfig/zconf.gperf D util/kconfig/zconf.hash.c_shipped D util/kconfig/zconf.l D util/kconfig/zconf.lex.c_shipped D util/kconfig/zconf.tab.c_shipped 69 files changed, 6,407 insertions(+), 9,476 deletions(-)

Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved

1011

days inactive

1610

days old

coreboot-gerrit@coreboot.org

46 comments

6 participants

tags (0)

participants (6)

caveh jalali (Code Review)
Jack Rosenthal (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)
Raul Rangel (Code Review)
Stefan Reinauer (Code Review)