Change in coreboot[master]: mb/google/hatch/variant/kohaku: Drop early gpio MEM_STRAP conf

[Edward O'Callaghan (Code Review)]

Hello Edward O'Callaghan,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/37589

to review the following change.

Change subject: mb/google/hatch/variant/kohaku: Drop early gpio MEM_STRAP conf
......................................................................

mb/google/hatch/variant/kohaku: Drop early gpio MEM_STRAP conf

No need to configure the mem_strap in the early gpio block and again
later. Fixes commit 5a0edcbde1537.

BUG=b:144895517
BRANCH=hatch
TEST=./util/abuild/abuild -p none -t google/hatch -x -a

Change-Id: I963d0ade9941ebbb57856baecb8b126a51ed9ded
Signed-off-by: Edward O'Callaghan 
---
M src/mainboard/google/hatch/variants/kohaku/gpio.c
1 file changed, 0 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/37589/1

diff --git a/src/mainboard/google/hatch/variants/kohaku/gpio.c b/src/mainboard/google/hatch/variants/kohaku/gpio.c
index 61d3375..4ebd258 100644
--- a/src/mainboard/google/hatch/variants/kohaku/gpio.c
+++ b/src/mainboard/google/hatch/variants/kohaku/gpio.c
@@ -119,14 +119,6 @@
    PAD_CFG_NF(GPP_E5, NONE, PLTRST, NF1),
    /* F2  : MEM_CH_SEL */
    PAD_CFG_GPI(GPP_F2, NONE, PLTRST),
-	/* F11 : PCH_MEM_STRAP2 */
-	PAD_CFG_GPI(GPP_F11, NONE, PLTRST),
-	/* F20 : PCH_MEM_STRAP0 */
-	PAD_CFG_GPI(GPP_F20, NONE, PLTRST),
-	/* F21 : PCH_MEM_STRAP1 */
-	PAD_CFG_GPI(GPP_F21, NONE, PLTRST),
-	/* F22 : PCH_MEM_STRAP3 */
-	PAD_CFG_GPI(GPP_F22, NONE, PLTRST),
 };

const struct pad_config *variant_early_gpio_table(size_t *num)

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37589 )

Change subject: mb/google/hatch/variant/kohaku: Drop early gpio MEM_STRAP conf
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37589/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37589/2//COMMIT_MSG@9 
PS2, Line 9: No need to configure the mem_strap in the early gpio block and again
           : later. 
This is not about configuring early and again later. The reason why the MEM_STRAP gpios were not added to early_gpio table is because the routines that make use of the MEM_STRAP gpios run before ramstage is run and those routines configure the pads before reading them. Hence as this comment suggests https://review.coreboot.org/c/coreboot/+/37589/2/src/mainboard/google/hatch/..., MEM_STAP gpios were intentially not configured in early_gpio table.

The configuration in ramstage is mostly a don't care since nothing after romstage really looks at the straps.

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37589 )

Change subject: mb/google/hatch/variant/kohaku: Drop early gpio MEM_STRAP conf
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37589/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37589/2//COMMIT_MSG@10 
PS2, Line 10: 5a0edcbde1537
Please also add the commit message summary after the hash in ().

[XS] Change in coreboot[master]: mb/google/hatch/variant/kohaku: Drop early gpio MEM_STRAP conf

[Martin L Roth (Code Review)]

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37589?usp=email )

Change subject: mb/google/hatch/variant/kohaku: Drop early gpio MEM_STRAP conf
......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.