Change in coreboot[master]: New PCI ID for Family 15h (Models 60h-6fh) I/O Memory Management Unit
Name of user not set #1002701 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37548 )
Change subject: New PCI ID for Family 15h (Models 60h-6fh) I/O Memory Management Unit ......................................................................
New PCI ID for Family 15h (Models 60h-6fh) I/O Memory Management Unit
The 1022:1577 IOMMU device is found in the AMD Bettong board.
Change-Id: I536ec4f24e210fa2e85e87eb4cbfde179f8c7f0f Signed-off-by: Jorge Fernandez jorgefm@cirsa.com --- M src/include/device/pci_ids.h M src/soc/amd/common/block/iommu/iommu.c 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/37548/1
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 6444bc1..1276994 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -303,6 +303,7 @@ #define PCI_DEVICE_ID_AMD_17H_MODEL_101F_NB 0x15d0 #define PCI_DEVICE_ID_AMD_15H_MODEL_101F_NB_IOMMU 0x1419 #define PCI_DEVICE_ID_AMD_15H_MODEL_303F_NB_IOMMU 0x1423 +#define PCI_DEVICE_ID_AMD_15H_MODEL_606F_NB_IOMMU 0x1577 #define PCI_DEVICE_ID_AMD_15H_MODEL_707F_NB_IOMMU 0x1577 #define PCI_DEVICE_ID_AMD_16H_MODEL_303F_NB_IOMMU 0x1567 #define PCI_DEVICE_ID_AMD_17H_MODEL_101F_NB_IOMMU 0x15d1 diff --git a/src/soc/amd/common/block/iommu/iommu.c b/src/soc/amd/common/block/iommu/iommu.c index 18c8e66..c8b1ff7 100644 --- a/src/soc/amd/common/block/iommu/iommu.c +++ b/src/soc/amd/common/block/iommu/iommu.c @@ -47,6 +47,7 @@
static const unsigned short pci_device_ids[] = { PCI_DEVICE_ID_AMD_15H_MODEL_303F_NB_IOMMU, + PCI_DEVICE_ID_AMD_15H_MODEL_606F_NB_IOMMU, PCI_DEVICE_ID_AMD_15H_MODEL_707F_NB_IOMMU, PCI_DEVICE_ID_AMD_17H_MODEL_101F_NB_IOMMU, 0
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37548 )
Change subject: New PCI ID for Family 15h (Models 60h-6fh) I/O Memory Management Unit ......................................................................
Patch Set 1:
(2 comments)
Should the macro be renamed?
https://review.coreboot.org/c/coreboot/+/37548/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37548/1//COMMIT_MSG@7 PS1, Line 7: New PCI ID for Family 15h (Models 60h-6fh) I/O Memory Management Unit Please rephrase.
https://review.coreboot.org/c/coreboot/+/37548/1/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/37548/1/src/include/device/pci_ids.... PS1, Line 307: #define PCI_DEVICE_ID_AMD_15H_MODEL_707F_NB_IOMMU 0x1577 It’s the same ID.
Hello Marshall Dawson, build bot (Jenkins), Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37548
to look at the new patch set (#2).
Change subject: amd/hudson: Add PCI ID for Family 15h (Models 60h-6fh) I/O Memory Management Unit ......................................................................
amd/hudson: Add PCI ID for Family 15h (Models 60h-6fh) I/O Memory Management Unit
The 1022:1577 IOMMU device is found in the AMD Bettong board. It's added to clarify that it belongs to a different family than the already present PCI_DEVICE_ID_AMD_15H_MODEL_707F_NB_IOMMU ID.
Change-Id: I536ec4f24e210fa2e85e87eb4cbfde179f8c7f0f Signed-off-by: Jorge Fernandez jorgefm@cirsa.com --- M src/include/device/pci_ids.h M src/soc/amd/common/block/iommu/iommu.c 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/37548/2
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37548?usp=email )
Change subject: amd/hudson: Add PCI ID for Family 15h (Models 60h-6fh) I/O Memory Management Unit ......................................................................
Abandoned
This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.
-
Martin L Roth (Code Review) -
Name of user not set (Code Review)
-
Paul Menzel (Code Review)