Change in coreboot[master]: drivers/mrc_cache: generate debug messages for MRC cache update

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Jonathan Zhang (Code Review)

1 Jun 2020 1 Jun '20

5:08 p.m.

Jonathan Zhang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41981 )

Change subject: drivers/mrc_cache: generate debug messages for MRC cache update ......................................................................

drivers/mrc_cache: generate debug messages for MRC cache update

When MRC cached data update is performed, messages are written to event log, which is flash based. For system that does not have flash based event log, the messages are lost.

Added corresponding BIOS_DEBUG messages.

Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: I1ef4794151fea7213c8317ddc898b0e37da280b5 --- M src/drivers/mrc_cache/mrc_cache.c 1 file changed, 6 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/41981/1

diff --git a/src/drivers/mrc_cache/mrc_cache.c b/src/drivers/mrc_cache/mrc_cache.c index 4e6e91c..73f5701 100644 --- a/src/drivers/mrc_cache/mrc_cache.c +++ b/src/drivers/mrc_cache/mrc_cache.c @@ -397,6 +397,7 @@ return;

if (!mrc_cache_needs_update(&latest_rdev, to_be_updated)) { + printk(BIOS_DEBUG, "MRC: '%s' does not need update.\n", cr->name); log_event_cache_update(cr->elog_slot, ALREADY_UPTODATE); return; } @@ -405,10 +406,13 @@

if (region_file_update_data(&cache_file, cbmem_entry_start(to_be_updated), - cbmem_entry_size(to_be_updated)) < 0) + cbmem_entry_size(to_be_updated)) < 0){ + printk(BIOS_DEBUG, "MRC: failed to update '%s'.\n", cr->name); log_event_cache_update(cr->elog_slot, UPDATE_FAILURE); - else + } else { + printk(BIOS_DEBUG, "MRC: updated '%s'.\n", cr->name); log_event_cache_update(cr->elog_slot, UPDATE_SUCCESS); + } }

/* Read flash status register to determine if write protect is active */

Attachments:

attachment.htm (text/html — 3.6 KB)

Show replies by date

build bot (Jenkins) (Code Review)

1 Jun 1 Jun

5:09 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41981 )

Change subject: drivers/mrc_cache: generate debug messages for MRC cache update ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41981/1/src/drivers/mrc_cache/mrc_c... File src/drivers/mrc_cache/mrc_cache.c:

https://review.coreboot.org/c/coreboot/+/41981/1/src/drivers/mrc_cache/mrc_c... PS1, Line 409: cbmem_entry_size(to_be_updated)) < 0){ space required before the open brace '{'

Patrick Rudolph (Code Review)

11:42 p.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41981 )

Change subject: drivers/mrc_cache: generate debug messages for MRC cache update ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/41981 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ef4794151fea7213c8317ddc898b0e37da280b5 Gerrit-Change-Number: 41981 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Aaron Durbin adurbin@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Ron Minnich rminnich@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 02 Jun 2020 05:42:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

2 Jun 2 Jun

1:19 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41981 )

Change subject: drivers/mrc_cache: generate debug messages for MRC cache update ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41981/1/src/drivers/mrc_cache/mrc_c... File src/drivers/mrc_cache/mrc_cache.c:

https://review.coreboot.org/c/coreboot/+/41981/1/src/drivers/mrc_cache/mrc_c... PS1, Line 409: cbmem_entry_size(to_be_updated)) < 0){

...

space required before the open brace '{'

Please take care of this.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41981 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ef4794151fea7213c8317ddc898b0e37da280b5 Gerrit-Change-Number: 41981 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Aaron Durbin adurbin@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Ron Minnich rminnich@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Tue, 02 Jun 2020 07:19:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: comment

Jonathan Zhang (Code Review)

4:04 p.m.

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41981 )

Change subject: drivers/mrc_cache: generate debug messages for MRC cache update ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41981/1/src/drivers/mrc_cache/mrc_c... File src/drivers/mrc_cache/mrc_cache.c:

https://review.coreboot.org/c/coreboot/+/41981/1/src/drivers/mrc_cache/mrc_c... PS1, Line 409: cbmem_entry_size(to_be_updated)) < 0){

...

Please take care of this.

Sure, of course!

-- To view, visit https://review.coreboot.org/c/coreboot/+/41981 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ef4794151fea7213c8317ddc898b0e37da280b5 Gerrit-Change-Number: 41981 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Aaron Durbin adurbin@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Ron Minnich rminnich@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Tue, 02 Jun 2020 22:04:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: build bot (Jenkins) no-reply@coreboot.org Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

Jonathan Zhang (Code Review)

4:06 p.m.

Hello build bot (Jenkins), Aaron Durbin, Stefan Reinauer, Duncan Laurie, Arthur Heymans, Patrick Rudolph, Ron Minnich,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41981

to look at the new patch set (#2).

Change subject: drivers/mrc_cache: generate debug messages for MRC cache update ......................................................................

drivers/mrc_cache: generate debug messages for MRC cache update

When MRC cached data update is performed, messages are written to event log, which is flash based. For system that does not have flash based event log, the messages are lost.

Added corresponding BIOS_DEBUG messages.

Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: I1ef4794151fea7213c8317ddc898b0e37da280b5 --- M src/drivers/mrc_cache/mrc_cache.c 1 file changed, 6 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/41981/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41981 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ef4794151fea7213c8317ddc898b0e37da280b5 Gerrit-Change-Number: 41981 Gerrit-PatchSet: 2 Gerrit-Owner: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Aaron Durbin adurbin@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Ron Minnich rminnich@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: newpatchset

Duncan Laurie (Code Review)

4:08 p.m.

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41981 )

Change subject: drivers/mrc_cache: generate debug messages for MRC cache update ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41981 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ef4794151fea7213c8317ddc898b0e37da280b5 Gerrit-Change-Number: 41981 Gerrit-PatchSet: 2 Gerrit-Owner: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Aaron Durbin adurbin@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Ron Minnich rminnich@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Tue, 02 Jun 2020 22:08:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

4:45 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41981 )

Change subject: drivers/mrc_cache: generate debug messages for MRC cache update ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/41981 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ef4794151fea7213c8317ddc898b0e37da280b5 Gerrit-Change-Number: 41981 Gerrit-PatchSet: 2 Gerrit-Owner: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Aaron Durbin adurbin@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Ron Minnich rminnich@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Tue, 02 Jun 2020 22:45:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

7 Jun 7 Jun

3:51 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41981 )

Change subject: drivers/mrc_cache: generate debug messages for MRC cache update ......................................................................

drivers/mrc_cache: generate debug messages for MRC cache update

When MRC cached data update is performed, messages are written to event log, which is flash based. For system that does not have flash based event log, the messages are lost.

Added corresponding BIOS_DEBUG messages.

Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: I1ef4794151fea7213c8317ddc898b0e37da280b5 Reviewed-on: https://review.coreboot.org/c/coreboot/+/41981 Reviewed-by: Duncan Laurie dlaurie@chromium.org Reviewed-by: Michael Niewöhner Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/mrc_cache/mrc_cache.c 1 file changed, 6 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Michael Niewöhner: Looks good to me, but someone else must approve

diff --git a/src/drivers/mrc_cache/mrc_cache.c b/src/drivers/mrc_cache/mrc_cache.c index 4e6e91c..3a005db 100644 --- a/src/drivers/mrc_cache/mrc_cache.c +++ b/src/drivers/mrc_cache/mrc_cache.c @@ -397,6 +397,7 @@ return;

if (region_file_update_data(&cache_file, cbmem_entry_start(to_be_updated), - cbmem_entry_size(to_be_updated)) < 0) + cbmem_entry_size(to_be_updated)) < 0) { + printk(BIOS_DEBUG, "MRC: failed to update '%s'.\n", cr->name); log_event_cache_update(cr->elog_slot, UPDATE_FAILURE); - else + } else { + printk(BIOS_DEBUG, "MRC: updated '%s'.\n", cr->name); log_event_cache_update(cr->elog_slot, UPDATE_SUCCESS); + } }

/* Read flash status register to determine if write protect is active */

-- To view, visit https://review.coreboot.org/c/coreboot/+/41981 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ef4794151fea7213c8317ddc898b0e37da280b5 Gerrit-Change-Number: 41981 Gerrit-PatchSet: 3 Gerrit-Owner: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Ron Minnich rminnich@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

9elements QA (Code Review)

8 Jun 8 Jun

4:54 a.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41981 )

Change subject: drivers/mrc_cache: generate debug messages for MRC cache update ......................................................................

Patch Set 3:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/5245 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5244 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5243 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/5242

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/41981 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ef4794151fea7213c8317ddc898b0e37da280b5 Gerrit-Change-Number: 41981 Gerrit-PatchSet: 3 Gerrit-Owner: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Ron Minnich rminnich@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-Comment-Date: Mon, 08 Jun 2020 10:54:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1801

days inactive

1808

days old

coreboot-gerrit@coreboot.org

9 comments

7 participants

tags (0)

participants (7)

9elements QA (Code Review)
build bot (Jenkins) (Code Review)
Duncan Laurie (Code Review)
Jonathan Zhang (Code Review)
Michael Niewöhner (Code Review)
Patrick Georgi (Code Review)
Patrick Rudolph (Code Review)