Change in coreboot[master]: [WIP] mb/google/volteer: Update flashmap descriptor to add RW_UCODE_S...

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Jamie Ryu (Code Review)

21 Oct 2020 21 Oct '20

9:36 a.m.

Jamie Ryu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46622 )

Change subject: [WIP] mb/google/volteer: Update flashmap descriptor to add RW_UCODE_STAGED ......................................................................

[WIP] mb/google/volteer: Update flashmap descriptor to add RW_UCODE_STAGED

This adds RW_UCODE_STAGED to flashmap descriptor to enable microcode update.

BUG=b:149547271 TEST=Build and boot volteer2 to OS

Signed-off-by: Jamie Ryu jamie.m.ryu@intel.com Change-Id: I0af7469cc2767cdf5933e65f81686f9edbfa830d --- M src/mainboard/google/volteer/chromeos.fmd 1 file changed, 8 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/46622/1

diff --git a/src/mainboard/google/volteer/chromeos.fmd b/src/mainboard/google/volteer/chromeos.fmd index 07a5464..dc0aa9d 100644 --- a/src/mainboard/google/volteer/chromeos.fmd +++ b/src/mainboard/google/volteer/chromeos.fmd @@ -8,17 +8,17 @@ # of BIOS regions start at 16MiB boundary. Since this is a 32MiB # SPI flash only the top 16MiB actually gets memory mapped. RW_LEGACY(CBFS)@0x0 0xb00000 - RW_SECTION_A@0xb00000 0x5e0000 { + RW_SECTION_A@0xb00000 0x5c0000 { VBLOCK_A@0x0 0x10000 - FW_MAIN_A(CBFS)@0x10000 0x5cffc0 - RW_FWID_A@0x5dffc0 0x40 + FW_MAIN_A(CBFS)@0x10000 0x5affc0 + RW_FWID_A@0x5bffc0 0x40 } - RW_SECTION_B@0x10e0000 0x5e0000 { + RW_SECTION_B@0x10c0000 0x5c0000 { VBLOCK_B@0x0 0x10000 - FW_MAIN_B(CBFS)@0x10000 0x5cffc0 - RW_FWID_B@0x5dffc0 0x40 + FW_MAIN_B(CBFS)@0x10000 0x5affc0 + RW_FWID_B@0x5bffc0 0x40 } - RW_MISC@0x16c0000 0x40000 { + RW_MISC@0x1680000 0x80000 { UNIFIED_MRC_CACHE(PRESERVE)@0x0 0x30000 { RECOVERY_MRC_CACHE@0x0 0x10000 RW_MRC_CACHE@0x10000 0x20000 @@ -30,6 +30,7 @@ } RW_VPD(PRESERVE)@0x38000 0x2000 RW_NVRAM(PRESERVE)@0x3a000 0x6000 + RW_UCODE_STAGED@0x40000 0x40000 } # Make WP_RO region align with SPI vendor # memory protected range specification.

Attachments:

attachment.htm (text/html — 4.2 KB)

Show replies by date

Jamie Ryu (Code Review)

22 Oct 22 Oct

2:59 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46622

to look at the new patch set (#3).

Change subject: [WIP] mb/google/volteer: Update flashmap descriptor to add RW_UCODE_STAGED ......................................................................

[WIP] mb/google/volteer: Update flashmap descriptor to add RW_UCODE_STAGED

This adds RW_UCODE_STAGED to flashmap descriptor to enable microcode update.

BUG=b:149547271 TEST=Build and boot volteer2 to OS

Signed-off-by: Jamie Ryu jamie.m.ryu@intel.com Change-Id: I0af7469cc2767cdf5933e65f81686f9edbfa830d --- M src/mainboard/google/volteer/chromeos.fmd 1 file changed, 8 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/46622/3

Jamie Ryu (Code Review)

28 Oct 28 Oct

6:47 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: Update flashmap descriptor to add RW_UCODE_STAGED

Hello build bot (Jenkins), Rizwan Qureshi, Sridhar Siricilla, Raj Astekar,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46622

to look at the new patch set (#5).

Change subject: mb/google/volteer: Update flashmap descriptor to add RW_UCODE_STAGED ......................................................................

mb/google/volteer: Update flashmap descriptor to add RW_UCODE_STAGED

This adds RW_UCODE_STAGED to flashmap descriptor to enable microcode in-field update.

BUG=b:149547271 TEST=Build and boot volteer2 to OS

Signed-off-by: Jamie Ryu jamie.m.ryu@intel.com Change-Id: I0af7469cc2767cdf5933e65f81686f9edbfa830d --- M src/mainboard/google/volteer/chromeos.fmd 1 file changed, 8 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/46622/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/46622 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0af7469cc2767cdf5933e65f81686f9edbfa830d Gerrit-Change-Number: 46622 Gerrit-PatchSet: 5 Gerrit-Owner: Jamie Ryu jamie.m.ryu@intel.com Gerrit-Reviewer: Raj Astekar raj.astekar@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Sridhar Siricilla sridhar.siricilla@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Jamie Ryu (Code Review)

25 Nov 25 Nov

10:42 a.m.

New subject: Change in coreboot[master]: mb/google/volteer: Update flashmap descriptor to add RW_UCODE_STAGED

Hello build bot (Jenkins), Rizwan Qureshi, Sridhar Siricilla, Raj Astekar,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46622

to look at the new patch set (#6).

Change subject: mb/google/volteer: Update flashmap descriptor to add RW_UCODE_STAGED ......................................................................

mb/google/volteer: Update flashmap descriptor to add RW_UCODE_STAGED

This adds RW_UCODE_STAGED to flashmap descriptor to enable microcode in-field update.

BUG=b:149547271 TEST=Build and boot volteer2 to OS

Signed-off-by: Jamie Ryu jamie.m.ryu@intel.com Change-Id: I0af7469cc2767cdf5933e65f81686f9edbfa830d --- M src/mainboard/google/volteer/chromeos.fmd 1 file changed, 5 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/46622/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/46622 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0af7469cc2767cdf5933e65f81686f9edbfa830d Gerrit-Change-Number: 46622 Gerrit-PatchSet: 6 Gerrit-Owner: Jamie Ryu jamie.m.ryu@intel.com Gerrit-Reviewer: Raj Astekar raj.astekar@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Sridhar Siricilla sridhar.siricilla@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Arthur Heymans (Code Review)

12:46 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: Update flashmap descriptor to add RW_UCODE_STAGED

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46622 )

Change subject: mb/google/volteer: Update flashmap descriptor to add RW_UCODE_STAGED ......................................................................

Patch Set 7: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/46622 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0af7469cc2767cdf5933e65f81686f9edbfa830d Gerrit-Change-Number: 46622 Gerrit-PatchSet: 7 Gerrit-Owner: Jamie Ryu jamie.m.ryu@intel.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Raj Astekar raj.astekar@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Sridhar Siricilla sridhar.siricilla@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 25 Nov 2020 12:46:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Jamie Ryu (Code Review)

17 Mar 17 Mar

8:41 a.m.

New subject: Change in coreboot[master]: mb/google/volteer: Update flashmap descriptor to add RW_UCODE_STAGED

Hello build bot (Jenkins), Rizwan Qureshi, Sridhar Siricilla, Arthur Heymans, Raj Astekar,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46622

to look at the new patch set (#8).

Change subject: mb/google/volteer: Update flashmap descriptor to add RW_UCODE_STAGED ......................................................................

mb/google/volteer: Update flashmap descriptor to add RW_UCODE_STAGED

This adds RW_UCODE_STAGED to flashmap descriptor to enable microcode in-field update.

BUG=b:149547271 TEST=Build and boot volteer2 to OS

Signed-off-by: Jamie Ryu jamie.m.ryu@intel.com Change-Id: I0af7469cc2767cdf5933e65f81686f9edbfa830d --- M src/mainboard/google/volteer/chromeos.fmd 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/46622/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/46622 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0af7469cc2767cdf5933e65f81686f9edbfa830d Gerrit-Change-Number: 46622 Gerrit-PatchSet: 8 Gerrit-Owner: Jamie Ryu jamie.m.ryu@intel.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Raj Astekar raj.astekar@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Sridhar Siricilla sridhar.siricilla@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Jamie Ryu (Code Review)

9 Apr 9 Apr

5:08 a.m.

New subject: Change in coreboot[master]: mb/google/volteer: Update flashmap descriptor to add RW_UCODE_STAGED

Attention is currently required from: Jamie Ryu. Hello build bot (Jenkins), Rizwan Qureshi, Sridhar Siricilla, Arthur Heymans, Raj Astekar,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46622

to look at the new patch set (#10).

Change subject: mb/google/volteer: Update flashmap descriptor to add RW_UCODE_STAGED ......................................................................

mb/google/volteer: Update flashmap descriptor to add RW_UCODE_STAGED

This adds RW_UCODE_STAGED to flashmap descriptor to enable microcode in-field update. RW_UCODE_STAGED needs to reside within 16MB boundary to work with the multi-fit configuration and is added at 64KB aligned start address to speed up R/W operation.

BUG=b:149547271 TEST=Build and boot volteer2 to OS. MCU update is tested with the top swap enabled.

Signed-off-by: Jamie Ryu jamie.m.ryu@intel.com Change-Id: I0af7469cc2767cdf5933e65f81686f9edbfa830d --- M src/mainboard/google/volteer/chromeos.fmd 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/46622/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/46622 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0af7469cc2767cdf5933e65f81686f9edbfa830d Gerrit-Change-Number: 46622 Gerrit-PatchSet: 10 Gerrit-Owner: Jamie Ryu jamie.m.ryu@intel.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Raj Astekar raj.astekar@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Sridhar Siricilla sridhar.siricilla@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Jamie Ryu jamie.m.ryu@intel.com Gerrit-MessageType: newpatchset

Jamie Ryu (Code Review)

5:10 a.m.

New subject: Change in coreboot[master]: mb/google/volteer: Update flashmap descriptor to add RW_UCODE_STAGED

Attention is currently required from: Jamie Ryu. Hello build bot (Jenkins), Rizwan Qureshi, Sridhar Siricilla, Arthur Heymans, Raj Astekar,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46622

to look at the new patch set (#11).

Change subject: mb/google/volteer: Update flashmap descriptor to add RW_UCODE_STAGED ......................................................................

mb/google/volteer: Update flashmap descriptor to add RW_UCODE_STAGED

BUG=b:149547271 TEST=Build and boot volteer2 to OS. MCU update is tested with the top swap enabled.

Signed-off-by: Jamie Ryu jamie.m.ryu@intel.com Change-Id: I0af7469cc2767cdf5933e65f81686f9edbfa830d --- M src/mainboard/google/volteer/chromeos.fmd 1 file changed, 3 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/46622/11

-- To view, visit https://review.coreboot.org/c/coreboot/+/46622 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0af7469cc2767cdf5933e65f81686f9edbfa830d Gerrit-Change-Number: 46622 Gerrit-PatchSet: 11 Gerrit-Owner: Jamie Ryu jamie.m.ryu@intel.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Raj Astekar raj.astekar@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Sridhar Siricilla sridhar.siricilla@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Jamie Ryu jamie.m.ryu@intel.com Gerrit-MessageType: newpatchset

1330

days inactive

1500

days old

coreboot-gerrit@coreboot.org

7 comments

2 participants

tags (0)

participants (2)

Arthur Heymans (Code Review)
Jamie Ryu (Code Review)