Felix Held has posted comments on this change. ( https://review.coreboot.org/20813 )
Change subject: intel/sandybridge: Gather MMCONF_BASE_ADDRESS defaults ......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://review.coreboot.org/#/c/20813/2/src/northbridge/intel/sandybridge/Kc... File src/northbridge/intel/sandybridge/Kconfig:
https://review.coreboot.org/#/c/20813/2/src/northbridge/intel/sandybridge/Kc... PS2, Line 120: default 0xf8000000 if USE_NATIVE_RAMINIT this is inside the "if !USE_NATIVE_RAMINIT" block, so if I understand this right, this statement will never be used and MMCONF_BASE_ADDRESS will evaluate to 0. also why don't we also use 0xf0000000 in the native raminit path?
-
Felix Held (Code Review)