Felix Held posted comments on this change.

View Change

Patch set 2:Code-Review -1

(1 comment)

• File src/northbridge/intel/sandybridge/Kconfig:

  • Patch Set #2, Line 120: default 0xf8000000 if USE_NATIVE_RAMINIT

    this is inside the "if !USE_NATIVE_RAMINIT" block, so if I understand this right, this statement will never be used and MMCONF_BASE_ADDRESS will evaluate to 0.
    also why don't we also use 0xf0000000 in the native raminit path?

To view, visit change 20813. To unsubscribe, visit settings.