Victor Ding has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40900 )
Change subject: Fix incorrect diag message in clear_pending_events() ......................................................................
Fix incorrect diag message in clear_pending_events()
The expected error code should be EC_RES_UNAVAILABLE(9), not EC_RES_INVALID_COMMAND(1).
Change-Id: I609490ceef675267760d34b5e9775211da93347c Signed-off-by: Victor Ding victording@google.com --- M src/ec/google/chromeec/smihandler.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/40900/1
diff --git a/src/ec/google/chromeec/smihandler.c b/src/ec/google/chromeec/smihandler.c index febb457..5e192a5 100644 --- a/src/ec/google/chromeec/smihandler.c +++ b/src/ec/google/chromeec/smihandler.c @@ -41,7 +41,7 @@ while (google_chromeec_get_event() != 0) ;
- printk(BIOS_DEBUG,"Clearing pending EC events. Error code 1 is expected.\n"); + printk(BIOS_DEBUG, "Clearing pending EC events. Error code EC_RES_UNAVAILABLE(9) is expected.\n"); while (google_chromeec_get_mkbp_event(&mkbp_event) == 0) ; }
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40900
to look at the new patch set (#2).
Change subject: google/chromeec: Fix incorrect diag message ......................................................................
google/chromeec: Fix incorrect diag message
The expected error code observed in clear_pending_events() should be EC_RES_UNAVAILABLE(9), not EC_RES_INVALID_COMMAND(1).
Change-Id: I609490ceef675267760d34b5e9775211da93347c Signed-off-by: Victor Ding victording@google.com --- M src/ec/google/chromeec/smihandler.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/40900/2
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40900 )
Change subject: google/chromeec: Fix incorrect diag message ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40900/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40900/2//COMMIT_MSG@7 PS2, Line 7: google ec/google/chromeec
typically we expand most of the path for clarity and to match filesystem.
https://review.coreboot.org/c/coreboot/+/40900/2//COMMIT_MSG@11 PS2, Line 11: BUG=b:153896701
Hello build bot (Jenkins), Furquan Shaikh, Duncan Laurie,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40900
to look at the new patch set (#3).
Change subject: ec/google/chromeec: Fix incorrect diag message ......................................................................
ec/google/chromeec: Fix incorrect diag message
The expected error code observed in clear_pending_events() should be EC_RES_UNAVAILABLE(9), not EC_RES_INVALID_COMMAND(1).
BUG=b:153896701
Change-Id: I609490ceef675267760d34b5e9775211da93347c Signed-off-by: Victor Ding victording@google.com --- M src/ec/google/chromeec/smihandler.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/40900/3
Victor Ding has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40900 )
Change subject: ec/google/chromeec: Fix incorrect diag message ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40900/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40900/2//COMMIT_MSG@7 PS2, Line 7: google
ec/google/chromeec […]
Done
https://review.coreboot.org/c/coreboot/+/40900/2//COMMIT_MSG@11 PS2, Line 11:
BUG=b:153896701
Done
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40900 )
Change subject: ec/google/chromeec: Fix incorrect diag message ......................................................................
Patch Set 3: Code-Review+1
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40900 )
Change subject: ec/google/chromeec: Fix incorrect diag message ......................................................................
Patch Set 3: Code-Review+2
I guess the style guide does note that splitting printk for line length isn't required.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40900 )
Change subject: ec/google/chromeec: Fix incorrect diag message ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40900 )
Change subject: ec/google/chromeec: Fix incorrect diag message ......................................................................
ec/google/chromeec: Fix incorrect diag message
The expected error code observed in clear_pending_events() should be EC_RES_UNAVAILABLE(9), not EC_RES_INVALID_COMMAND(1).
BUG=b:153896701
Change-Id: I609490ceef675267760d34b5e9775211da93347c Signed-off-by: Victor Ding victording@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40900 Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Duncan Laurie dlaurie@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/ec/google/chromeec/smihandler.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Aaron Durbin: Looks good to me, but someone else must approve Furquan Shaikh: Looks good to me, approved
diff --git a/src/ec/google/chromeec/smihandler.c b/src/ec/google/chromeec/smihandler.c index febb457..5e192a5 100644 --- a/src/ec/google/chromeec/smihandler.c +++ b/src/ec/google/chromeec/smihandler.c @@ -41,7 +41,7 @@ while (google_chromeec_get_event() != 0) ;
- printk(BIOS_DEBUG,"Clearing pending EC events. Error code 1 is expected.\n"); + printk(BIOS_DEBUG, "Clearing pending EC events. Error code EC_RES_UNAVAILABLE(9) is expected.\n"); while (google_chromeec_get_mkbp_event(&mkbp_event) == 0) ; }
-
Aaron Durbin (Code Review) -
Duncan Laurie (Code Review)
-
Furquan Shaikh (Code Review)
-
Patrick Georgi (Code Review)
-
Victor Ding (Code Review)