EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40831 )
Change subject: mb/google/deltaur: Add BT reset gpio ......................................................................
mb/google/deltaur: Add BT reset gpio
Harrison Peak (HrP) 9560 module need a reset pin for BT power sequence.
BUG=b:155248677 TEST=Boot into OS and check BT is functional.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I55ed1b095ba53c414c44088f4a6e7720b970e2f2 --- M src/mainboard/google/deltaur/variants/baseboard/devicetree.cb M src/mainboard/google/deltaur/variants/baseboard/gpio.c 2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/40831/1
diff --git a/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb b/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb index 498266e..2aee78f 100644 --- a/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb @@ -229,6 +229,7 @@ chip drivers/usb/acpi register "desc" = ""M.2 2230 (BT)"" register "type" = "UPC_TYPE_INTERNAL" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A13)" device usb 2.9 on end end chip drivers/usb/acpi diff --git a/src/mainboard/google/deltaur/variants/baseboard/gpio.c b/src/mainboard/google/deltaur/variants/baseboard/gpio.c index a96e702..62b6559e 100644 --- a/src/mainboard/google/deltaur/variants/baseboard/gpio.c +++ b/src/mainboard/google/deltaur/variants/baseboard/gpio.c @@ -32,7 +32,7 @@ /* A12 : GPP_A12 ==> M2280_PCIE_SATA# */ PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1), /* A13 : GPP_A13 ==> PCH_BT_RADIO_DIS# */ - PAD_CFG_GPO(GPP_A13, 0, DEEP), + PAD_CFG_GPO(GPP_A13, 1, DEEP), /* A14 : GPP_A14 ==> USB_OC1# */ PAD_CFG_NF(GPP_A14, NONE, DEEP, NF1), /* A15 : GPP_A15 ==> USB_OC2# */
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40831 )
Change subject: mb/google/deltaur: Add BT reset gpio ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40831 )
Change subject: mb/google/deltaur: Add BT reset gpio ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40831/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40831/1//COMMIT_MSG@9 PS1, Line 9: need needs
Hello build bot (Jenkins), Paul Menzel, Tim Wawrzynczak, Bora Guvendik, Selma Bensaid,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40831
to look at the new patch set (#2).
Change subject: mb/google/deltaur: Add BT reset gpio ......................................................................
mb/google/deltaur: Add BT reset gpio
Harrison Peak (HrP) 9560 module needs a reset pin for BT power sequence.
BUG=b:155248677 TEST=Boot into OS and check BT is functional.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I55ed1b095ba53c414c44088f4a6e7720b970e2f2 --- M src/mainboard/google/deltaur/variants/baseboard/devicetree.cb M src/mainboard/google/deltaur/variants/baseboard/gpio.c 2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/40831/2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40831 )
Change subject: mb/google/deltaur: Add BT reset gpio ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40831/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40831/1//COMMIT_MSG@9 PS1, Line 9: need
needs
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40831 )
Change subject: mb/google/deltaur: Add BT reset gpio ......................................................................
mb/google/deltaur: Add BT reset gpio
Harrison Peak (HrP) 9560 module needs a reset pin for BT power sequence.
BUG=b:155248677 TEST=Boot into OS and check BT is functional.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I55ed1b095ba53c414c44088f4a6e7720b970e2f2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/40831 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/mainboard/google/deltaur/variants/baseboard/devicetree.cb M src/mainboard/google/deltaur/variants/baseboard/gpio.c 2 files changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb b/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb index e31c89b..028b022 100644 --- a/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb @@ -231,6 +231,7 @@ chip drivers/usb/acpi register "desc" = ""M.2 2230 (BT)"" register "type" = "UPC_TYPE_INTERNAL" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A13)" device usb 2.9 on end end chip drivers/usb/acpi diff --git a/src/mainboard/google/deltaur/variants/baseboard/gpio.c b/src/mainboard/google/deltaur/variants/baseboard/gpio.c index a96e702..62b6559e 100644 --- a/src/mainboard/google/deltaur/variants/baseboard/gpio.c +++ b/src/mainboard/google/deltaur/variants/baseboard/gpio.c @@ -32,7 +32,7 @@ /* A12 : GPP_A12 ==> M2280_PCIE_SATA# */ PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1), /* A13 : GPP_A13 ==> PCH_BT_RADIO_DIS# */ - PAD_CFG_GPO(GPP_A13, 0, DEEP), + PAD_CFG_GPO(GPP_A13, 1, DEEP), /* A14 : GPP_A14 ==> USB_OC1# */ PAD_CFG_NF(GPP_A14, NONE, DEEP, NF1), /* A15 : GPP_A15 ==> USB_OC2# */
-
EricR Lai (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Tim Wawrzynczak (Code Review)