Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41027 )
Change subject: soc/intel/jasperlake: Allow SD card power enable polarity configuration ......................................................................
Patch Set 7:
(5 comments)
https://review.coreboot.org/c/coreboot/+/41027/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41027/5//COMMIT_MSG@7 PS5, Line 7: Allow SdCardPowerEnableActiveHigh to be filled from devicetree
Allow SD card power enable polarity configuration?
Done
https://review.coreboot.org/c/coreboot/+/41027/5//COMMIT_MSG@9 PS5, Line 9: SdCardPowerEnable ActiveHigh
SdCardPowerEnableActiveHigh
Done
https://review.coreboot.org/c/coreboot/+/41027/5//COMMIT_MSG@9 PS5, Line 9: SdCardPowerEnable ActiveHigh is a UPD which controls polarity of SD card power enable
Can we limit line <72 characters?
Done
https://review.coreboot.org/c/coreboot/+/41027/5//COMMIT_MSG@11 PS5, Line 11: requirement
requirement.
Done
https://review.coreboot.org/c/coreboot/+/41027/5//COMMIT_MSG@16 PS5, Line 16: Signe
New line.
Done