Change in coreboot[master]: soc/intel/jasperlake: Allow SD card power enable polarity configuration
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41027 ) Change subject: soc/intel/jasperlake: Allow SD card power enable polarity configuration ...................................................................... Patch Set 7: (5 comments) https://review.coreboot.org/c/coreboot/+/41027/5//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/41027/5//COMMIT_MSG@7 PS5, Line 7: Allow SdCardPowerEnableActiveHigh to be filled from devicetree
Allow SD card power enable polarity configuration? Done
https://review.coreboot.org/c/coreboot/+/41027/5//COMMIT_MSG@9 PS5, Line 9: SdCardPowerEnable ActiveHigh
SdCardPowerEnableActiveHigh Done
https://review.coreboot.org/c/coreboot/+/41027/5//COMMIT_MSG@9 PS5, Line 9: SdCardPowerEnable ActiveHigh is a UPD which controls polarity of SD card power enable
Can we limit line <72 characters? Done
https://review.coreboot.org/c/coreboot/+/41027/5//COMMIT_MSG@11 PS5, Line 11: requirement
requirement. Done
https://review.coreboot.org/c/coreboot/+/41027/5//COMMIT_MSG@16 PS5, Line 16: Signe
New line. Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/41027 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id777a262651689952a217875e6606f67855fc2f4 Gerrit-Change-Number: 41027 Gerrit-PatchSet: 7 Gerrit-Owner: Ronak Kanabar <ronak.kanabar@intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela@intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Mon, 04 May 2020 14:58:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Aamir Bohra <aamir.bohra@intel.com> Gerrit-MessageType: comment
participants (1)
-
Ronak Kanabar (Code Review)