John Su has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32099
Change subject: mb/google/hatch: Change GPIO_E1 setting for EVT ......................................................................
mb/google/hatch: Change GPIO_E1 setting for EVT
For HW require to change GPIO_E1. Change GOIO_E1 setting from NF2(SATAPCIE1) to NF1(SATAGP1).
BUG=b:123730924 TEST=flash BIOS and make sure hatch boots up properly
Change-Id: I0f5569e13b17a2dc713be5031a63436e8f31f911 Signed-off-by: John Su john_su@compal.corp-partner.google.com --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/32099/1
diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index 68bbaab..dbe4048 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -232,8 +232,8 @@
/* E0 : GPP_E0 ==> NC */ PAD_NC(GPP_E0, NONE), - /* E1 : SATAGP1 */ - PAD_CFG_NF(GPP_E1, NONE, DEEP, NF2), + /* E1 : SATAPCIE1 */ + PAD_CFG_NF(GPP_E1, NONE, DEEP, NF1), /* E2 : GPP_E2 ==> NC */ PAD_NC(GPP_E2, NONE), /* E3 : GPP_E3 ==> NC */
Hello Paul Menzel, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32099
to look at the new patch set (#2).
Change subject: mb/google/hatch: Change GPIO_E1 setting for EVT ......................................................................
mb/google/hatch: Change GPIO_E1 setting for EVT
For HW require to change GPIO_E1. Change GOIO_E1 setting from NF2(SATAGP1) to NF1(SATAPCIE1).
BUG=b:123730924 TEST=flash BIOS and make sure hatch boots up properly
Change-Id: I0f5569e13b17a2dc713be5031a63436e8f31f911 Signed-off-by: John Su john_su@compal.corp-partner.google.com --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/32099/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32099 )
Change subject: mb/google/hatch: Change GPIO_E1 setting for EVT ......................................................................
Patch Set 2: Code-Review+2
Hello Paul Menzel, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32099
to look at the new patch set (#3).
Change subject: mb/google/hatch: Change GPIO_E1 setting ......................................................................
mb/google/hatch: Change GPIO_E1 setting
For HW require to change GPIO_E1. Change GOIO_E1 setting from NF2(SATAGP1) to NF1(SATAPCIE1).
BUG=b:123730924 TEST=flash BIOS and make sure hatch boots up properly
Change-Id: I0f5569e13b17a2dc713be5031a63436e8f31f911 Signed-off-by: John Su john_su@compal.corp-partner.google.com --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/32099/3
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32099 )
Change subject: mb/google/hatch: Change GPIO_E1 setting ......................................................................
mb/google/hatch: Change GPIO_E1 setting
For HW require to change GPIO_E1. Change GOIO_E1 setting from NF2(SATAGP1) to NF1(SATAPCIE1).
BUG=b:123730924 TEST=flash BIOS and make sure hatch boots up properly
Change-Id: I0f5569e13b17a2dc713be5031a63436e8f31f911 Signed-off-by: John Su john_su@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32099 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index 8529d5916..4d1c87e 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -232,8 +232,8 @@
/* E0 : GPP_E0 ==> NC */ PAD_NC(GPP_E0, NONE), - /* E1 : SATAGP1 */ - PAD_CFG_NF(GPP_E1, NONE, DEEP, NF2), + /* E1 : SATAPCIE1 */ + PAD_CFG_NF(GPP_E1, NONE, DEEP, NF1), /* E2 : GPP_E2 ==> NC */ PAD_NC(GPP_E2, NONE), /* E3 : GPP_E3 ==> NC */
-
Furquan Shaikh (Code Review) -
John Su (Code Review)
-
Patrick Georgi (Code Review)