Change in ...coreboot[master]: mb/google/poppy/variants/nami: update sku_ids for Pantheon

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Frank Wu (Code Review)

28 Mar 2019 28 Mar '19

6:38 a.m.

Frank Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32098

Change subject: mb/google/poppy/variants/nami: update sku_ids for Pantheon ......................................................................

mb/google/poppy/variants/nami: update sku_ids for Pantheon

The sku ids are updated for Pantheon. Sync'ing the sku_ids list in the master sku sheet for Pantheon.

BUG=b:121207221 BRANCH=firmware-nami-10775.B TEST=emerge-nami coreboot chromeos-bootimage

Change-Id: Ibf683ca8219b2980ea9d9c40b06db264d58440b0 Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com --- M src/mainboard/google/poppy/variants/nami/include/variant/sku.h 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/32098/1

diff --git a/src/mainboard/google/poppy/variants/nami/include/variant/sku.h b/src/mainboard/google/poppy/variants/nami/include/variant/sku.h index 835864e..70f2008 100644 --- a/src/mainboard/google/poppy/variants/nami/include/variant/sku.h +++ b/src/mainboard/google/poppy/variants/nami/include/variant/sku.h @@ -24,8 +24,8 @@ #define SKU_0_PANTHEON 0x3F63 #define SKU_1_PANTHEON 0x3F67 #define SKU_2_PANTHEON 0x3F62 -#define SKU_3_PANTHEON 0xBF63 -#define SKU_4_PANTHEON 0xBF62 +#define SKU_3_PANTHEON 0x8000BF63 +#define SKU_4_PANTHEON 0x8000BF62 #define SKU_0_SONA 0x3AE2 #define SKU_1_SONA 0x3AE3 #define SKU_0_AKALI 0x29E1

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

Daisuke Nojiri (Code Review)

28 Mar 28 Mar

5:44 p.m.

Daisuke Nojiri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32098 )

Change subject: mb/google/poppy/variants/nami: update sku_ids for Pantheon ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32098 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf683ca8219b2980ea9d9c40b06db264d58440b0 Gerrit-Change-Number: 32098 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Daisuke Nojiri dnojiri@chromium.org Gerrit-Reviewer: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 28 Mar 2019 16:44:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Frank Wu (Code Review)

29 Mar 29 Mar

6:37 a.m.

Hello Daisuke Nojiri, Shelley Chen, build bot (Jenkins), Patrick Georgi, Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32098

to look at the new patch set (#2).

Change subject: mb/google/poppy/variants/nami: update sku_ids for Pantheon ......................................................................

mb/google/poppy/variants/nami: update sku_ids for Pantheon

The sku ids are updated for Pantheon. Sync'ing the sku_ids list in the master sku sheet for Pantheon.

BUG=b:121207221 BRANCH=firmware-nami-10775.B TEST=emerge-nami coreboot chromeos-bootimage

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/32098/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32098 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf683ca8219b2980ea9d9c40b06db264d58440b0 Gerrit-Change-Number: 32098 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Daisuke Nojiri dnojiri@chromium.org Gerrit-Reviewer: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Frank Wu (Code Review)

1 Apr 1 Apr

7:58 a.m.

Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32098 )

Change subject: mb/google/poppy/variants/nami: update sku_ids for Pantheon ......................................................................

Patch Set 2:

Hi all,

Would you help review the CL? Thank you.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32098 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf683ca8219b2980ea9d9c40b06db264d58440b0 Gerrit-Change-Number: 32098 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Daisuke Nojiri dnojiri@chromium.org Gerrit-Reviewer: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 01 Apr 2019 05:58:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

8:23 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32098 )

Change subject: mb/google/poppy/variants/nami: update sku_ids for Pantheon ......................................................................

Patch Set 2: Code-Review+1

I haven't followed the SKU ID changes for Pantheon. I will let Shelley or Daisuke +2 this.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32098 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf683ca8219b2980ea9d9c40b06db264d58440b0 Gerrit-Change-Number: 32098 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Daisuke Nojiri dnojiri@chromium.org Gerrit-Reviewer: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 01 Apr 2019 06:23:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Daisuke Nojiri (Code Review)

2 Apr 2 Apr

2:47 a.m.

Daisuke Nojiri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32098 )

Change subject: mb/google/poppy/variants/nami: update sku_ids for Pantheon ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32098 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf683ca8219b2980ea9d9c40b06db264d58440b0 Gerrit-Change-Number: 32098 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Daisuke Nojiri dnojiri@chromium.org Gerrit-Reviewer: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 02 Apr 2019 00:47:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

12:25 p.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32098 )

Change subject: mb/google/poppy/variants/nami: update sku_ids for Pantheon ......................................................................

mb/google/poppy/variants/nami: update sku_ids for Pantheon

The sku ids are updated for Pantheon. Sync'ing the sku_ids list in the master sku sheet for Pantheon.

BUG=b:121207221 BRANCH=firmware-nami-10775.B TEST=emerge-nami coreboot chromeos-bootimage

Change-Id: Ibf683ca8219b2980ea9d9c40b06db264d58440b0 Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32098 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Daisuke Nojiri dnojiri@chromium.org --- M src/mainboard/google/poppy/variants/nami/include/variant/sku.h 1 file changed, 2 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, but someone else must approve Daisuke Nojiri: Looks good to me, approved

diff --git a/src/mainboard/google/poppy/variants/nami/include/variant/sku.h b/src/mainboard/google/poppy/variants/nami/include/variant/sku.h index 835864e..0ec85d0 100644 --- a/src/mainboard/google/poppy/variants/nami/include/variant/sku.h +++ b/src/mainboard/google/poppy/variants/nami/include/variant/sku.h @@ -24,8 +24,8 @@ #define SKU_0_PANTHEON 0x3F63 #define SKU_1_PANTHEON 0x3F67 #define SKU_2_PANTHEON 0x3F62 -#define SKU_3_PANTHEON 0xBF63 -#define SKU_4_PANTHEON 0xBF62 +#define SKU_3_PANTHEON 0x100BF63 +#define SKU_4_PANTHEON 0x100BF62 #define SKU_0_SONA 0x3AE2 #define SKU_1_SONA 0x3AE3 #define SKU_0_AKALI 0x29E1

-- To view, visit https://review.coreboot.org/c/coreboot/+/32098 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf683ca8219b2980ea9d9c40b06db264d58440b0 Gerrit-Change-Number: 32098 Gerrit-PatchSet: 3 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Daisuke Nojiri dnojiri@chromium.org Gerrit-Reviewer: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1851

days inactive

1856

days old

coreboot-gerrit@coreboot.org

6 comments

4 participants

tags (0)

participants (4)

Daisuke Nojiri (Code Review)
Frank Wu (Code Review)
Furquan Shaikh (Code Review)
Patrick Georgi (Code Review)