Change in ...coreboot[master]: mainboard/intel/saddlebrook: Remove unused functions

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32985

Change subject: mainboard/intel/saddlebrook: Remove unused functions
......................................................................

mainboard/intel/saddlebrook: Remove unused functions

Setting up the SIO serial console is done in the bootblock.

Change-Id: Ideaf8f3dc0ee067e96d3fb5046071551c6d45329
Signed-off-by: Arthur Heymans 
---
M src/mainboard/intel/saddlebrook/romstage.c
1 file changed, 0 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/32985/1

diff --git a/src/mainboard/intel/saddlebrook/romstage.c b/src/mainboard/intel/saddlebrook/romstage.c
index 82b85fd..45f39d4 100644
--- a/src/mainboard/intel/saddlebrook/romstage.c
+++ b/src/mainboard/intel/saddlebrook/romstage.c
@@ -23,15 +23,7 @@
 #include <soc/romstage.h>
 #include "spd/spd.h"
 #include <spd_bin.h>
-#include <superio/nuvoton/common/nuvoton.h>
-#include <superio/nuvoton/nct6776/nct6776.h>

-#define SERIAL_DEV PNP_DEV(0x2e, NCT6776_SP1)
-
-void car_mainboard_pre_console_init(void)
-{
-	nuvoton_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE);
-}

void mainboard_memory_init_params(
    struct romstage_params *params,

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32985 )

Change subject: mainboard/intel/saddlebrook: Remove unused functions
......................................................................

Patch Set 1: Code-Review+2

[Christian Walter (Code Review)]

Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32985 )

Change subject: mainboard/intel/saddlebrook: Remove unused functions
......................................................................

Patch Set 3: Code-Review+1

[Arthur Heymans (Code Review)]

Arthur Heymans has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32985 )

Change subject: mainboard/intel/saddlebrook: Remove unused functions
......................................................................

mainboard/intel/saddlebrook: Remove unused functions

Setting up the SIO serial console is done in the bootblock.

Change-Id: Ideaf8f3dc0ee067e96d3fb5046071551c6d45329
Signed-off-by: Arthur Heymans 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32985
Reviewed-by: Christian Walter 
Reviewed-by: Kyösti Mälkki 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/intel/saddlebrook/romstage.c
1 file changed, 0 insertions(+), 8 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, approved
  Christian Walter: Looks good to me, but someone else must approve

diff --git a/src/mainboard/intel/saddlebrook/romstage.c b/src/mainboard/intel/saddlebrook/romstage.c
index 82b85fd..45f39d4 100644
--- a/src/mainboard/intel/saddlebrook/romstage.c
+++ b/src/mainboard/intel/saddlebrook/romstage.c
@@ -23,15 +23,7 @@
 #include <soc/romstage.h>
 #include "spd/spd.h"
 #include <spd_bin.h>
-#include <superio/nuvoton/common/nuvoton.h>
-#include <superio/nuvoton/nct6776/nct6776.h>

-#define SERIAL_DEV PNP_DEV(0x2e, NCT6776_SP1)
-
-void car_mainboard_pre_console_init(void)
-{
-	nuvoton_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE);
-}

void mainboard_memory_init_params(
    struct romstage_params *params,