Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32846 )
Change subject: soc/intel/skylake: Use PCI func0 if enabled in device tree
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32846/1/src/soc/intel/skylake/chip_fsp20.c
File src/soc/intel/skylake/chip_fsp20.c:
https://review.coreboot.org/#/c/32846/1/src/soc/intel/skylake/chip_fsp20.c@1...
PS1, Line 113: enabled
"... enabled in device tree, ..." to make it clear that is different than the disabled mentioned in L109 above?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32846
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c44ee5493eff1f9e04aa891030fde2a6f0c636f
Gerrit-Change-Number: 32846
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali
caveh@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-Comment-Date: Mon, 03 Jun 2019 18:38:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment