Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44121 )
Change subject: nb/intel/sandybridge: Refactor `get_pcie_bar` ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44121/4/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/northbridge.c:
https://review.coreboot.org/c/coreboot/+/44121/4/src/northbridge/intel/sandy... PS4, Line 50: return 0;
The other instances of `decode_pcie_bar` return 0 on failure. […]
Marking comment as resolved given the non-response
https://review.coreboot.org/c/coreboot/+/44121/4/src/northbridge/intel/sandy... PS4, Line 143: decode_pcie_bar
I agree. It shouldn't error out because we're programming MMCONF in the bootblock. […]
Marking comment as resolved given the non-response
-
Angel Pons (Code Review)