Change in coreboot[master]: [PATCH] mb/google/: Add "i2c-allow-low-power-probe" property for cameras
Daniel Kang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45160 )
Change subject: [PATCH] mb/google/: Add "i2c-allow-low-power-probe" property for cameras ......................................................................
[PATCH] mb/google/: Add "i2c-allow-low-power-probe" property for cameras
There is a patch https://lkml.org/lkml/2020/9/3/235 which allow i2c device can support driver probe without power up the device. In order to support this, need add coreboot add "i2c-allow-low-power-probe" property.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: I46f90ff8d412b18c7ee4bd7f22f9a7db771eb84f --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 28 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/45160/1
diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl index ad0b782..225c9a5 100644 --- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl +++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl @@ -247,7 +247,7 @@ } }, ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package (0x02) + Package (0x03) { Package (0x02) { @@ -261,7 +261,12 @@ { VCM0 } - } + }, + Package (0x02) + { + "i2c-allow-low-power-probe", + 0x01 + } } }) Name (PRT0, Package (0x04) @@ -413,13 +418,18 @@ Name (_DSD, Package (0x02) /* _DSD: Device-Specific Data */ { ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package (0x01) + Package (0x02) { Package (0x02) { "compatible", "dongwoon,dw9768" - } + }, + Package (0x02) + { + "i2c-allow-low-power-probe", + 0x01 + } } }) } @@ -454,7 +464,7 @@ Name (_DSD, Package (0x02) // _DSD: Device-Specific Data { ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */, - Package (0x05) + Package (0x06) { Package (0x02) { @@ -480,7 +490,12 @@ { "compatible", "atmel,24c1024" - } + }, + Package (0x02) + { + "i2c-allow-low-power-probe", + 0x01 + } } }) } @@ -577,13 +592,18 @@ } }, ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package (0x01) + Package (0x02) { Package (0x02) { "clock-frequency", 0x0124F800 - } + }, + Package (0x02) + { + "i2c-allow-low-power-probe", + 0x01 + } } }) Name (PRT0, Package (0x04)
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45160 )
Change subject: [PATCH] mb/google/: Add "i2c-allow-low-power-probe" property for cameras ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45160/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45160/1/src/mainboard/google/voltee... PS1, Line 498: } trailing whitespace
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45160 )
Change subject: [PATCH] mb/google/: Add "i2c-allow-low-power-probe" property for cameras ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45160/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45160/1//COMMIT_MSG@7 PS1, Line 7: [PATCH] Please remove this. It’s often used when sending patches to mailing lists.
https://review.coreboot.org/c/coreboot/+/45160/1//COMMIT_MSG@10 PS1, Line 10: allow allows
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45160
to look at the new patch set (#2).
Change subject: [Do not merge yet] mb/google/: Add "i2c-allow-low-power-probe" property for cameras ......................................................................
[Do not merge yet] mb/google/: Add "i2c-allow-low-power-probe" property for cameras
There is a patch https://lkml.org/lkml/2020/9/3/235 which allows i2c device can support driver probe without power up the device. In order to support this, need add coreboot add "i2c-allow-low-power-probe" property.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: I46f90ff8d412b18c7ee4bd7f22f9a7db771eb84f --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 28 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/45160/2
Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45160 )
Change subject: [Do not merge yet] mb/google/: Add "i2c-allow-low-power-probe" property for cameras ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45160/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45160/1//COMMIT_MSG@7 PS1, Line 7: [PATCH]
Please remove this. It’s often used when sending patches to mailing lists.
Sorry Paul. This patch was submitted for internal reviews. That's why I haven't added reviewers.
https://review.coreboot.org/c/coreboot/+/45160/1//COMMIT_MSG@10 PS1, Line 10: allow
allows
Done
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45160
to look at the new patch set (#3).
Change subject: mb/google/volteer: Add "i2c-allow-low-power-probe" property for cameras ......................................................................
mb/google/volteer: Add "i2c-allow-low-power-probe" property for cameras
There is a patch https://lkml.org/lkml/2020/9/3/235 which allows i2c device can support driver probe without power up the device. In order to support this, need add coreboot add "i2c-allow-low-power-probe" property.
BUG=b:169058784 BRANCH=none TEST=Build and boot volteer board. Monitor camera privacy LED and check it blinks. It should not blink.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: I46f90ff8d412b18c7ee4bd7f22f9a7db771eb84f --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 28 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/45160/3
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45160 )
Change subject: mb/google/volteer: Add "i2c-allow-low-power-probe" property for cameras ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45160/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45160/4/src/mainboard/google/voltee... PS4, Line 450: } trailing whitespace
Hello build bot (Jenkins), Patrick Georgi, Bingbu Cao, Wonkyu Kim, Caveh Jalali, Duncan Laurie, Paul Menzel, Furquan Shaikh, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45160
to look at the new patch set (#5).
Change subject: mb/google/volteer: Add "i2c-allow-low-power-probe" property for cameras ......................................................................
mb/google/volteer: Add "i2c-allow-low-power-probe" property for cameras
There is a patch https://lkml.org/lkml/2020/9/3/235 which allows i2c device can support driver probe without power up the device. In order to support this, need add coreboot add "i2c-allow-low-power-probe" property.
BUG=b:169058784 BRANCH=none TEST=Build and boot volteer board. Monitor camera privacy LED and check it blinks. It should not blink.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: I46f90ff8d412b18c7ee4bd7f22f9a7db771eb84f --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 27 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/45160/5
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45160 )
Change subject: mb/google/volteer: Add "i2c-allow-low-power-probe" property for cameras ......................................................................
Patch Set 5: Code-Review+2
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45160 )
Change subject: mb/google/volteer: Add "i2c-allow-low-power-probe" property for cameras ......................................................................
mb/google/volteer: Add "i2c-allow-low-power-probe" property for cameras
There is a patch https://lkml.org/lkml/2020/9/3/235 which allows i2c device can support driver probe without power up the device. In order to support this, need add coreboot add "i2c-allow-low-power-probe" property.
BUG=b:169058784 BRANCH=none TEST=Build and boot volteer board. Monitor camera privacy LED and check it blinks. It should not blink.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: I46f90ff8d412b18c7ee4bd7f22f9a7db771eb84f Reviewed-on: https://review.coreboot.org/c/coreboot/+/45160 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Duncan Laurie dlaurie@chromium.org --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 27 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl index dad762a..51034c3 100644 --- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl +++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl @@ -247,7 +247,7 @@ } }, ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package (0x02) + Package (0x03) { Package (0x02) { @@ -261,7 +261,12 @@ { VCM0 } - } + }, + Package (0x02) + { + "i2c-allow-low-power-probe", + 0x01 + } } }) Name (PRT0, Package (0x04) @@ -365,13 +370,18 @@ Name (_DSD, Package (0x02) /* _DSD: Device-Specific Data */ { ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package (0x01) + Package (0x02) { Package (0x02) { "compatible", "dongwoon,dw9768" - } + }, + Package (0x02) + { + "i2c-allow-low-power-probe", + 0x01 + } } }) } @@ -406,7 +416,7 @@ Name (_DSD, Package (0x02) // _DSD: Device-Specific Data { ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */, - Package (0x05) + Package (0x06) { Package (0x02) { @@ -432,6 +442,11 @@ { "compatible", "atmel,24c1024" + }, + Package (0x02) + { + "i2c-allow-low-power-probe", + 0x01 } } }) @@ -529,13 +544,18 @@ } }, ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package (0x01) + Package (0x02) { Package (0x02) { "clock-frequency", 0x0124F800 - } + }, + Package (0x02) + { + "i2c-allow-low-power-probe", + 0x01 + } } }) Name (PRT0, Package (0x04)
-
build bot (Jenkins) (Code Review) -
Daniel Kang (Code Review)
-
Duncan Laurie (Code Review)
-
Paul Menzel (Code Review)
-
Tim Wawrzynczak (Code Review)