Tim Wawrzynczak submitted this change.
mb/google/volteer: Add "i2c-allow-low-power-probe" property for
cameras
There is a patch https://lkml.org/lkml/2020/9/3/235 which allows i2c
device can support driver probe without power up the device.
In order to support this, need add coreboot add
"i2c-allow-low-power-probe" property.
BUG=b:169058784
BRANCH=none
TEST=Build and boot volteer board. Monitor camera privacy LED
and check it blinks. It should not blink.
Signed-off-by: Daniel Kang <daniel.h.kang@intel.com>
Change-Id: I46f90ff8d412b18c7ee4bd7f22f9a7db771eb84f
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45160
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
---
M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
1 file changed, 27 insertions(+), 7 deletions(-)
diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
index dad762a..51034c3 100644
--- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
+++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
@@ -247,7 +247,7 @@
}
},
ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
- Package (0x02)
+ Package (0x03)
{
Package (0x02)
{
@@ -261,7 +261,12 @@
{
VCM0
}
- }
+ },
+ Package (0x02)
+ {
+ "i2c-allow-low-power-probe",
+ 0x01
+ }
}
})
Name (PRT0, Package (0x04)
@@ -365,13 +370,18 @@
Name (_DSD, Package (0x02) /* _DSD: Device-Specific Data */
{
ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
- Package (0x01)
+ Package (0x02)
{
Package (0x02)
{
"compatible",
"dongwoon,dw9768"
- }
+ },
+ Package (0x02)
+ {
+ "i2c-allow-low-power-probe",
+ 0x01
+ }
}
})
}
@@ -406,7 +416,7 @@
Name (_DSD, Package (0x02) // _DSD: Device-Specific Data
{
ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
- Package (0x05)
+ Package (0x06)
{
Package (0x02)
{
@@ -432,6 +442,11 @@
{
"compatible",
"atmel,24c1024"
+ },
+ Package (0x02)
+ {
+ "i2c-allow-low-power-probe",
+ 0x01
}
}
})
@@ -529,13 +544,18 @@
}
},
ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
- Package (0x01)
+ Package (0x02)
{
Package (0x02)
{
"clock-frequency",
0x0124F800
- }
+ },
+ Package (0x02)
+ {
+ "i2c-allow-low-power-probe",
+ 0x01
+ }
}
})
Name (PRT0, Package (0x04)
To view, visit change 45160. To unsubscribe, or for help writing mail filters, visit settings.