hsin-hsiung wang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48110 )
Change subject: soc/mediatek/mt8192: return correct voltage of VM18 ......................................................................
soc/mediatek/mt8192: return correct voltage of VM18
The voltage of vm18 should be microvolt instead of millivolt.
BUG=b:155253454 BRANCH=none TEST=boot asurada correctly
Signed-off-by: Hsin-Hsiung Wang hsin-hsiung.wang@mediatek.com Change-Id: Iea5b46c1df358dc350506d29cc033d01631b37b0 --- M src/soc/mediatek/mt8192/mt6359p.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/48110/1
diff --git a/src/soc/mediatek/mt8192/mt6359p.c b/src/soc/mediatek/mt8192/mt6359p.c index 1646e53..0c34db3 100644 --- a/src/soc/mediatek/mt8192/mt6359p.c +++ b/src/soc/mediatek/mt8192/mt6359p.c @@ -417,7 +417,7 @@
reg_vol = 100 * mt6359p_read_field(PMIC_VM18_ANA_CON0, 0xF, VM18_VOL_REG_SHIFT); reg_cali = 10 * mt6359p_read_field(PMIC_VM18_ANA_CON0, 0xF, 0); - return 600 + reg_vol + reg_cali; + return 1000 * (600 + reg_vol + reg_cali); }
static void init_pmif_arb(void)
hsin-hsiung wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48110 )
Change subject: soc/mediatek/mt8192: return correct voltage of VM18 ......................................................................
Patch Set 1: Code-Review+1
Hello Xi Chen, build bot (Jenkins), Yidi Lin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48110
to look at the new patch set (#2).
Change subject: soc/mediatek/mt8192: return correct voltage of VM18 ......................................................................
soc/mediatek/mt8192: return correct voltage of VM18
The voltage of vm18 should be microvolt instead of millivolt.
BUG=b:155253454 BRANCH=none TEST=boot asurada correctly
Signed-off-by: Hsin-Hsiung Wang hsin-hsiung.wang@mediatek.com Change-Id: Iea5b46c1df358dc350506d29cc033d01631b37b0 --- M src/soc/mediatek/mt8192/mt6359p.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/48110/2
Yidi Lin has uploaded a new patch set (#6) to the change originally created by hsin-hsiung wang. ( https://review.coreboot.org/c/coreboot/+/48110 )
Change subject: soc/mediatek/mt8192: return correct voltage of VM18 ......................................................................
soc/mediatek/mt8192: return correct voltage of VM18
The voltage of vm18 should be microvolt instead of millivolt.
BUG=b:155253454 BRANCH=none TEST=boot asurada correctly
Signed-off-by: Hsin-Hsiung Wang hsin-hsiung.wang@mediatek.com Change-Id: Iea5b46c1df358dc350506d29cc033d01631b37b0 --- M src/soc/mediatek/mt8192/mt6359p.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/48110/6
Yidi Lin has uploaded a new patch set (#8) to the change originally created by hsin-hsiung wang. ( https://review.coreboot.org/c/coreboot/+/48110 )
Change subject: soc/mediatek/mt8192: return correct voltage of VM18 ......................................................................
soc/mediatek/mt8192: return correct voltage of VM18
The voltage of vm18 should be microvolt instead of millivolt.
BUG=b:155253454 BRANCH=none TEST=boot asurada correctly
Signed-off-by: Hsin-Hsiung Wang hsin-hsiung.wang@mediatek.com Change-Id: Iea5b46c1df358dc350506d29cc033d01631b37b0 --- M src/soc/mediatek/mt8192/mt6359p.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/48110/8
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48110 )
Change subject: soc/mediatek/mt8192: return correct voltage of VM18 ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48110/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48110/11//COMMIT_MSG@7 PS11, Line 7: return correct voltage of VM18 Correct return value of VM18 voltage
Hello Hung-Te Lin, Xi Chen, build bot (Jenkins), Yidi Lin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48110
to look at the new patch set (#12).
Change subject: soc/mediatek/mt8192: Correct return value of VM18 voltage ......................................................................
soc/mediatek/mt8192: Correct return value of VM18 voltage
The voltage of vm18 should be microvolt instead of millivolt.
BUG=b:155253454 BRANCH=none TEST=boot asurada correctly
Signed-off-by: Hsin-Hsiung Wang hsin-hsiung.wang@mediatek.com Change-Id: Iea5b46c1df358dc350506d29cc033d01631b37b0 --- M src/soc/mediatek/mt8192/mt6359p.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/48110/12
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48110 )
Change subject: soc/mediatek/mt8192: Correct return value of VM18 voltage ......................................................................
Patch Set 12: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/48110/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48110/11//COMMIT_MSG@7 PS11, Line 7: return correct voltage of VM18
Correct return value of VM18 voltage
Done
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48110 )
Change subject: soc/mediatek/mt8192: Correct return value of VM18 voltage ......................................................................
soc/mediatek/mt8192: Correct return value of VM18 voltage
The voltage of vm18 should be microvolt instead of millivolt.
BUG=b:155253454 BRANCH=none TEST=boot asurada correctly
Signed-off-by: Hsin-Hsiung Wang hsin-hsiung.wang@mediatek.com Change-Id: Iea5b46c1df358dc350506d29cc033d01631b37b0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48110 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Yu-Ping Wu yupingso@google.com --- M src/soc/mediatek/mt8192/mt6359p.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved
diff --git a/src/soc/mediatek/mt8192/mt6359p.c b/src/soc/mediatek/mt8192/mt6359p.c index 1646e53..a8e93ca 100644 --- a/src/soc/mediatek/mt8192/mt6359p.c +++ b/src/soc/mediatek/mt8192/mt6359p.c @@ -417,7 +417,7 @@
reg_vol = 100 * mt6359p_read_field(PMIC_VM18_ANA_CON0, 0xF, VM18_VOL_REG_SHIFT); reg_cali = 10 * mt6359p_read_field(PMIC_VM18_ANA_CON0, 0xF, 0); - return 600 + reg_vol + reg_cali; + return 1000 * (VM18_VOL_OFFSET + reg_vol + reg_cali); }
static void init_pmif_arb(void)
-
hsin-hsiung wang (Code Review) -
Hung-Te Lin (Code Review)
-
Yidi Lin (Code Review)
-
Yu-Ping Wu (Code Review)