Change in coreboot[master]: mb/google/dedede/var/magolor: Add Wifi SAR for magolor and maglia

[Ren Kuo (Code Review)]

Ren Kuo has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48448 )

Change subject: mb/google/dedede/var/magolor: Add Wifi SAR for magolor and maglia
......................................................................

mb/google/dedede/var/magolor: Add Wifi SAR for magolor and maglia

Add wifi sar for magolor and maglia:
Using tablet mode of fw config to decide to load custom wifi sar or not.
same wifi sar value for magolor and maglia (shared firmware)

BUG=b:173001370 b:173001251
TEST=enable CHROMEOS_WIFI_SAR in config of coreboot,
emerge-dedede coreboot-private-files-baseboard-dedede coreboot chromeos-bootimage.

Signed-off-by: Ren Kuo 
Change-Id: I44ab68c9ee5deced90d3858161571ab4b39b4c8a
---
M src/mainboard/google/dedede/Kconfig.name
A src/mainboard/google/dedede/variants/magolor/Makefile.inc
A src/mainboard/google/dedede/variants/magolor/variant.c
3 files changed, 18 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/48448/1

diff --git a/src/mainboard/google/dedede/Kconfig.name b/src/mainboard/google/dedede/Kconfig.name
index 6aeb9ed..411efdb 100644
--- a/src/mainboard/google/dedede/Kconfig.name
+++ b/src/mainboard/google/dedede/Kconfig.name
@@ -67,6 +67,7 @@
    select BASEBOARD_DEDEDE_LAPTOP
    select DRIVERS_INTEL_MIPI_CAMERA
    select SOC_INTEL_COMMON_BLOCK_IPU
+	select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR

config BOARD_GOOGLE_METAKNIGHT
    bool "-> Metaknight"
diff --git a/src/mainboard/google/dedede/variants/magolor/Makefile.inc b/src/mainboard/google/dedede/variants/magolor/Makefile.inc
new file mode 100644
index 0000000..24c75d1
--- /dev/null
+++ b/src/mainboard/google/dedede/variants/magolor/Makefile.inc
@@ -0,0 +1,3 @@
+## SPDX-License-Identifier: GPL-2.0-or-later
+
+ramstage-$(CONFIG_FW_CONFIG) += variant.c
diff --git a/src/mainboard/google/dedede/variants/magolor/variant.c b/src/mainboard/google/dedede/variants/magolor/variant.c
new file mode 100644
index 0000000..e3b9599
--- /dev/null
+++ b/src/mainboard/google/dedede/variants/magolor/variant.c
@@ -0,0 +1,14 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#include <fw_config.h>
+#include <sar.h>
+
+const char *get_wifi_sar_cbfs_filename(void)
+{
+	const char *filename = NULL;
+
+	if (fw_config_probe(FW_CONFIG(TABLETMODE, TABLETMODE_ENABLED)))
+		filename = "wifi_sar-magolor.hex";
+
+	return filename;
+}

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48448 )

Change subject: mb/google/dedede/var/magolor: Add Wifi SAR for magolor and maglia
......................................................................

Patch Set 1: Code-Review+1

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48448 )

Change subject: mb/google/dedede/var/magolor: Add Wifi SAR for magolor and maglia
......................................................................

Patch Set 1: Code-Review+2

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48448 )

Change subject: mb/google/dedede/var/magolor: Add Wifi SAR for magolor and maglia
......................................................................

Patch Set 1:

(3 comments)

https://review.coreboot.org/c/coreboot/+/48448/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/48448/1//COMMIT_MSG@13 
PS1, Line 13: BUG=b:173001370 b:173001251
Nit: b:173001370, b:173001251

https://review.coreboot.org/c/coreboot/+/48448/1//COMMIT_MSG@16 
PS1, Line 16: 
Cq-Depend: chrome-internal:3453724

https://review.coreboot.org/c/coreboot/+/48448/1/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/48448/1/src/mainboard/google/dedede... 
PS1, Line 70: 	select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR
Nit: Move above "select SOC_INTEL_COMMON_BLOCK_IPU"

[Ren Kuo (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48448

to look at the new patch set (#2).

Change subject: mb/google/dedede/var/magolor: Add Wifi SAR for magolor and maglia
......................................................................

mb/google/dedede/var/magolor: Add Wifi SAR for magolor and maglia

Add wifi sar for magolor and maglia:
Using tablet mode of fw config to decide to load custom wifi sar or not.
same wifi sar value for magolor and maglia (shared firmware)

BUG=b:173001370, b:173001251
TEST=enable CHROMEOS_WIFI_SAR in config of coreboot,
emerge-dedede coreboot-private-files-baseboard-dedede coreboot chromeos-bootimage.

Signed-off-by: Ren Kuo 
Change-Id: I44ab68c9ee5deced90d3858161571ab4b39b4c8a
---
M src/mainboard/google/dedede/Kconfig.name
A src/mainboard/google/dedede/variants/magolor/Makefile.inc
A src/mainboard/google/dedede/variants/magolor/variant.c
3 files changed, 18 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/48448/2

[Ren Kuo (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48448

to look at the new patch set (#3).

Change subject: mb/google/dedede/var/magolor: Add Wifi SAR for magolor and maglia
......................................................................

mb/google/dedede/var/magolor: Add Wifi SAR for magolor and maglia

Add wifi sar for magolor and maglia:
Using tablet mode of fw config to decide to load custom wifi sar or not.
same wifi sar value for magolor and maglia (shared firmware)

BUG=b:173001370, b:173001251
TEST=enable CHROMEOS_WIFI_SAR in config of coreboot,
emerge-dedede coreboot-private-files-baseboard-dedede coreboot chromeos-bootimage.

Cq-Depend: chrome-internal:3453724

Signed-off-by: Ren Kuo 
Change-Id: I44ab68c9ee5deced90d3858161571ab4b39b4c8a
---
M src/mainboard/google/dedede/Kconfig.name
A src/mainboard/google/dedede/variants/magolor/Makefile.inc
A src/mainboard/google/dedede/variants/magolor/variant.c
3 files changed, 18 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/48448/3

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48448 )

Change subject: mb/google/dedede/var/magolor: Add Wifi SAR for magolor and maglia
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/48448/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/48448/1//COMMIT_MSG@13 
PS1, Line 13: BUG=b:173001370 b:173001251
> Nit: b:173001370, b:173001251

done!

https://review.coreboot.org/c/coreboot/+/48448/1//COMMIT_MSG@16 
PS1, Line 16:
> Cq-Depend: chrome-internal:3453724

done!

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48448 )

Change subject: mb/google/dedede/var/magolor: Add Wifi SAR for magolor and maglia
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48448/1/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/48448/1/src/mainboard/google/dedede... 
PS1, Line 70: 	select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR
> Nit: Move above "select SOC_INTEL_COMMON_BLOCK_IPU"

done!

[Ren Kuo (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48448

to look at the new patch set (#4).

Change subject: mb/google/dedede/var/magolor: Add Wifi SAR for magolor and maglia
......................................................................

mb/google/dedede/var/magolor: Add Wifi SAR for magolor and maglia

Add wifi sar for magolor and maglia:
Using tablet mode of fw config to decide to load custom wifi sar or not.
same wifi sar value for magolor and maglia (shared firmware)

BUG=b:173001370, b:173001251
TEST=enable CHROMEOS_WIFI_SAR in config of coreboot,
emerge-dedede coreboot-private-files-baseboard-dedede coreboot chromeos-bootimage.

Cq-Depend: chrome-internal:3453724

Signed-off-by: Ren Kuo 
Change-Id: I44ab68c9ee5deced90d3858161571ab4b39b4c8a
---
M src/mainboard/google/dedede/Kconfig.name
A src/mainboard/google/dedede/variants/magolor/Makefile.inc
A src/mainboard/google/dedede/variants/magolor/variant.c
3 files changed, 18 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/48448/4

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48448 )

Change subject: mb/google/dedede/var/magolor: Add Wifi SAR for magolor and maglia
......................................................................

Patch Set 4: Code-Review+1

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48448 )

Change subject: mb/google/dedede/var/magolor: Add Wifi SAR for magolor and maglia
......................................................................

Patch Set 4: Code-Review+2

[Hung-Te Lin (Code Review)]

Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48448 )

Change subject: mb/google/dedede/var/magolor: Add Wifi SAR for magolor and maglia
......................................................................

mb/google/dedede/var/magolor: Add Wifi SAR for magolor and maglia

Add wifi sar for magolor and maglia:
Using tablet mode of fw config to decide to load custom wifi sar or not.
same wifi sar value for magolor and maglia (shared firmware)

BUG=b:173001370, b:173001251
TEST=enable CHROMEOS_WIFI_SAR in config of coreboot,
emerge-dedede coreboot-private-files-baseboard-dedede coreboot chromeos-bootimage.

Cq-Depend: chrome-internal:3453724

Signed-off-by: Ren Kuo 
Change-Id: I44ab68c9ee5deced90d3858161571ab4b39b4c8a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48448
Reviewed-by: Karthik Ramasubramanian 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/dedede/Kconfig.name
A src/mainboard/google/dedede/variants/magolor/Makefile.inc
A src/mainboard/google/dedede/variants/magolor/variant.c
3 files changed, 18 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Ren Kuo: Looks good to me, but someone else must approve
  Karthik Ramasubramanian: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/Kconfig.name b/src/mainboard/google/dedede/Kconfig.name
index 6aeb9ed..3348655 100644
--- a/src/mainboard/google/dedede/Kconfig.name
+++ b/src/mainboard/google/dedede/Kconfig.name
@@ -66,6 +66,7 @@
    select BOARD_GOOGLE_BASEBOARD_DEDEDE
    select BASEBOARD_DEDEDE_LAPTOP
    select DRIVERS_INTEL_MIPI_CAMERA
+	select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR
    select SOC_INTEL_COMMON_BLOCK_IPU

config BOARD_GOOGLE_METAKNIGHT
diff --git a/src/mainboard/google/dedede/variants/magolor/Makefile.inc b/src/mainboard/google/dedede/variants/magolor/Makefile.inc
new file mode 100644
index 0000000..24c75d1
--- /dev/null
+++ b/src/mainboard/google/dedede/variants/magolor/Makefile.inc
@@ -0,0 +1,3 @@
+## SPDX-License-Identifier: GPL-2.0-or-later
+
+ramstage-$(CONFIG_FW_CONFIG) += variant.c
diff --git a/src/mainboard/google/dedede/variants/magolor/variant.c b/src/mainboard/google/dedede/variants/magolor/variant.c
new file mode 100644
index 0000000..e3b9599
--- /dev/null
+++ b/src/mainboard/google/dedede/variants/magolor/variant.c
@@ -0,0 +1,14 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#include <fw_config.h>
+#include <sar.h>
+
+const char *get_wifi_sar_cbfs_filename(void)
+{
+	const char *filename = NULL;
+
+	if (fw_config_probe(FW_CONFIG(TABLETMODE, TABLETMODE_ENABLED)))
+		filename = "wifi_sar-magolor.hex";
+
+	return filename;
+}