Change in coreboot[master]: [WIP]src/arch/x86:Add support for low power idle table - coreboot-gerrit

6 Nov 2020


      Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32350 )
Change subject: [WIP]src/arch/x86:Add support for low power idle table
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/32350/5/src/acpi/acpi.c 
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/32350/5/src/acpi/acpi.c@1331 
PS5, Line 1331: 	soc_residency_counter(&lpit->lpit_soc);
...
Michael. Again should this be in "src/arch/x86/acpi. […]
acpi_create_lpit is right in src/acpi/acpi.c IMO; I'm not sure about system_residency_counter and soc_residency_counter which could be better in src/arch/x86/acpi.c
@Angel what do you think?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/32350
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie76ab0d50f09c98762bc674c2758520d53789137
Gerrit-Change-Number: 32350
Gerrit-PatchSet: 5
Gerrit-Owner: Shaunak Saha shaunak.saha@intel.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Justin TerAvest teravest@chromium.org
Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Shaunak Saha shaunak.saha@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner foss@mniewoehner.de
Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 06 Nov 2020 10:19:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shaunak Saha shaunak.saha@intel.com
Gerrit-MessageType: comment