View Change
1 comment:
File src/acpi/acpi.c:
Patch Set #5, Line 1331: soc_residency_counter(&lpit->lpit_soc);
Michael. Again should this be in "src/arch/x86/acpi. […]
acpi_create_lpit is right in src/acpi/acpi.c IMO; I'm not sure about system_residency_counter and soc_residency_counter which could be better in src/arch/x86/acpi.c
@Angel what do you think?
To view, visit change 32350. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie76ab0d50f09c98762bc674c2758520d53789137
Gerrit-Change-Number: 32350
Gerrit-PatchSet: 5
Gerrit-Owner: Shaunak Saha <shaunak.saha@intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Justin TerAvest <teravest@chromium.org>
Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Comment-Date: Fri, 06 Nov 2020 10:19:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shaunak Saha <shaunak.saha@intel.com>
Gerrit-MessageType: comment