Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39124 )
Change subject: mb/kontron/986lcd-m: Select FIXED_UART_FOR_CONSOLE ......................................................................
mb/kontron/986lcd-m: Select FIXED_UART_FOR_CONSOLE
The serial port base address is hardcoded for this mainboard, so deactivate the Kconfig dialog for `TTYS0_BASE`.
Change-Id: Ic989e4c4fde8ce03c6941c44f71dc72840fc77c3 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/mainboard/kontron/986lcd-m/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/39124/1
diff --git a/src/mainboard/kontron/986lcd-m/Kconfig b/src/mainboard/kontron/986lcd-m/Kconfig index dfc7c3c..204d404 100644 --- a/src/mainboard/kontron/986lcd-m/Kconfig +++ b/src/mainboard/kontron/986lcd-m/Kconfig @@ -9,6 +9,7 @@ select SOUTHBRIDGE_INTEL_I82801GX select SUPERIO_WINBOND_W83627THG select SUPERIO_NUVOTON_COMMON_HWM # Nuvoton is a Winbond spin-off + select FIXED_UART_FOR_CONSOLE select HAVE_ACPI_TABLES select HAVE_PIRQ_TABLE select HAVE_MP_TABLE
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39124 )
Change subject: mb/kontron/986lcd-m: Select FIXED_UART_FOR_CONSOLE ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39124/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39124/1//COMMIT_MSG@9 PS1, Line 9: hardcoded It is indeed hardcoded, but there are two serial ports. I don't think disabling the choice is a good idea.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39124 )
Change subject: mb/kontron/986lcd-m: Select FIXED_UART_FOR_CONSOLE ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39124/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39124/1//COMMIT_MSG@9 PS1, Line 9: hardcoded
It is indeed hardcoded, but there are two serial ports. […]
Setting `TTYS0_BASE` won’t have any effect, or am I missing anything?
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39124 )
Change subject: mb/kontron/986lcd-m: Select FIXED_UART_FOR_CONSOLE ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39124/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39124/1//COMMIT_MSG@9 PS1, Line 9: hardcoded
Setting `TTYS0_BASE` won’t have any effect, or am I missing anything?
If TTYS0_BASE is 0x3f8, data will flow out of the first port; if 0x2f8, the second.
There are few boards where the prompt makes sense, this seems to be one of them ;)
There's a lot of confusion around it. Historically, UART_FOR_CONSOLE had two competing implementations:
* (What I think is correct:) If a board has more than one UART, each UART is assigned a port range in the usual order (3f8, 2f8, 3e8, 2e8). UART_FOR_CONSOLE selects to which port the console goes. * TTYS0_BASE is assigned to the port the developer used for debugging (not sure if any board still does that, but I recall that I saw something like that).
Not so long ago, a third interpretation was added. Intel repurposed this Kconfig to select the port of a board to select the port of their SoC instead.
Maybe it's time to document all this... but I'm not a fan to document something that wouldn't need documentation if it were fixed instead.
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/39124?usp=email )
Change subject: mb/kontron/986lcd-m: Select FIXED_UART_FOR_CONSOLE ......................................................................
Abandoned
This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.
-
Angel Pons (Code Review) -
Martin L Roth (Code Review)
-
Nico Huber (Code Review)
-
Paul Menzel (Code Review)