Patch set 1:Code-Review -1
View Change
1 comment:
Commit Message:
Patch Set #1, Line 9: hardcoded
Setting `TTYS0_BASE` won’t have any effect, or am I missing anything?
If TTYS0_BASE is 0x3f8, data will flow out of the first port; if
0x2f8, the second.
There are few boards where the prompt makes sense, this seems to
be one of them ;)
There's a lot of confusion around it. Historically, UART_FOR_CONSOLE
had two competing implementations:
- (What I think is correct:) If a board has more than one UART, each UART is assigned a port range in the usual order (3f8, 2f8, 3e8, 2e8). UART_FOR_CONSOLE selects to which port the console goes.
- TTYS0_BASE is assigned to the port the developer used for debugging (not sure if any board still does that, but I recall that I saw something like that).
Not so long ago, a third interpretation was added. Intel repurposed
this Kconfig to select the port of a board to select the port of their
SoC instead.
Maybe it's time to document all this... but I'm not a fan to document
something that wouldn't need documentation if it were fixed instead.
To view, visit change 39124. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic989e4c4fde8ce03c6941c44f71dc72840fc77c3
Gerrit-Change-Number: 39124
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Sun, 08 Mar 2020 14:50:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment