Hello Chris Wang,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/42999
to review the following change.
Change subject: mb/google/zork: update telemetry settings for dalboz ......................................................................
mb/google/zork: update telemetry settings for dalboz
update telemetry value for SDLE test result.
BUG=b:152922299,b:152369472 BRANCH=trembyle-bringup TEST=emerge-zork coreboot
Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com Change-Id: I14d218243931271ba15ec4113e9bc46c670fb2ca --- M src/mainboard/google/zork/variants/dalboz/overridetree.cb 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/42999/1
diff --git a/src/mainboard/google/zork/variants/dalboz/overridetree.cb b/src/mainboard/google/zork/variants/dalboz/overridetree.cb index 587d1c5..81fc4fd 100644 --- a/src/mainboard/google/zork/variants/dalboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/dalboz/overridetree.cb @@ -17,10 +17,10 @@
# End : OPN Performance Configuration
- register "telemetry_vddcr_vdd_slope" = "32239" #mA - register "telemetry_vddcr_vdd_offset" = "0-37" - register "telemetry_vddcr_soc_slope" = "22313" #mA - register "telemetry_vddcr_soc_offset" = "0-209" + register "telemetry_vddcr_vdd_slope" = "30231" #mA + register "telemetry_vddcr_vdd_offset" = "0-1" + register "telemetry_vddcr_soc_slope" = "22644" #mA + register "telemetry_vddcr_soc_offset" = "68"
# I2C2 for touchscreen and trackpad register "i2c[2]" = "{
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42999 )
Change subject: mb/google/zork: update telemetry settings for dalboz ......................................................................
Patch Set 1: Code-Review+2
Chris Wang has uploaded a new patch set (#2) to the change originally created by chris wang. ( https://review.coreboot.org/c/coreboot/+/42999 )
Change subject: mb/google/zork: update telemetry settings for dalboz ......................................................................
mb/google/zork: update telemetry settings for dalboz
update telemetry value for SDLE test result.
BUG=b:152922299,b:152369472 TEST=emerge-zork coreboot
Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com Change-Id: I14d218243931271ba15ec4113e9bc46c670fb2ca --- M src/mainboard/google/zork/variants/dalboz/overridetree.cb 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/42999/2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42999 )
Change subject: mb/google/zork: update telemetry settings for dalboz ......................................................................
mb/google/zork: update telemetry settings for dalboz
update telemetry value for SDLE test result.
BUG=b:152922299,b:152369472 TEST=emerge-zork coreboot
Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com Change-Id: I14d218243931271ba15ec4113e9bc46c670fb2ca Reviewed-on: https://review.coreboot.org/c/coreboot/+/42999 Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/variants/dalboz/overridetree.cb 1 file changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/dalboz/overridetree.cb b/src/mainboard/google/zork/variants/dalboz/overridetree.cb index 587d1c5..81fc4fd 100644 --- a/src/mainboard/google/zork/variants/dalboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/dalboz/overridetree.cb @@ -17,10 +17,10 @@
# End : OPN Performance Configuration
- register "telemetry_vddcr_vdd_slope" = "32239" #mA - register "telemetry_vddcr_vdd_offset" = "0-37" - register "telemetry_vddcr_soc_slope" = "22313" #mA - register "telemetry_vddcr_soc_offset" = "0-209" + register "telemetry_vddcr_vdd_slope" = "30231" #mA + register "telemetry_vddcr_vdd_offset" = "0-1" + register "telemetry_vddcr_soc_slope" = "22644" #mA + register "telemetry_vddcr_soc_offset" = "68"
# I2C2 for touchscreen and trackpad register "i2c[2]" = "{
-
Aaron Durbin (Code Review) -
Chris Wang (Code Review)
-
chris wang (Code Review)
-
Patrick Georgi (Code Review)