Change in coreboot[master]: mainboard/google/puff: Clean up Kconfig

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38098 )

Change subject: mainboard/google/puff: Clean up Kconfig
......................................................................

mainboard/google/puff: Clean up Kconfig

Let the linker trim unused net driver symbols when
unused in devicetree rather than being overly zealous in the Kconfig.

BUG=b:146592075,146999042,146999043
BRANCH=none
TEST=Boot to kernel.
     Ensure we have ip address and corresponding mac
     address with ifconfig.
     Ensure ethernet controller shows up with lspci.

Change-Id: Ie98d0f9f9b77cb9ee4e52f6c95b68bcbdd94f2cc
Signed-off-by: Edward O'Callaghan 
---
M src/mainboard/google/hatch/Kconfig
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/38098/1

diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig
index 3427ced..783ec73 100644
--- a/src/mainboard/google/hatch/Kconfig
+++ b/src/mainboard/google/hatch/Kconfig
@@ -22,8 +22,8 @@
    select MB_HAS_ACTIVE_HIGH_SD_PWR_ENABLE
    select SOC_INTEL_COMETLAKE
    select SYSTEM_TYPE_LAPTOP
-	select RT8168_GET_MAC_FROM_VPD if BOARD_GOOGLE_PUFF
-	select RT8168_SET_LED_MODE if BOARD_GOOGLE_PUFF
+	select RT8168_GET_MAC_FROM_VPD
+	select RT8168_SET_LED_MODE

if BOARD_GOOGLE_BASEBOARD_HATCH

[Daniel Kurtz (Code Review)]

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38098 )

Change subject: mainboard/google/puff: Clean up Kconfig
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38098/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38098/1//COMMIT_MSG@14 
PS1, Line 14: TEST=Boot to kernel.
Can you confirm this has no effect on the generated binaries for hatch boards that do NOT have enabled Ethernet nodes in devicetree?

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38098 )

Change subject: mainboard/google/puff: Clean up Kconfig
......................................................................

Patch Set 2:
> Patch Set 1:
>
> (1 comment)

I can confirm this has the same impact as is the case for DRIVERS_GENERIC_MAX98357A as expected.

[Daniel Kurtz (Code Review)]

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38098 )

Change subject: mainboard/google/puff: Clean up Kconfig
......................................................................

Patch Set 2: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38098 )

Change subject: mainboard/google/puff: Clean up Kconfig
......................................................................

Patch Set 2: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/38098/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38098/2//COMMIT_MSG@9 
PS2, Line 9: Let the linker trim unused net driver symbols when
           : unused in devicetree rather than being overly zealous in the Kconfig.
Please reformat to use the whole text width in the first line.

[Edward O'Callaghan (Code Review)]

Hello Kangheui Won, Paul Menzel, build bot (Jenkins), Daniel Kurtz, Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38098

to look at the new patch set (#3).

Change subject: mainboard/google/puff: Clean up Kconfig
......................................................................

mainboard/google/puff: Clean up Kconfig

Let the linker trim unused net driver symbols when unused
in devicetree rather than being overly zealous in the Kconfig.

BUG=b:146592075,146999042,146999043
BRANCH=none
TEST=Boot to kernel.
     Ensure we have ip address and corresponding mac
     address with ifconfig.
     Ensure ethernet controller shows up with lspci.

Change-Id: Ie98d0f9f9b77cb9ee4e52f6c95b68bcbdd94f2cc
Signed-off-by: Edward O'Callaghan 
---
M src/mainboard/google/hatch/Kconfig
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/38098/3

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38098 )

Change subject: mainboard/google/puff: Clean up Kconfig
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38098/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38098/2//COMMIT_MSG@9 
PS2, Line 9: Let the linker trim unused net driver symbols when
           : unused in devicetree rather than being overly zealous in the Kconfig.
> Please reformat to use the whole text width in the first line.

Done

[Daniel Kurtz (Code Review)]

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38098 )

Change subject: mainboard/google/puff: Clean up Kconfig
......................................................................

Patch Set 4: Code-Review+2

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38098 )

Change subject: mainboard/google/puff: Clean up Kconfig
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38098/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38098/1//COMMIT_MSG@14 
PS1, Line 14: TEST=Boot to kernel.
> Can you confirm this has no effect on the generated binaries for hatch boards that do NOT have enabl […]

Ack

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38098 )

Change subject: mainboard/google/puff: Clean up Kconfig
......................................................................

mainboard/google/puff: Clean up Kconfig

Let the linker trim unused net driver symbols when unused
in devicetree rather than being overly zealous in the Kconfig.

BUG=b:146592075,146999042,146999043
BRANCH=none
TEST=Boot to kernel.
     Ensure we have ip address and corresponding mac
     address with ifconfig.
     Ensure ethernet controller shows up with lspci.

Change-Id: Ie98d0f9f9b77cb9ee4e52f6c95b68bcbdd94f2cc
Signed-off-by: Edward O'Callaghan 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38098
Tested-by: build bot (Jenkins) 
Reviewed-by: Daniel Kurtz 
---
M src/mainboard/google/hatch/Kconfig
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Daniel Kurtz: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig
index 3427ced..783ec73 100644
--- a/src/mainboard/google/hatch/Kconfig
+++ b/src/mainboard/google/hatch/Kconfig
@@ -22,8 +22,8 @@
    select MB_HAS_ACTIVE_HIGH_SD_PWR_ENABLE
    select SOC_INTEL_COMETLAKE
    select SYSTEM_TYPE_LAPTOP
-	select RT8168_GET_MAC_FROM_VPD if BOARD_GOOGLE_PUFF
-	select RT8168_SET_LED_MODE if BOARD_GOOGLE_PUFF
+	select RT8168_GET_MAC_FROM_VPD
+	select RT8168_SET_LED_MODE

if BOARD_GOOGLE_BASEBOARD_HATCH