Edward O'Callaghan submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Daniel Kurtz: Looks good to me, approved
mainboard/google/puff: Clean up Kconfig

Let the linker trim unused net driver symbols when unused
in devicetree rather than being overly zealous in the Kconfig.

BUG=b:146592075,146999042,146999043
BRANCH=none
TEST=Boot to kernel.
Ensure we have ip address and corresponding mac
address with ifconfig.
Ensure ethernet controller shows up with lspci.

Change-Id: Ie98d0f9f9b77cb9ee4e52f6c95b68bcbdd94f2cc
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38098
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Daniel Kurtz <djkurtz@google.com>
---
M src/mainboard/google/hatch/Kconfig
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig
index 3427ced..783ec73 100644
--- a/src/mainboard/google/hatch/Kconfig
+++ b/src/mainboard/google/hatch/Kconfig
@@ -22,8 +22,8 @@
select MB_HAS_ACTIVE_HIGH_SD_PWR_ENABLE
select SOC_INTEL_COMETLAKE
select SYSTEM_TYPE_LAPTOP
- select RT8168_GET_MAC_FROM_VPD if BOARD_GOOGLE_PUFF
- select RT8168_SET_LED_MODE if BOARD_GOOGLE_PUFF
+ select RT8168_GET_MAC_FROM_VPD
+ select RT8168_SET_LED_MODE

if BOARD_GOOGLE_BASEBOARD_HATCH


To view, visit change 38098. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie98d0f9f9b77cb9ee4e52f6c95b68bcbdd94f2cc
Gerrit-Change-Number: 38098
Gerrit-PatchSet: 6
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz@google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Kangheui Won <khwon@chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged