Attention is currently required from: Ravi Kumar Bokka, Martin L Roth, Paul Menzel, Sudheer Amrabadi.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63085 )
Change subject: sc7280: Improve performance by removing delays in cpucp init
......................................................................
Patch Set 25:
(1 comment)
File src/mainboard/google/herobrine/romstage.c:
https://review.coreboot.org/c/coreboot/+/63085/comment/ba66ff70_cf5cdb5c
PS24, Line 22: prepare();
Ack
We don't have separate mainboard and chipset hooks for romstage on arm64, so this needs to be done here for now. We could introduce a mechanism for that if it becomes a frequent problem. Until this, our romstage hook needs have pretty much always been mainboard-specific so there hasn't really been a need yet.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63085
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a727514810a505cd1005ae7f52e5215e404b3bb
Gerrit-Change-Number: 63085
Gerrit-PatchSet: 25
Gerrit-Owner: Ravi Kumar Bokka
rbokka@codeaurora.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Martin L Roth
gaumless@tutanota.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-Attention: Ravi Kumar Bokka
rbokka@codeaurora.org
Gerrit-Attention: Martin L Roth
gaumless@tutanota.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-Comment-Date: Wed, 01 Jun 2022 00:53:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@tutanota.com
Comment-In-Reply-To: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-MessageType: comment