Change in coreboot[master]: libpayload: Add CONFIG_LP_ELOG and its dependency - coreboot-gerrit

31 May 2022


      Attention is currently required from: Hsuan-ting Chen.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63115 )
Change subject: libpayload: Add CONFIG_LP_ELOG and its dependency
......................................................................
Patch Set 9:
(1 comment)
File payloads/libpayload/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/63115/comment/d04496f6_1e335116 
PS9, Line 51: classes-$(CONFIG_LP_ELOG) += elog
It seems overkill to create a Kconfig and a whole extra library for such a small file. Why not just put
libc-srcs += $(coreboottop)/src/commonlib/bsd/elog.c
in `libc/Makefile.inc` and call it a day?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63115
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64d0fdd2a8eff1d89a1ac451d37b61787b5564e7
Gerrit-Change-Number: 63115
Gerrit-PatchSet: 9
Gerrit-Owner: Hsuan-ting Chen roccochen@google.com
Gerrit-Reviewer: Jack Rosenthal jrosenth@chromium.org
Gerrit-Reviewer: Jakub Czapiga jacz@semihalf.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Hsuan Ting Chen roccochen@chromium.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Hsuan-ting Chen roccochen@google.com
Gerrit-Comment-Date: Wed, 01 Jun 2022 00:48:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment