Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38145 )
Change subject: vc/amd/pi/00670F00: Fix typo in phony target declaration ......................................................................
vc/amd/pi/00670F00: Fix typo in phony target declaration
Correct a copy/paste error for warn_no_agesa.
Change-Id: Ife2cca47f1f816f99395b33976d08826c53e3c3e Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/vendorcode/amd/pi/00670F00/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/38145/1
diff --git a/src/vendorcode/amd/pi/00670F00/Makefile.inc b/src/vendorcode/amd/pi/00670F00/Makefile.inc index c78e15a..f6cd8eb 100644 --- a/src/vendorcode/amd/pi/00670F00/Makefile.inc +++ b/src/vendorcode/amd/pi/00670F00/Makefile.inc @@ -121,7 +121,7 @@ printf "coreboot has been built with no AGESA support. Successfully " printf "booting this image will be impossible.\n\n"
-PHONY+=warn_no_amdfw +PHONY+=warn_no_agesa
ifeq ($(CONFIG_AGESA_SPLIT_MEMORY_FILES), y)
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38145 )
Change subject: vc/amd/pi/00670F00: Fix typo in phony target declaration ......................................................................
Patch Set 1: Code-Review+1
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38145 )
Change subject: vc/amd/pi/00670F00: Fix typo in phony target declaration ......................................................................
Patch Set 1: Code-Review+2
Marshall Dawson has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38145 )
Change subject: vc/amd/pi/00670F00: Fix typo in phony target declaration ......................................................................
vc/amd/pi/00670F00: Fix typo in phony target declaration
Correct a copy/paste error for warn_no_agesa.
Change-Id: Ife2cca47f1f816f99395b33976d08826c53e3c3e Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38145 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Nico Huber nico.h@gmx.de --- M src/vendorcode/amd/pi/00670F00/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/src/vendorcode/amd/pi/00670F00/Makefile.inc b/src/vendorcode/amd/pi/00670F00/Makefile.inc index c78e15a..f6cd8eb 100644 --- a/src/vendorcode/amd/pi/00670F00/Makefile.inc +++ b/src/vendorcode/amd/pi/00670F00/Makefile.inc @@ -121,7 +121,7 @@ printf "coreboot has been built with no AGESA support. Successfully " printf "booting this image will be impossible.\n\n"
-PHONY+=warn_no_amdfw +PHONY+=warn_no_agesa
ifeq ($(CONFIG_AGESA_SPLIT_MEMORY_FILES), y)
-
Marshall Dawson (Code Review) -
Nico Huber (Code Review)
-
Paul Menzel (Code Review)