Hello Marshall Dawson, Richard Spiegel,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/38043
to review the following change.
Change subject: abuild: Allow proper build tests with USE_AMD_BLOBS=y ......................................................................
abuild: Allow proper build tests with USE_AMD_BLOBS=y
Properly build test AMD ports that rely on blobs, too.
Change-Id: Ia82f38d0e57f463ee33844c7afebb9dd602cef05 Signed-off-by: Nico Huber nico.h@gmx.de --- M util/abuild/abuild 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/38043/1
diff --git a/util/abuild/abuild b/util/abuild/abuild index 23b22aa..676a446 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -723,7 +723,7 @@ shift;; -B|--blobs) shift customizing="${customizing}, blobs" - configoptions="${configoptions}CONFIG_USE_BLOBS=y\nCONFIG_ADD_FSP_BINARIES=y\nCONFIG_FSP_USE_REPO=y\n" + configoptions="${configoptions}CONFIG_USE_BLOBS=y\nCONFIG_USE_AMD_BLOBS=y\nCONFIG_ADD_FSP_BINARIES=y\nCONFIG_FSP_USE_REPO=y\n" ;; -A|--any-toolchain) shift customizing="${customizing}, any-toolchain"
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38043 )
Change subject: abuild: Allow proper build tests with USE_AMD_BLOBS=y ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38043 )
Change subject: abuild: Allow proper build tests with USE_AMD_BLOBS=y ......................................................................
Patch Set 1: Code-Review+1
Marshall Dawson has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38043 )
Change subject: abuild: Allow proper build tests with USE_AMD_BLOBS=y ......................................................................
abuild: Allow proper build tests with USE_AMD_BLOBS=y
Properly build test AMD ports that rely on blobs, too.
Change-Id: Ia82f38d0e57f463ee33844c7afebb9dd602cef05 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/38043 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M util/abuild/abuild 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Marshall Dawson: Looks good to me, approved
diff --git a/util/abuild/abuild b/util/abuild/abuild index 23b22aa..676a446 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -723,7 +723,7 @@ shift;; -B|--blobs) shift customizing="${customizing}, blobs" - configoptions="${configoptions}CONFIG_USE_BLOBS=y\nCONFIG_ADD_FSP_BINARIES=y\nCONFIG_FSP_USE_REPO=y\n" + configoptions="${configoptions}CONFIG_USE_BLOBS=y\nCONFIG_USE_AMD_BLOBS=y\nCONFIG_ADD_FSP_BINARIES=y\nCONFIG_FSP_USE_REPO=y\n" ;; -A|--any-toolchain) shift customizing="${customizing}, any-toolchain"
-
Marshall Dawson (Code Review) -
Nico Huber (Code Review)
-
Paul Menzel (Code Review)