Change in coreboot[master]: drivers/intel/fsp1.1: Use the coreboot symbols for the stack
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37276 )
Change subject: drivers/intel/fsp1.1: Use the coreboot symbols for the stack ......................................................................
drivers/intel/fsp1.1: Use the coreboot symbols for the stack
We want to know where the stack is, to make sure that it does not override other CAR symbols.
Change-Id: I9edf615bff11aa38fc307b4e2e2c97f1757a05a1 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/drivers/intel/fsp1_1/cache_as_ram.S 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/37276/1
diff --git a/src/drivers/intel/fsp1_1/cache_as_ram.S b/src/drivers/intel/fsp1_1/cache_as_ram.S index fea7acb..fb39884 100644 --- a/src/drivers/intel/fsp1_1/cache_as_ram.S +++ b/src/drivers/intel/fsp1_1/cache_as_ram.S @@ -143,8 +143,8 @@ cmp $0, %eax jne halt2
- /* Setup bootloader stack */ - movl %edx, %esp + /* Setup BSP stack */ + movl _ecar_stack, %esp
/* * ebp: FSP_INFO_HEADER address
Hello Patrick Rudolph, Subrata Banik, Huang Jin, Frans Hendriks, Lee Leahy, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37276
to look at the new patch set (#2).
Change subject: drivers/intel/fsp1.1: Use the coreboot symbols for the stack ......................................................................
drivers/intel/fsp1.1: Use the coreboot symbols for the stack
We want to know where the stack is, to make sure that it does not override other CAR symbols.
Change-Id: I9edf615bff11aa38fc307b4e2e2c97f1757a05a1 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/drivers/intel/fsp1_1/cache_as_ram.S 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/37276/2
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37276 )
Change subject: drivers/intel/fsp1.1: Use the coreboot symbols for the stack ......................................................................
Patch Set 2: Code-Review+1
Reviewed and verified on facebook fbg1701
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37276 )
Change subject: drivers/intel/fsp1.1: Use the coreboot symbols for the stack ......................................................................
Patch Set 2:
(2 comments)
Commit message need
https://review.coreboot.org/c/coreboot/+/37276/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37276/2//COMMIT_MSG@10 PS2, Line 10: override other CAR symbols. This should say more clearly commit actually moves the stack inside CAR.
https://review.coreboot.org/c/coreboot/+/37276/2/src/drivers/intel/fsp1_1/ca... File src/drivers/intel/fsp1_1/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/37276/2/src/drivers/intel/fsp1_1/ca... PS2, Line 138: * edx: Temp RAM top I don't see how where these ecx and edx are tied to DCACHE_RAM_BASE and _SIZE, while the symbol _ecar_stack below is.
Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37276 )
Change subject: drivers/intel/fsp1.1: Use the coreboot symbols for the stack ......................................................................
Abandoned
lost interest.
-
Arthur Heymans (Code Review) -
Frans Hendriks (Code Review)
-
Kyösti Mälkki (Code Review)