Change in coreboot[master]: soc/intel/fsp-car: Clear the whole usable CAR region

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37277 )


Change subject: soc/intel/fsp-car: Clear the whole usable CAR region
......................................................................

soc/intel/fsp-car: Clear the whole usable CAR region

Other symbols in car.ld likely expect to be zero initialized.

Change-Id: I44a0d3947eb6dd67dfd2d7f03e5c0766b043f61b
Signed-off-by: Arthur Heymans <[e-mail]>
---
M src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S
1 file changed, 6 insertions(+), 5 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/37277/1

diff --git a/src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S b/src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S
index 091fc4a..ec43311 100644
--- a/src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S
+++ b/src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S
@@ -89,13 +89,14 @@
 	/* Setup bootblock stack */
 	mov	%edx, %esp
 
-	/* clear .bss section as it is not shared */
+	/* coreboot assumes CAR region will be zero */
 	cld
-	xor	%eax, %eax
-	movl	$(_ebss), %ecx
-	movl	$(_bss), %edi
-	sub	%edi, %ecx
+	movl	%ecx, %edi
+	neg	%ecx
+	/* Clear up to Temp Ram top. */
+	add	%edx, %ecx
 	shrl	$2, %ecx
+	xorl	%eax, %eax
 	rep	stosl
 
 	/* Restore the timestamp from bootblock_crt0.S (ebp:mm1) */

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/37277
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44a0d3947eb6dd67dfd2d7f03e5c0766b043f61b
Gerrit-Change-Number: 37277
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <[e-mail]>
Gerrit-MessageType: newchange

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37277 )

Change subject: soc/intel/fsp-car: Clear the whole usable CAR region
......................................................................


Patch Set 2: Code-Review+1

Verified on facebook fbg1701


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/37277
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44a0d3947eb6dd67dfd2d7f03e5c0766b043f61b
Gerrit-Change-Number: 37277
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Frans Hendriks <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Fri, 06 Dec 2019 09:35:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37277 )

Change subject: soc/intel/fsp-car: Clear the whole usable CAR region
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/37277
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44a0d3947eb6dd67dfd2d7f03e5c0766b043f61b
Gerrit-Change-Number: 37277
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Frans Hendriks <[e-mail]>
Gerrit-Reviewer: Kyösti Mälkki <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Fri, 06 Dec 2019 13:00:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/37277 )


Change subject: soc/intel/fsp-car: Clear the whole usable CAR region
......................................................................


Removed Code-Review+2 by Kyösti Mälkki <[e-mail]>
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/37277
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44a0d3947eb6dd67dfd2d7f03e5c0766b043f61b
Gerrit-Change-Number: 37277
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Frans Hendriks <[e-mail]>
Gerrit-Reviewer: Kyösti Mälkki <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: deleteVote

[Arthur Heymans (Code Review)]

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37277 )

Change subject: soc/intel/fsp-car: Clear the whole usable CAR region
......................................................................


Abandoned

lost interest.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/37277
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44a0d3947eb6dd67dfd2d7f03e5c0766b043f61b
Gerrit-Change-Number: 37277
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: abandon