yongqiang niu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: WIP: coreboot: Add anx7625 panel driver ......................................................................
WIP: coreboot: Add anx7625 panel driver
Add panel anx7625 to support display
Signed-off-by: Huijuan Xie huijuan.xie@mediatek.corp-partner.google.com Change-Id: I045d2042b5649e36470500f266f108564b7063fa --- M src/mainboard/google/asurada/Makefile.inc A src/mainboard/google/asurada/panel.h A src/mainboard/google/asurada/panel_anx7625.c 3 files changed, 131 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/46575/1
diff --git a/src/mainboard/google/asurada/Makefile.inc b/src/mainboard/google/asurada/Makefile.inc index d3f8ce6..2e5d86f 100644 --- a/src/mainboard/google/asurada/Makefile.inc +++ b/src/mainboard/google/asurada/Makefile.inc @@ -20,3 +20,5 @@ ramstage-y += chromeos.c ramstage-y += mainboard.c ramstage-y += reset.c + +ramstage-$(CONFIG_DRIVER_ANALOGIX_ANX7625) += panel_anx7625.c \ No newline at end of file diff --git a/src/mainboard/google/asurada/panel.h b/src/mainboard/google/asurada/panel.h new file mode 100644 index 0000000..648440b --- /dev/null +++ b/src/mainboard/google/asurada/panel.h @@ -0,0 +1,58 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef __MAINBOARD_GOOGLE_KUKUI_PANEL_H__ +#define __MAINBOARD_GOOGLE_KUKUI_PANEL_H__ + +#include <edid.h> +#include <soc/dsi.h> + +/* + * The data that to be serialized and put into CBFS. + * Note some fields, for example edid.mode.name, were actually pointers and + * cannot be really serialized. + */ +struct panel_serializable_data { + struct edid edid; /* edid info of this panel */ + enum lb_fb_orientation orientation; /* Panel orientation */ + u8 init[]; /* A packed array of lcm_init_command */ +}; + +struct panel_description { + const char *name; /* Panel name for constructing CBFS file name */ + struct panel_serializable_data *s; + void (*power_on)(void); /* Callback to turn on panel */ +}; + +/* Returns the panel description from given ID. */ +struct panel_description *get_panel_description(int panel_id); + +/* Loads panel serializable data from CBFS. */ +struct panel_description *get_panel_from_cbfs(struct panel_description *desc); + +#define INIT_DCS_CMD(...) \ + LCM_DCS_CMD, \ + sizeof((u8[]){__VA_ARGS__}), \ + __VA_ARGS__ + +#define INIT_GENERIC_CMD(...) \ + LCM_GENERIC_CMD, \ + sizeof((u8[]){__VA_ARGS__}), \ + __VA_ARGS__ + +#define INIT_DELAY_CMD(delay) \ + LCM_DELAY_CMD, \ + delay + +#define INIT_END_CMD \ + LCM_END_CMD + +/* GPIO names */ +#define GPIO_MIPIBRDG_INT_ODL GPIO(EINT6) /* 6 */ +#define GPIO_MIPIBRDG_PWREN GPIO(DSI_TE) /* 41 */ +#define GPIO_MIPIBRDG_RST_L_1V8 GPIO(LCM_RST) /* 42 */ +#define GPIO_MIPIBRDG_PP3300_EN GPIO(PERIPHERAL_EN1) /* 127 */ +#define GPIO_MIPIBRDG_PP1800_EN GPIO(PERIPHERAL_EN2) /* 128 */ +#define GPIO_MIPIBRDG_PP1000_EN GPIO(PERIPHERAL_EN3) /* 129 */ +#define GPIO_PP3300_PANEL GPIO(CAM_CLK3) /* 136 */ + +#endif /* __MAINBOARD_GOOGLE_KUKUI_PANEL_H__ */ diff --git a/src/mainboard/google/asurada/panel_anx7625.c b/src/mainboard/google/asurada/panel_anx7625.c new file mode 100644 index 0000000..0145859 --- /dev/null +++ b/src/mainboard/google/asurada/panel_anx7625.c @@ -0,0 +1,71 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <console/console.h> +#include <delay.h> +#include <drivers/analogix/anx7625/anx7625.h> +#include <edid.h> +#include <gpio.h> +#include <soc/i2c.h> + +#include "panel.h" + + +static void power_on_anx7625(void) +{ + /* Disable backlight before turning on bridge */ + gpio_output(GPIO(KPROW1), 0); + gpio_output(GPIO(DISP_PWM), 0); + gpio_output(GPIO_PP3300_PANEL, 1); + + /* Turn on bridge */ + gpio_output(GPIO_MIPIBRDG_RST_L_1V8, 0); + gpio_output(GPIO_MIPIBRDG_PP1000_EN, 1); + gpio_output(GPIO_MIPIBRDG_PP1800_EN, 1); + gpio_output(GPIO_MIPIBRDG_PP3300_EN, 1); + mdelay(2); + gpio_output(GPIO_MIPIBRDG_PWREN, 1); + mdelay(10); + gpio_output(GPIO_MIPIBRDG_RST_L_1V8, 1); +} + +static void dummy_power_on(void) +{ + /* The panel has been already powered on when getting panel information + * so we should do nothing here. + */ +} + +static struct panel_serializable_data anx7625_data = { + .orientation = LB_FB_ORIENTATION_NORMAL, + .init = { INIT_END_CMD }, +}; + +static struct panel_description anx7625_panel = { + .s = &anx7625_data, + .power_on = dummy_power_on, +}; + +struct panel_description *get_panel_description(int panel_id) +{ + /* To read panel EDID, we have to first power on anx7625. */ + power_on_anx7625(); + + u8 i2c_bus = 3; + mtk_i2c_bus_init(i2c_bus); + + if (anx7625_init(i2c_bus)) { + printk(BIOS_ERR, "Can't init ANX7625 bridge.\n"); + return NULL; + } + struct edid *edid = &anx7625_data.edid; + if (anx7625_dp_get_edid(i2c_bus, edid)) { + printk(BIOS_ERR, "Can't get panel's edid.\n"); + return NULL; + } + if (anx7625_dp_start(i2c_bus, edid) < 0) { + printk(BIOS_ERR, "Can't start display via ANX7625.\n"); + return NULL; + } + + return &anx7625_panel; +}
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: WIP: coreboot: Add anx7625 panel driver ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46575/1/src/mainboard/google/asurad... File src/mainboard/google/asurada/panel.h:
https://review.coreboot.org/c/coreboot/+/46575/1/src/mainboard/google/asurad... PS1, Line 32: #define INIT_DCS_CMD(...) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/1/src/mainboard/google/asurad... PS1, Line 37: #define INIT_GENERIC_CMD(...) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/1/src/mainboard/google/asurad... PS1, Line 42: #define INIT_DELAY_CMD(delay) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/1/src/mainboard/google/asurad... PS1, Line 51: #define GPIO_MIPIBRDG_PWREN GPIO(DSI_TE) /* 41 */ please, no space before tabs
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: WIP: coreboot: Add anx7625 panel driver ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46575/2/src/mainboard/google/asurad... File src/mainboard/google/asurada/panel.h:
https://review.coreboot.org/c/coreboot/+/46575/2/src/mainboard/google/asurad... PS2, Line 32: #define INIT_DCS_CMD(...) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/2/src/mainboard/google/asurad... PS2, Line 37: #define INIT_GENERIC_CMD(...) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/2/src/mainboard/google/asurad... PS2, Line 42: #define INIT_DELAY_CMD(delay) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/2/src/mainboard/google/asurad... PS2, Line 51: #define GPIO_MIPIBRDG_PWREN GPIO(DSI_TE) /* 41 */ please, no space before tabs
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: WIP: coreboot: Add anx7625 panel driver ......................................................................
Patch Set 2:
(7 comments)
https://review.coreboot.org/c/coreboot/+/46575/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46575/2//COMMIT_MSG@10 PS2, Line 10: Please add the datasheet name and version used to implement the driver.
It looks like you copied it from google/kukui. Please mention that, and maybe find a way to share code.
https://review.coreboot.org/c/coreboot/+/46575/2/src/mainboard/google/asurad... File src/mainboard/google/asurada/panel.h:
https://review.coreboot.org/c/coreboot/+/46575/2/src/mainboard/google/asurad... PS2, Line 3: KUKUI Does this need to be updated?
https://review.coreboot.org/c/coreboot/+/46575/2/src/mainboard/google/asurad... PS2, Line 10: The data that to be serialized Remove the *that*.
https://review.coreboot.org/c/coreboot/+/46575/2/src/mainboard/google/asurad... PS2, Line 11: were are
https://review.coreboot.org/c/coreboot/+/46575/2/src/mainboard/google/asurad... File src/mainboard/google/asurada/panel_anx7625.c:
https://review.coreboot.org/c/coreboot/+/46575/2/src/mainboard/google/asurad... PS2, Line 35: */ Please use the recommended formatting for comments [1].
[1]: https://doc.coreboot.org/coding_style.html#commenting
https://review.coreboot.org/c/coreboot/+/46575/2/src/mainboard/google/asurad... PS2, Line 57: printk(BIOS_ERR, "Can't init ANX7625 bridge.\n"); … The display panel won’t work.
https://review.coreboot.org/c/coreboot/+/46575/2/src/mainboard/google/asurad... PS2, Line 62: edid EDID
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: WIP: coreboot: Add anx7625 panel driver ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46575/3/src/mainboard/google/asurad... File src/mainboard/google/asurada/panel.h:
https://review.coreboot.org/c/coreboot/+/46575/3/src/mainboard/google/asurad... PS3, Line 32: #define INIT_DCS_CMD(...) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/3/src/mainboard/google/asurad... PS3, Line 37: #define INIT_GENERIC_CMD(...) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/3/src/mainboard/google/asurad... PS3, Line 42: #define INIT_DELAY_CMD(delay) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/3/src/mainboard/google/asurad... PS3, Line 51: #define GPIO_MIPIBRDG_PWREN GPIO(DSI_TE) /* 41 */ please, no space before tabs
Jg Daolongzhu has uploaded a new patch set (#4) to the change originally created by yongqiang niu. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: WIP: coreboot: Add anx7625 panel driver ......................................................................
WIP: coreboot: Add anx7625 panel driver
Add panel anx7625 to support display
Signed-off-by: Huijuan Xie huijuan.xie@mediatek.corp-partner.google.com Change-Id: I045d2042b5649e36470500f266f108564b7063fa --- M src/mainboard/google/asurada/Makefile.inc A src/mainboard/google/asurada/panel.h A src/mainboard/google/asurada/panel_anx7625.c 3 files changed, 132 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/46575/4
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: WIP: coreboot: Add anx7625 panel driver ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46575/4/src/mainboard/google/asurad... File src/mainboard/google/asurada/panel.h:
https://review.coreboot.org/c/coreboot/+/46575/4/src/mainboard/google/asurad... PS4, Line 32: #define INIT_DCS_CMD(...) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/4/src/mainboard/google/asurad... PS4, Line 37: #define INIT_GENERIC_CMD(...) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/4/src/mainboard/google/asurad... PS4, Line 42: #define INIT_DELAY_CMD(delay) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/4/src/mainboard/google/asurad... PS4, Line 51: #define GPIO_MIPIBRDG_PWREN GPIO(DSI_TE) /* 41 */ please, no space before tabs
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: WIP: coreboot: Add anx7625 panel driver ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46575/5/src/mainboard/google/asurad... File src/mainboard/google/asurada/panel.h:
https://review.coreboot.org/c/coreboot/+/46575/5/src/mainboard/google/asurad... PS5, Line 32: #define INIT_DCS_CMD(...) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/5/src/mainboard/google/asurad... PS5, Line 37: #define INIT_GENERIC_CMD(...) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/5/src/mainboard/google/asurad... PS5, Line 42: #define INIT_DELAY_CMD(delay) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/5/src/mainboard/google/asurad... PS5, Line 51: #define GPIO_MIPIBRDG_PWREN GPIO(DSI_TE) /* 41 */ please, no space before tabs
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: WIP: coreboot: Add anx7625 panel driver ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46575/6/src/mainboard/google/asurad... File src/mainboard/google/asurada/panel.h:
https://review.coreboot.org/c/coreboot/+/46575/6/src/mainboard/google/asurad... PS6, Line 32: #define INIT_DCS_CMD(...) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/6/src/mainboard/google/asurad... PS6, Line 37: #define INIT_GENERIC_CMD(...) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/6/src/mainboard/google/asurad... PS6, Line 42: #define INIT_DELAY_CMD(delay) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/6/src/mainboard/google/asurad... PS6, Line 51: #define GPIO_MIPIBRDG_PWREN GPIO(DSI_TE) /* 41 */ please, no space before tabs
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: WIP: coreboot: Add anx7625 panel driver ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46575/7/src/mainboard/google/asurad... File src/mainboard/google/asurada/panel.h:
https://review.coreboot.org/c/coreboot/+/46575/7/src/mainboard/google/asurad... PS7, Line 32: #define INIT_DCS_CMD(...) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/7/src/mainboard/google/asurad... PS7, Line 37: #define INIT_GENERIC_CMD(...) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/7/src/mainboard/google/asurad... PS7, Line 42: #define INIT_DELAY_CMD(delay) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/7/src/mainboard/google/asurad... PS7, Line 51: #define GPIO_MIPIBRDG_PWREN GPIO(DSI_TE) /* 41 */ please, no space before tabs
Huijuan Xie has uploaded a new patch set (#8) to the change originally created by yongqiang niu. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: WIP: coreboot: Add anx7625 panel driver ......................................................................
WIP: coreboot: Add anx7625 panel driver
Add panel anx7625 to support display
Signed-off-by: Huijuan Xie huijuan.xie@mediatek.corp-partner.google.com Change-Id: I045d2042b5649e36470500f266f108564b7063fa --- M src/mainboard/google/asurada/Makefile.inc A src/mainboard/google/asurada/panel.h A src/mainboard/google/asurada/panel_anx7625.c 3 files changed, 132 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/46575/8
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: WIP: coreboot: Add anx7625 panel driver ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46575/8/src/mainboard/google/asurad... File src/mainboard/google/asurada/panel.h:
https://review.coreboot.org/c/coreboot/+/46575/8/src/mainboard/google/asurad... PS8, Line 51: #define GPIO_MIPIBRDG_PWREN GPIO(DSI_TE) /* 41 */ please, no space before tabs
Yidi Lin has uploaded a new patch set (#9) to the change originally created by yongqiang niu. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: WIP: coreboot: Add anx7625 panel driver ......................................................................
WIP: coreboot: Add anx7625 panel driver
Add panel anx7625 to support display
Signed-off-by: Huijuan Xie huijuan.xie@mediatek.corp-partner.google.com Change-Id: I045d2042b5649e36470500f266f108564b7063fa --- M src/mainboard/google/asurada/Makefile.inc A src/mainboard/google/asurada/panel.h A src/mainboard/google/asurada/panel_anx7625.c 3 files changed, 132 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/46575/9
Huijuan Xie has uploaded a new patch set (#11) to the change originally created by yongqiang niu. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: WIP: coreboot: Add anx7625 panel driver ......................................................................
WIP: coreboot: Add anx7625 panel driver
Add panel anx7625 to support display
Signed-off-by: Huijuan Xie huijuan.xie@mediatek.corp-partner.google.com Change-Id: I045d2042b5649e36470500f266f108564b7063fa --- M src/mainboard/google/asurada/Makefile.inc A src/mainboard/google/asurada/panel.h A src/mainboard/google/asurada/panel_anx7625.c 3 files changed, 132 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/46575/11
Huijuan Xie has uploaded a new patch set (#12) to the change originally created by yongqiang niu. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: WIP: coreboot: Add anx7625 panel driver ......................................................................
WIP: coreboot: Add anx7625 panel driver
Add panel anx7625 to support display
Signed-off-by: Huijuan Xie huijuan.xie@mediatek.corp-partner.google.com Change-Id: I045d2042b5649e36470500f266f108564b7063fa --- M src/mainboard/google/asurada/Makefile.inc A src/mainboard/google/asurada/panel.h A src/mainboard/google/asurada/panel_anx7625.c 3 files changed, 132 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/46575/12
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: WIP: coreboot: Add anx7625 panel driver ......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46575/13/src/mainboard/google/asura... File src/mainboard/google/asurada/panel.h:
https://review.coreboot.org/c/coreboot/+/46575/13/src/mainboard/google/asura... PS13, Line 32: #define INIT_DCS_CMD(...) { \ : LCM_DCS_CMD, \ : sizeof((u8[]){__VA_ARGS__}), \ : __VA_ARGS__ } : : #define INIT_GENERIC_CMD(...) { \ : LCM_GENERIC_CMD, \ : sizeof((u8[]){__VA_ARGS__}), \ : __VA_ARGS__ } : : #define INIT_DELAY_CMD(delay) { \ : LCM_DELAY_CMD, \ : delay } : : #define INIT_END_CMD \ : LCM_END_CMD please remove if not used.
Yidi Lin has uploaded a new patch set (#16) to the change originally created by yongqiang niu. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: WIP: coreboot: Add anx7625 panel driver ......................................................................
WIP: coreboot: Add anx7625 panel driver
Add panel anx7625 to support display
Signed-off-by: Huijuan Xie huijuan.xie@mediatek.corp-partner.google.com Change-Id: I045d2042b5649e36470500f266f108564b7063fa --- M src/mainboard/google/asurada/Makefile.inc A src/mainboard/google/asurada/panel.h A src/mainboard/google/asurada/panel_anx7625.c 3 files changed, 132 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/46575/16
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: WIP: coreboot: Add anx7625 panel driver ......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46575/16//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46575/16//COMMIT_MSG@7 PS16, Line 7: WIP Is this still WIP?
Yidi Lin has uploaded a new patch set (#18) to the change originally created by yongqiang niu. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: WIP: coreboot: Add anx7625 panel driver ......................................................................
WIP: coreboot: Add anx7625 panel driver
Add panel anx7625 to support display
Signed-off-by: Huijuan Xie huijuan.xie@mediatek.corp-partner.google.com Change-Id: I045d2042b5649e36470500f266f108564b7063fa --- M src/mainboard/google/asurada/Makefile.inc A src/mainboard/google/asurada/panel.h A src/mainboard/google/asurada/panel_anx7625.c 3 files changed, 132 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/46575/18
Huijuan Xie has uploaded a new patch set (#19) to the change originally created by yongqiang niu. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: WIP: coreboot: Add anx7625 panel driver ......................................................................
WIP: coreboot: Add anx7625 panel driver
Add panel anx7625 to support display
Signed-off-by: Huijuan Xie huijuan.xie@mediatek.corp-partner.google.com Change-Id: I045d2042b5649e36470500f266f108564b7063fa --- M src/mainboard/google/asurada/Makefile.inc A src/mainboard/google/asurada/panel.h A src/mainboard/google/asurada/panel_anx7625.c 3 files changed, 132 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/46575/19
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: WIP: coreboot: Add anx7625 panel driver ......................................................................
Patch Set 19:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46575/19/src/mainboard/google/asura... File src/mainboard/google/asurada/panel.h:
https://review.coreboot.org/c/coreboot/+/46575/19/src/mainboard/google/asura... PS19, Line 32: #define INIT_DCS_CMD(...) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/19/src/mainboard/google/asura... PS19, Line 37: #define INIT_GENERIC_CMD(...) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/19/src/mainboard/google/asura... PS19, Line 42: #define INIT_DELAY_CMD(delay) \ Macros with complex values should be enclosed in parentheses
Yidi Lin has uploaded a new patch set (#20) to the change originally created by yongqiang niu. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: mb/google/asurada: Add anx7625 panel driver ......................................................................
mb/google/asurada: Add anx7625 panel driver
Add panel anx7625 to support display
Signed-off-by: Huijuan Xie huijuan.xie@mediatek.corp-partner.google.com Change-Id: I045d2042b5649e36470500f266f108564b7063fa --- M src/mainboard/google/asurada/Makefile.inc A src/mainboard/google/asurada/panel.h A src/mainboard/google/asurada/panel_anx7625.c 3 files changed, 132 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/46575/20
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: mb/google/asurada: Add anx7625 panel driver ......................................................................
Patch Set 20:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46575/16//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46575/16//COMMIT_MSG@7 PS16, Line 7: WIP
Is this still WIP?
Done
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: mb/google/asurada: Add anx7625 panel driver ......................................................................
Patch Set 20:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46575/20/src/mainboard/google/asura... File src/mainboard/google/asurada/panel.h:
https://review.coreboot.org/c/coreboot/+/46575/20/src/mainboard/google/asura... PS20, Line 32: #define INIT_DCS_CMD(...) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/20/src/mainboard/google/asura... PS20, Line 37: #define INIT_GENERIC_CMD(...) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/20/src/mainboard/google/asura... PS20, Line 42: #define INIT_DELAY_CMD(delay) \ Macros with complex values should be enclosed in parentheses
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: mb/google/asurada: Add anx7625 panel driver ......................................................................
Patch Set 20:
(2 comments)
Given there will be only one panel, I feel we don't need to import the whole panel architecture from kukui; just merge the panel init calls to board.c should work.
Maybe merge this with the asurada display change, and make it simplified?
https://review.coreboot.org/c/coreboot/+/46575/20/src/mainboard/google/asura... File src/mainboard/google/asurada/panel.h:
https://review.coreboot.org/c/coreboot/+/46575/20/src/mainboard/google/asura... PS20, Line 3: KUKUI_ ASURADA
https://review.coreboot.org/c/coreboot/+/46575/20/src/mainboard/google/asura... PS20, Line 32: #define INIT_DCS_CMD(...) \ : LCM_DCS_CMD, \ : sizeof((u8[]){__VA_ARGS__}), \ : __VA_ARGS__ : : #define INIT_GENERIC_CMD(...) \ : LCM_GENERIC_CMD, \ : sizeof((u8[]){__VA_ARGS__}), \ : __VA_ARGS__ : : #define INIT_DELAY_CMD(delay) \ : LCM_DELAY_CMD, \ : delay : : #define INIT_END_CMD \ : LCM_END_CMD : remove these because we don't have MIPI panel this time.
Yidi Lin has uploaded a new patch set (#21) to the change originally created by yongqiang niu. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: mb/google/asurada: Add anx7625 panel driver ......................................................................
mb/google/asurada: Add anx7625 panel driver
Add panel anx7625 to support display
Signed-off-by: Huijuan Xie huijuan.xie@mediatek.corp-partner.google.com Change-Id: I045d2042b5649e36470500f266f108564b7063fa --- M src/mainboard/google/asurada/Makefile.inc A src/mainboard/google/asurada/panel.h A src/mainboard/google/asurada/panel_anx7625.c 3 files changed, 114 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/46575/21
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: mb/google/asurada: Add anx7625 panel driver ......................................................................
Patch Set 21:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46575/20/src/mainboard/google/asura... File src/mainboard/google/asurada/panel.h:
https://review.coreboot.org/c/coreboot/+/46575/20/src/mainboard/google/asura... PS20, Line 3: KUKUI_
ASURADA
Done
https://review.coreboot.org/c/coreboot/+/46575/20/src/mainboard/google/asura... PS20, Line 32: #define INIT_DCS_CMD(...) \ : LCM_DCS_CMD, \ : sizeof((u8[]){__VA_ARGS__}), \ : __VA_ARGS__ : : #define INIT_GENERIC_CMD(...) \ : LCM_GENERIC_CMD, \ : sizeof((u8[]){__VA_ARGS__}), \ : __VA_ARGS__ : : #define INIT_DELAY_CMD(delay) \ : LCM_DELAY_CMD, \ : delay : : #define INIT_END_CMD \ : LCM_END_CMD :
remove these because we don't have MIPI panel this time.
Done
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: mb/google/asurada: Add anx7625 panel driver ......................................................................
Patch Set 21:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46575/13/src/mainboard/google/asura... File src/mainboard/google/asurada/panel.h:
https://review.coreboot.org/c/coreboot/+/46575/13/src/mainboard/google/asura... PS13, Line 32: #define INIT_DCS_CMD(...) { \ : LCM_DCS_CMD, \ : sizeof((u8[]){__VA_ARGS__}), \ : __VA_ARGS__ } : : #define INIT_GENERIC_CMD(...) { \ : LCM_GENERIC_CMD, \ : sizeof((u8[]){__VA_ARGS__}), \ : __VA_ARGS__ } : : #define INIT_DELAY_CMD(delay) { \ : LCM_DELAY_CMD, \ : delay } : : #define INIT_END_CMD \ : LCM_END_CMD
please remove if not used.
Done
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: mb/google/asurada: Add anx7625 panel driver ......................................................................
Patch Set 21:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46575/2/src/mainboard/google/asurad... File src/mainboard/google/asurada/panel.h:
https://review.coreboot.org/c/coreboot/+/46575/2/src/mainboard/google/asurad... PS2, Line 3: KUKUI
Does this need to be updated?
Done
Yidi Lin has uploaded a new patch set (#22) to the change originally created by yongqiang niu. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: mb/google/asurada: Add anx7625 panel driver ......................................................................
mb/google/asurada: Add anx7625 panel driver
Add panel anx7625 to support display
Signed-off-by: Huijuan Xie huijuan.xie@mediatek.corp-partner.google.com Change-Id: I045d2042b5649e36470500f266f108564b7063fa --- M src/mainboard/google/asurada/Makefile.inc A src/mainboard/google/asurada/panel.h A src/mainboard/google/asurada/panel_anx7625.c 3 files changed, 117 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/46575/22
Yidi Lin has uploaded a new patch set (#24) to the change originally created by yongqiang niu. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: mb/google/asurada: Add anx7625 panel driver ......................................................................
mb/google/asurada: Add anx7625 panel driver
Add panel anx7625 to support display
Signed-off-by: Huijuan Xie huijuan.xie@mediatek.corp-partner.google.com Change-Id: I045d2042b5649e36470500f266f108564b7063fa --- M src/mainboard/google/asurada/Makefile.inc A src/mainboard/google/asurada/panel.h A src/mainboard/google/asurada/panel_anx7625.c 3 files changed, 117 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/46575/24
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: mb/google/asurada: Add anx7625 panel driver ......................................................................
Patch Set 24:
I still think we don't need a specific panel implementation for 8192. Can you merge this to CB:46578 ?we can review there.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: mb/google/asurada: Add anx7625 panel driver ......................................................................
Patch Set 24:
Patch Set 24:
I still think we don't need a specific panel implementation for 8192. Can you merge this to CB:46578 ?we can review there.
done
yongqiang niu has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: mb/google/asurada: Add anx7625 panel driver ......................................................................
Abandoned
-
build bot (Jenkins) (Code Review) -
Huijuan Xie (Code Review)
-
Hung-Te Lin (Code Review)
-
Jg Daolongzhu (Code Review)
-
Paul Menzel (Code Review)
-
Yidi Lin (Code Review)
-
yongqiang niu (Code Review)
-
Yu-Ping Wu (Code Review)