Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: WIP: coreboot: Add anx7625 panel driver ......................................................................
Patch Set 2:
(7 comments)
https://review.coreboot.org/c/coreboot/+/46575/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46575/2//COMMIT_MSG@10 PS2, Line 10: Please add the datasheet name and version used to implement the driver.
It looks like you copied it from google/kukui. Please mention that, and maybe find a way to share code.
https://review.coreboot.org/c/coreboot/+/46575/2/src/mainboard/google/asurad... File src/mainboard/google/asurada/panel.h:
https://review.coreboot.org/c/coreboot/+/46575/2/src/mainboard/google/asurad... PS2, Line 3: KUKUI Does this need to be updated?
https://review.coreboot.org/c/coreboot/+/46575/2/src/mainboard/google/asurad... PS2, Line 10: The data that to be serialized Remove the *that*.
https://review.coreboot.org/c/coreboot/+/46575/2/src/mainboard/google/asurad... PS2, Line 11: were are
https://review.coreboot.org/c/coreboot/+/46575/2/src/mainboard/google/asurad... File src/mainboard/google/asurada/panel_anx7625.c:
https://review.coreboot.org/c/coreboot/+/46575/2/src/mainboard/google/asurad... PS2, Line 35: */ Please use the recommended formatting for comments [1].
[1]: https://doc.coreboot.org/coding_style.html#commenting
https://review.coreboot.org/c/coreboot/+/46575/2/src/mainboard/google/asurad... PS2, Line 57: printk(BIOS_ERR, "Can't init ANX7625 bridge.\n"); … The display panel won’t work.
https://review.coreboot.org/c/coreboot/+/46575/2/src/mainboard/google/asurad... PS2, Line 62: edid EDID