Josie Nordrum has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46823 )
Change subject: mb/google/zork: Revert temp acpi backlight fix ......................................................................
mb/google/zork: Revert temp acpi backlight fix
Remove code to turn on backlight during ACPI mode because backlight has been properly enabled in ACPI.
BUG=b:158087989 BRANCH=Zork TEST=tested backlight during reboot and suspend
Signed-off-by: Josie Nordrum JosieNordrum@google.com Change-Id: I3bf06042aa19e4559127d611d401f0ba0516b3a6 --- M src/mainboard/google/zork/smihandler.c 1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/46823/1
diff --git a/src/mainboard/google/zork/smihandler.c b/src/mainboard/google/zork/smihandler.c index 6ef2704..1c26d45 100644 --- a/src/mainboard/google/zork/smihandler.c +++ b/src/mainboard/google/zork/smihandler.c @@ -34,10 +34,5 @@ chromeec_smi_apmc(apmc, MAINBOARD_EC_SCI_EVENTS, MAINBOARD_EC_SMI_EVENTS);
- /* Temporary fix - Needs to go into ACPI instead */ - /* Turn on the backlight when we go to ACPI mode */ - if (apmc == APM_CNT_ACPI_ENABLE) - gpio_set(GPIO_85, 0); - return 0; }
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46823 )
Change subject: mb/google/zork: Revert temp acpi backlight fix ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46823 )
Change subject: mb/google/zork: Revert temp acpi backlight fix ......................................................................
Patch Set 3: Code-Review+2
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46823 )
Change subject: mb/google/zork: Revert temp acpi backlight fix ......................................................................
mb/google/zork: Revert temp acpi backlight fix
Remove code to turn on backlight during ACPI mode because backlight has been properly enabled in ACPI.
BUG=b:158087989 BRANCH=Zork TEST=tested backlight during reboot and suspend
Signed-off-by: Josie Nordrum JosieNordrum@google.com Change-Id: I3bf06042aa19e4559127d611d401f0ba0516b3a6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/46823 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/zork/smihandler.c 1 file changed, 0 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/zork/smihandler.c b/src/mainboard/google/zork/smihandler.c index 6ef2704..1c26d45 100644 --- a/src/mainboard/google/zork/smihandler.c +++ b/src/mainboard/google/zork/smihandler.c @@ -34,10 +34,5 @@ chromeec_smi_apmc(apmc, MAINBOARD_EC_SCI_EVENTS, MAINBOARD_EC_SMI_EVENTS);
- /* Temporary fix - Needs to go into ACPI instead */ - /* Turn on the backlight when we go to ACPI mode */ - if (apmc == APM_CNT_ACPI_ENABLE) - gpio_set(GPIO_85, 0); - return 0; }
-
Furquan Shaikh (Code Review) -
Josie Nordrum (Code Review)
-
Martin Roth (Code Review)
-
Tim Wawrzynczak (Code Review)