Change in coreboot[master]: mb/google/zork: Generate acpi methods in mainboard.c

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Josie Nordrum (Code Review)

22 Oct 2020 22 Oct '20

11:58 p.m.

Josie Nordrum has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46671 )

Change subject: mb/google/zork: Generate acpi methods in mainboard.c ......................................................................

mb/google/zork: Generate acpi methods in mainboard.c

Generate acpi methods which enable and disable backlight during _INI, _WAK, and _PTS.

BUG=b:158087989 BRANCH=Zork EST=check backlight during reboot and suspend

Signed-off-by: Josie Nordrum JosieNordrum@google.com Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 --- M src/mainboard/google/zork/mainboard.c 1 file changed, 47 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/46671/1

diff --git a/src/mainboard/google/zork/mainboard.c b/src/mainboard/google/zork/mainboard.c index f0d9a28..1049d6b 100644 --- a/src/mainboard/google/zork/mainboard.c +++ b/src/mainboard/google/zork/mainboard.c @@ -6,6 +6,7 @@ #include <device/device.h> #include <device/mmio.h> #include <acpi/acpi.h> +#include <acpi/acpigen.h> #include <acpi/acpi_gnvs.h> #include <amdblocks/amd_pci_util.h> #include <amdblocks/gpio_banks.h> @@ -175,6 +176,50 @@ variant_get_dxio_ddi_descriptors(dxio_descs, dxio_num, ddi_descs, ddi_num); }

+static void mainboard_write_blken(void) +{ + acpigen_write_method("\_SB.BKEN", 0); + acpigen_soc_clear_tx_gpio(GPIO_85); + acpigen_pop_len(); +} + +static void mainboard_write_blkdis(void) +{ + acpigen_write_method("\_SB.BKDS", 0); + acpigen_soc_set_tx_gpio(GPIO_85); + acpigen_pop_len(); +} + +static void mainboard_write_mini(void) +{ + acpigen_write_method("\_SB.MINI", 0); + acpigen_emit_namestring("\_SB.BKEN"); + acpigen_pop_len(); +} + +static void mainboard_write_mwak(void) +{ + acpigen_write_method("\_SB.MWAK", 0); + acpigen_emit_namestring("\_SB.BKEN"); + acpigen_pop_len(); +} + +static void mainboard_write_mpts(void) +{ + acpigen_write_method("\_SB.MPTS", 0); + acpigen_emit_namestring("\_SB.BKDS"); + acpigen_pop_len(); +} + +static void mainboard_fill_ssdt(const struct device *dev) +{ + mainboard_write_blken(); + mainboard_write_blkdis(); + mainboard_write_mini(); + mainboard_write_mpts(); + mainboard_write_mwak(); +} + /************************************************* * Dedicated mainboard function *************************************************/ @@ -186,6 +231,8 @@ pirq_setup();

dev->ops->acpi_inject_dsdt = chromeos_dsdt_generator; + dev->ops->acpi_fill_ssdt = mainboard_fill_ssdt; + }

static void mainboard_final(void *chip_info)

Attachments:

attachment.htm (text/html — 6.7 KB)

Show replies by date

build bot (Jenkins) (Code Review)

23 Oct 23 Oct

12:10 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46671 )

Change subject: mb/google/zork: Generate acpi methods in mainboard.c ......................................................................

Patch Set 1:

(20 comments)

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... File src/mainboard/google/zork/mainboard.c:

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 181: acpigen_write_method("\_SB.BKEN", 0); please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 182: acpigen_soc_clear_tx_gpio(GPIO_85); please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 183: acpigen_pop_len(); please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 188: acpigen_write_method("\_SB.BKDS", 0); please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 189: acpigen_soc_set_tx_gpio(GPIO_85); please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 190: acpigen_pop_len(); please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 195: acpigen_write_method("\_SB.MINI", 0); please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 196: acpigen_emit_namestring("\_SB.BKEN"); please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 197: acpigen_pop_len(); please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 202: acpigen_write_method("\_SB.MWAK", 0); please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 203: acpigen_emit_namestring("\_SB.BKEN"); please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 204: acpigen_pop_len(); please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 209: acpigen_write_method("\_SB.MPTS", 0); please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 210: acpigen_emit_namestring("\_SB.BKDS"); please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 211: acpigen_pop_len(); please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 216: mainboard_write_blken(); please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 217: mainboard_write_blkdis(); please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 218: mainboard_write_mini(); please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 219: mainboard_write_mpts(); please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 220: mainboard_write_mwak(); please, no spaces at the start of a line

-- To view, visit https://review.coreboot.org/c/coreboot/+/46671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 Gerrit-Change-Number: 46671 Gerrit-PatchSet: 1 Gerrit-Owner: Josie Nordrum josienordrum@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 23 Oct 2020 00:10:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

12:11 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46671 )

Change subject: mb/google/zork: Generate acpi methods in mainboard.c ......................................................................

Patch Set 1:

(2 comments)

You will also have to drop: https://source.corp.google.com/chromeos_public/src/third_party/coreboot/src/...

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... File src/mainboard/google/zork/mainboard.c:

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 178: nit: You can add macros for the method names just to make it easier to reuse below:

#define METHOD_BACKLIGHT_ENABLE "\_SB.BKEN" #define METHOD_BACKLIGHT_DISABLE "\_SB.BKDS" #define METHOD_MAINBOARD_INI "\_SB.MINI" ...

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 181: These should be all tabs instead of spaces.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 Gerrit-Change-Number: 46671 Gerrit-PatchSet: 1 Gerrit-Owner: Josie Nordrum josienordrum@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 23 Oct 2020 00:11:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Josie Nordrum (Code Review)

12:38 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46671

to look at the new patch set (#2).

Change subject: mb/google/zork: Generate acpi methods in mainboard.c ......................................................................

mb/google/zork: Generate acpi methods in mainboard.c

Generate acpi methods which enable and disable backlight during _INI, _WAK, and _PTS.

BUG=b:158087989 BRANCH=Zork EST=check backlight during reboot and suspend

Signed-off-by: Josie Nordrum JosieNordrum@google.com Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 --- M src/mainboard/google/zork/mainboard.c 1 file changed, 47 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/46671/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/46671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 Gerrit-Change-Number: 46671 Gerrit-PatchSet: 2 Gerrit-Owner: Josie Nordrum josienordrum@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Josie Nordrum (Code Review)

12:39 a.m.

Josie Nordrum has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46671 )

Change subject: mb/google/zork: Generate acpi methods in mainboard.c ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... File src/mainboard/google/zork/mainboard.c:

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 178:

...

nit: You can add macros for the method names just to make it easier to reuse below: […]

Ack

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 181:

...

These should be all tabs instead of spaces.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/46671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 Gerrit-Change-Number: 46671 Gerrit-PatchSet: 2 Gerrit-Owner: Josie Nordrum josienordrum@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 23 Oct 2020 00:39:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Josie Nordrum (Code Review)

26 Oct 26 Oct

5:46 p.m.

Hello build bot (Jenkins), Furquan Shaikh, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46671

to look at the new patch set (#4).

Change subject: mb/google/zork: Generate acpi methods in mainboard.c ......................................................................

mb/google/zork: Generate acpi methods in mainboard.c

Generate acpi methods which enable and disable backlight during _INI, _WAK, and _PTS.

BUG=b:158087989 BRANCH=Zork EST=check backlight during reboot and suspend

Signed-off-by: Josie Nordrum JosieNordrum@google.com Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 --- M src/mainboard/google/zork/mainboard.c 1 file changed, 47 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/46671/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/46671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 Gerrit-Change-Number: 46671 Gerrit-PatchSet: 4 Gerrit-Owner: Josie Nordrum josienordrum@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Furquan Shaikh (Code Review)

11:08 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46671 )

Change subject: mb/google/zork: Generate acpi methods in mainboard.c ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... File src/mainboard/google/zork/mainboard.c:

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 178:

...

Ack

Are you planning on adding the macros?

-- To view, visit https://review.coreboot.org/c/coreboot/+/46671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 Gerrit-Change-Number: 46671 Gerrit-PatchSet: 5 Gerrit-Owner: Josie Nordrum josienordrum@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 26 Oct 2020 23:08:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Josie Nordrum josienordrum@google.com Gerrit-MessageType: comment

Josie Nordrum (Code Review)

27 Oct 27 Oct

8:07 p.m.

Hello build bot (Jenkins), Furquan Shaikh, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46671

to look at the new patch set (#7).

Change subject: mb/google/zork: Generate acpi methods in mainboard.c ......................................................................

mb/google/zork: Generate acpi methods in mainboard.c

Generate acpi methods which enable and disable backlight during _INI, _WAK, and _PTS.

BUG=b:158087989 BRANCH=Zork EST=check backlight during reboot and suspend

Signed-off-by: Josie Nordrum JosieNordrum@google.com Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 --- M src/mainboard/google/zork/mainboard.c 1 file changed, 53 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/46671/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/46671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 Gerrit-Change-Number: 46671 Gerrit-PatchSet: 7 Gerrit-Owner: Josie Nordrum josienordrum@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Josie Nordrum (Code Review)

8:09 p.m.

Josie Nordrum has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46671 )

Change subject: mb/google/zork: Generate acpi methods in mainboard.c ......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... File src/mainboard/google/zork/mainboard.c:

https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 178:

...

Are you planning on adding the macros?

Added

-- To view, visit https://review.coreboot.org/c/coreboot/+/46671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 Gerrit-Change-Number: 46671 Gerrit-PatchSet: 7 Gerrit-Owner: Josie Nordrum josienordrum@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 27 Oct 2020 20:09:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Josie Nordrum josienordrum@google.com Gerrit-MessageType: comment

Martin Roth (Code Review)

8:20 p.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46671 )

Change subject: mb/google/zork: Generate acpi methods in mainboard.c ......................................................................

Patch Set 7: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/46671/7//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/46671/7//COMMIT_MSG@14 PS7, Line 14: EST you lost a T.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 Gerrit-Change-Number: 46671 Gerrit-PatchSet: 7 Gerrit-Owner: Josie Nordrum josienordrum@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 27 Oct 2020 20:20:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

8:20 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46671 )

Change subject: mb/google/zork: Generate acpi methods in mainboard.c ......................................................................

Patch Set 7: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/46671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 Gerrit-Change-Number: 46671 Gerrit-PatchSet: 7 Gerrit-Owner: Josie Nordrum josienordrum@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 27 Oct 2020 20:20:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Josie Nordrum (Code Review)

8:23 p.m.

Josie Nordrum has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46671 )

Change subject: mb/google/zork: Generate acpi methods in mainboard.c ......................................................................

Patch Set 7:

pulled wrong commit from test branch- don't review yet

-- To view, visit https://review.coreboot.org/c/coreboot/+/46671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 Gerrit-Change-Number: 46671 Gerrit-PatchSet: 7 Gerrit-Owner: Josie Nordrum josienordrum@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 27 Oct 2020 20:23:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Martin Roth (Code Review)

8:26 p.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46671 )

Change subject: mb/google/zork: Generate acpi methods in mainboard.c ......................................................................

Patch Set 7:

We've been bamboozled.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 Gerrit-Change-Number: 46671 Gerrit-PatchSet: 7 Gerrit-Owner: Josie Nordrum josienordrum@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 27 Oct 2020 20:26:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Josie Nordrum (Code Review)

8:30 p.m.

Hello build bot (Jenkins), Martin Roth, Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46671

to look at the new patch set (#8).

Change subject: mb/google/zork: Generate acpi methods in mainboard.c ......................................................................

mb/google/zork: Generate acpi methods in mainboard.c

Generate acpi methods which enable and disable backlight during _INI, _WAK, and _PTS.

BUG=b:158087989 BRANCH=Zork EST=check backlight during reboot and suspend

Signed-off-by: Josie Nordrum JosieNordrum@google.com Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 --- M src/mainboard/google/zork/mainboard.c 1 file changed, 53 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/46671/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/46671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 Gerrit-Change-Number: 46671 Gerrit-PatchSet: 8 Gerrit-Owner: Josie Nordrum josienordrum@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Josie Nordrum (Code Review)

8:33 p.m.

Hello build bot (Jenkins), Martin Roth, Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46671

to look at the new patch set (#9).

Change subject: mb/google/zork: Generate acpi methods in mainboard.c ......................................................................

mb/google/zork: Generate acpi methods in mainboard.c

Generate acpi methods which enable and disable backlight during _INI, _WAK, and _PTS.

BUG=b:158087989 BRANCH=Zork EST=check backlight during reboot and suspend

Signed-off-by: Josie Nordrum JosieNordrum@google.com Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 --- M src/mainboard/google/zork/mainboard.c 1 file changed, 53 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/46671/9

-- To view, visit https://review.coreboot.org/c/coreboot/+/46671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 Gerrit-Change-Number: 46671 Gerrit-PatchSet: 9 Gerrit-Owner: Josie Nordrum josienordrum@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Josie Nordrum (Code Review)

8:34 p.m.

Josie Nordrum has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46671 )

Change subject: mb/google/zork: Generate acpi methods in mainboard.c ......................................................................

Patch Set 9:

ok, ready for review. Re-tested/verified on DUT.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 Gerrit-Change-Number: 46671 Gerrit-PatchSet: 9 Gerrit-Owner: Josie Nordrum josienordrum@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 27 Oct 2020 20:34:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

8:48 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46671 )

Change subject: mb/google/zork: Generate acpi methods in mainboard.c ......................................................................

Patch Set 9: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/46671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 Gerrit-Change-Number: 46671 Gerrit-PatchSet: 9 Gerrit-Owner: Josie Nordrum josienordrum@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 27 Oct 2020 20:48:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Josie Nordrum (Code Review)

9:20 p.m.

Hello build bot (Jenkins), Furquan Shaikh, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46671

to look at the new patch set (#10).

Change subject: mb/google/zork: Generate acpi methods in mainboard.c ......................................................................

mb/google/zork: Generate acpi methods in mainboard.c

Generate acpi methods which enable and disable backlight during _INI, _WAK, and _PTS.

BUG=b:158087989 BRANCH=Zork TEST=check backlight during reboot and suspend

Signed-off-by: Josie Nordrum JosieNordrum@google.com Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 --- M src/mainboard/google/zork/mainboard.c 1 file changed, 53 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/46671/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/46671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 Gerrit-Change-Number: 46671 Gerrit-PatchSet: 10 Gerrit-Owner: Josie Nordrum josienordrum@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Josie Nordrum (Code Review)

9:21 p.m.

Josie Nordrum has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46671 )

Change subject: mb/google/zork: Generate acpi methods in mainboard.c ......................................................................

Patch Set 10:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46671/7//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/46671/7//COMMIT_MSG@14 PS7, Line 14: EST

...

you lost a T.

(: Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/46671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 Gerrit-Change-Number: 46671 Gerrit-PatchSet: 10 Gerrit-Owner: Josie Nordrum josienordrum@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 27 Oct 2020 21:21:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth martinroth@google.com Gerrit-MessageType: comment

Martin Roth (Code Review)

9:32 p.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46671 )

Change subject: mb/google/zork: Generate acpi methods in mainboard.c ......................................................................

Patch Set 10: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/46671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 Gerrit-Change-Number: 46671 Gerrit-PatchSet: 10 Gerrit-Owner: Josie Nordrum josienordrum@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 27 Oct 2020 21:32:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

28 Oct 28 Oct

5:18 p.m.

Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46671 )

Change subject: mb/google/zork: Generate acpi methods in mainboard.c ......................................................................

mb/google/zork: Generate acpi methods in mainboard.c

Generate acpi methods which enable and disable backlight during _INI, _WAK, and _PTS.

BUG=b:158087989 BRANCH=Zork TEST=check backlight during reboot and suspend

Signed-off-by: Josie Nordrum JosieNordrum@google.com Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/46671 Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/mainboard.c 1 file changed, 53 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/zork/mainboard.c b/src/mainboard/google/zork/mainboard.c index f0d9a28..9503d37 100644 --- a/src/mainboard/google/zork/mainboard.c +++ b/src/mainboard/google/zork/mainboard.c @@ -6,6 +6,7 @@ #include <device/device.h> #include <device/mmio.h> #include <acpi/acpi.h> +#include <acpi/acpigen.h> #include <acpi/acpi_gnvs.h> #include <amdblocks/amd_pci_util.h> #include <amdblocks/gpio_banks.h> @@ -28,6 +29,12 @@ #include <commonlib/helpers.h> #include <bootstate.h>

+#define METHOD_BACKLIGHT_ENABLE "\_SB.BKEN" +#define METHOD_BACKLIGHT_DISABLE "\_SB.BKDS" +#define METHOD_MAINBOARD_INI "\_SB.MINI" +#define METHOD_MAINBOARD_WAK "\_SB.MWAK" +#define METHOD_MAINBOARD_PTS "\_SB.MPTS" + /*********************************************************** * These arrays set up the FCH PCI_INTR registers 0xC00/0xC01. * This table is responsible for physically routing the PIC and @@ -175,6 +182,50 @@ variant_get_dxio_ddi_descriptors(dxio_descs, dxio_num, ddi_descs, ddi_num); }

+static void mainboard_write_blken(void) +{ + acpigen_write_method(METHOD_BACKLIGHT_ENABLE, 0); + acpigen_soc_clear_tx_gpio(GPIO_85); + acpigen_pop_len(); +} + +static void mainboard_write_blkdis(void) +{ + acpigen_write_method(METHOD_BACKLIGHT_DISABLE, 0); + acpigen_soc_set_tx_gpio(GPIO_85); + acpigen_pop_len(); +} + +static void mainboard_write_mini(void) +{ + acpigen_write_method(METHOD_MAINBOARD_INI, 0); + acpigen_emit_namestring(METHOD_BACKLIGHT_ENABLE); + acpigen_pop_len(); +} + +static void mainboard_write_mwak(void) +{ + acpigen_write_method(METHOD_MAINBOARD_WAK, 0); + acpigen_emit_namestring(METHOD_BACKLIGHT_ENABLE); + acpigen_pop_len(); +} + +static void mainboard_write_mpts(void) +{ + acpigen_write_method(METHOD_MAINBOARD_PTS, 0); + acpigen_emit_namestring(METHOD_BACKLIGHT_DISABLE); + acpigen_pop_len(); +} + +static void mainboard_fill_ssdt(const struct device *dev) +{ + mainboard_write_blken(); + mainboard_write_blkdis(); + mainboard_write_mini(); + mainboard_write_mpts(); + mainboard_write_mwak(); +} + /************************************************* * Dedicated mainboard function *************************************************/ @@ -186,6 +237,8 @@ pirq_setup();

dev->ops->acpi_inject_dsdt = chromeos_dsdt_generator; + dev->ops->acpi_fill_ssdt = mainboard_fill_ssdt; + }

static void mainboard_final(void *chip_info)

-- To view, visit https://review.coreboot.org/c/coreboot/+/46671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f3434dc92de1f697693ff69ca15bd76647b89a2 Gerrit-Change-Number: 46671 Gerrit-PatchSet: 11 Gerrit-Owner: Josie Nordrum josienordrum@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1299

days inactive

1305

days old

coreboot-gerrit@coreboot.org

20 comments

5 participants

tags (0)

participants (5)

build bot (Jenkins) (Code Review)
Furquan Shaikh (Code Review)
Josie Nordrum (Code Review)
Martin Roth (Code Review)
Tim Wawrzynczak (Code Review)