Josie Nordrum has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46670 )
Change subject: soc/amd/picasso/acpi: Include platform.asl ......................................................................
soc/amd/picasso/acpi: Include platform.asl
Include platform.asl to link acpi methods for _INI, _WAK, and _PTS to correctly enable backlight in OS.
BUG=b:158087989 BRANCH=Zork TEST=check backlight during reboot and suspend
Signed-off-by: Josie Nordrum JosieNordrum@google.com Change-Id: I702f807a5907d85d083295cf339ba9d31b246627 --- M src/soc/amd/picasso/acpi/sb_pci0_fch.asl 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/46670/1
diff --git a/src/soc/amd/picasso/acpi/sb_pci0_fch.asl b/src/soc/amd/picasso/acpi/sb_pci0_fch.asl index 9208e13..49cb072 100644 --- a/src/soc/amd/picasso/acpi/sb_pci0_fch.asl +++ b/src/soc/amd/picasso/acpi/sb_pci0_fch.asl @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
+#include <soc/amd/common/acpi/platform.asl> + External(_SB.ALIB, MethodObj)
/* System Bus */
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46670 )
Change subject: soc/amd/picasso/acpi: Include platform.asl ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46670/1/src/soc/amd/picasso/acpi/sb... File src/soc/amd/picasso/acpi/sb_pci0_fch.asl:
https://review.coreboot.org/c/coreboot/+/46670/1/src/soc/amd/picasso/acpi/sb... PS1, Line 3: #include <soc/amd/common/acpi/platform.asl> Move this to be included around line 25-26 where lpc.asl is included just to keep the includes together?
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46670 )
Change subject: soc/amd/picasso/acpi: Include platform.asl ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46670/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46670/1//COMMIT_MSG@9 PS1, Line 9: to : correctly enable backlight in OS nit: This is true only for zork. Probably drop this part or say this is being used for controlling backlight in OS for zork?
Hello build bot (Jenkins), Furquan Shaikh, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46670
to look at the new patch set (#2).
Change subject: soc/amd/picasso/acpi: Include platform.asl ......................................................................
soc/amd/picasso/acpi: Include platform.asl
Include platform.asl to link acpi methods for _INI, _WAK, and _PTS to correctly enable backlight in OS for zork.
BUG=b:158087989 BRANCH=Zork TEST=check backlight during reboot and suspend
Signed-off-by: Josie Nordrum JosieNordrum@google.com Change-Id: I702f807a5907d85d083295cf339ba9d31b246627 --- M src/soc/amd/picasso/acpi/sb_pci0_fch.asl 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/46670/2
Josie Nordrum has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46670 )
Change subject: soc/amd/picasso/acpi: Include platform.asl ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46670/1/src/soc/amd/picasso/acpi/sb... File src/soc/amd/picasso/acpi/sb_pci0_fch.asl:
https://review.coreboot.org/c/coreboot/+/46670/1/src/soc/amd/picasso/acpi/sb... PS1, Line 3: #include <soc/amd/common/acpi/platform.asl>
Move this to be included around line 25-26 where lpc. […]
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46670 )
Change subject: soc/amd/picasso/acpi: Include platform.asl ......................................................................
Patch Set 2: Code-Review+2
Josie Nordrum has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46670 )
Change subject: soc/amd/picasso/acpi: Include platform.asl ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46670/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46670/1//COMMIT_MSG@9 PS1, Line 9: to : correctly enable backlight in OS
nit: This is true only for zork. […]
Done
Hello build bot (Jenkins), Furquan Shaikh, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46670
to look at the new patch set (#4).
Change subject: soc/amd/picasso/acpi: Include platform.asl ......................................................................
soc/amd/picasso/acpi: Include platform.asl
Include platform.asl to link acpi methods for _INI, _WAK, and _PTS to correctly enable backlight in OS for zork.
BUG=b:158087989 BRANCH=Zork TEST=check backlight during reboot and suspend
Signed-off-by: Josie Nordrum JosieNordrum@google.com Change-Id: I702f807a5907d85d083295cf339ba9d31b246627 --- M src/soc/amd/picasso/acpi/sb_pci0_fch.asl 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/46670/4
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46670 )
Change subject: soc/amd/picasso/acpi: Include platform.asl ......................................................................
soc/amd/picasso/acpi: Include platform.asl
Include platform.asl to link acpi methods for _INI, _WAK, and _PTS to correctly enable backlight in OS for zork.
BUG=b:158087989 BRANCH=Zork TEST=check backlight during reboot and suspend
Signed-off-by: Josie Nordrum JosieNordrum@google.com Change-Id: I702f807a5907d85d083295cf339ba9d31b246627 Reviewed-on: https://review.coreboot.org/c/coreboot/+/46670 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/soc/amd/picasso/acpi/sb_pci0_fch.asl 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/soc/amd/picasso/acpi/sb_pci0_fch.asl b/src/soc/amd/picasso/acpi/sb_pci0_fch.asl index f627a28..cbb1b91 100644 --- a/src/soc/amd/picasso/acpi/sb_pci0_fch.asl +++ b/src/soc/amd/picasso/acpi/sb_pci0_fch.asl @@ -22,6 +22,7 @@
/* 0:14.3 - LPC */ #include <soc/amd/common/acpi/lpc.asl> +#include <soc/amd/common/acpi/platform.asl>
Name(CRES, ResourceTemplate() { /* Set the Bus number and Secondary Bus number for the PCI0 device
-
Furquan Shaikh (Code Review) -
Josie Nordrum (Code Review)
-
Tim Wawrzynczak (Code Review)