Change in coreboot[master]: mb/google/brya/var/vell: Change to ELAN touchpanel driver

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62317 )

Change subject: mb/google/brya/var/vell: Change to ELAN touchpanel driver
......................................................................

mb/google/brya/var/vell: Change to ELAN touchpanel driver

Disabled G2touch driver and add ELAN touchpanel driver for vell.
Due to incorrect BIOS setting, touch screen IC FW can't update and work.
According to ELAN's recommendations, we coreect the ELAN2513 driver's setting and change I2C address to 0x10

BUG=b:221340736
TEST=emerge-brya coreboot and can flash touch screen FW

Change-Id: I22f04fa21b542e21e88c46547779cfb55beb5c12
Signed-off-by: Shon Wang 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/62317
Tested-by: build bot (Jenkins) 
Reviewed-by: Tim Wawrzynczak 
Reviewed-by: EricR Lai 
Reviewed-by: YH Lin 
---
M src/mainboard/google/brya/variants/vell/overridetree.cb
1 file changed, 9 insertions(+), 24 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  YH Lin: Looks good to me, but someone else must approve
  EricR Lai: Looks good to me, approved
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/brya/variants/vell/overridetree.cb b/src/mainboard/google/brya/variants/vell/overridetree.cb
index 690e266..1562482 100644
--- a/src/mainboard/google/brya/variants/vell/overridetree.cb
+++ b/src/mainboard/google/brya/variants/vell/overridetree.cb
@@ -208,40 +208,25 @@
    		end
    	end
    	device ref i2c3 on
-			chip drivers/i2c/generic
-				register "hid" = ""ELAN0001""
-				register "desc" = ""ELAN Touchscreen""
-				register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C7_IRQ)"
-				register "probed" = "1"
-				register "reset_gpio" =
-							"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)"
-				register "reset_delay_ms" = "100"
-				register "reset_off_delay_ms" = "5"
-				register "enable_gpio" =
-							"ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)"
-				register "enable_delay_ms" = "10"
-				register "enable_off_delay_ms" = "1"
-				register "stop_gpio" =
-							"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C6)"
-				register "has_power_resource" = "1"
-				register "disable_gpio_export_in_crs" = "1"
-				device i2c 10 on end
-			end
    		chip drivers/i2c/hid
-				register "generic.hid" = ""GTCH7503""
-				register "generic.desc" = ""G2TOUCH Touchscreen""
+				register "generic.hid" = ""ELAN2513""
+				register "generic.desc" = ""ELAN Touchscreen""
    			register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C7_IRQ)"
    			register "generic.probed" = "1"
    			register "generic.reset_gpio" =
    						"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)"
-				register "generic.reset_delay_ms" = "50"
+				register "generic.reset_delay_ms" = "200"
+				register "generic.reset_off_delay_ms" = "1"
    			register "generic.enable_gpio" =
    						"ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)"
-				register "generic.enable_delay_ms" = "1"
+				register "generic.enable_delay_ms" = "6"
+				register "generic.stop_gpio" =
+							"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C6)"
+				register "generic.stop_off_delay_ms" = "1"
    			register "generic.has_power_resource" = "1"
    			register "generic.disable_gpio_export_in_crs" = "1"
    			register "hid_desc_reg_offset" = "0x01"
-				device i2c 40 on end
+				device i2c 0x10 on end
    		end
    	end
    	device ref i2c2 on