Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38899 )
Change subject: util/docker: Use more stable URL ......................................................................
util/docker: Use more stable URL
The pgeorgi namespace is my own and things could change without notice there. encapsulate is now maintained on review.coreboot.org/encapsulate.git and mirrored over to github, so let's use that.
Change-Id: I12e43f61f693a6b0392b84dd56ede665a1a2129a Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/docker/coreboot-jenkins-node/Dockerfile 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/38899/1
diff --git a/util/docker/coreboot-jenkins-node/Dockerfile b/util/docker/coreboot-jenkins-node/Dockerfile index cfe5abb..73f7f18 100644 --- a/util/docker/coreboot-jenkins-node/Dockerfile +++ b/util/docker/coreboot-jenkins-node/Dockerfile @@ -45,7 +45,7 @@ echo "tmpfs /home/coreboot/.ccache tmpfs rw,mode=1777 0 0" >> /etc/fstab
# Build encapsulate tool -ADD https://raw.githubusercontent.com/pgeorgi/encapsulate/master/encapsulate.c /tmp/encapsulate.c +ADD https://raw.githubusercontent.com/coreboot/encapsulate/master/encapsulate.c /tmp/encapsulate.c RUN gcc -o /usr/sbin/encapsulate /tmp/encapsulate.c && \ chown root /usr/sbin/encapsulate && \ chmod +s /usr/sbin/encapsulate
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38899 )
Change subject: util/docker: Use more stable URL ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38899/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38899/1//COMMIT_MSG@10 PS1, Line 10: nit: to fill out the rest of the line, and avoid starting in lowercase, one might add:
To overcome this issue, encapsulate is now...
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38899 )
Change subject: util/docker: Use more stable URL ......................................................................
Patch Set 1: Code-Review+1
Hello Angel Pons, Paul Menzel, build bot (Jenkins), Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38899
to look at the new patch set (#2).
Change subject: util/docker: Use more stable URL ......................................................................
util/docker: Use more stable URL
The pgeorgi namespace is my own and things could change without notice there. To overcome this issue, encapsulate is now maintained on review.coreboot.org/encapsulate.git and mirrored over to github, so let's use that.
Change-Id: I12e43f61f693a6b0392b84dd56ede665a1a2129a Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/docker/coreboot-jenkins-node/Dockerfile 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/38899/2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38899 )
Change subject: util/docker: Use more stable URL ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38899/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38899/1//COMMIT_MSG@10 PS1, Line 10:
nit: to fill out the rest of the line, and avoid starting in lowercase, one might add: […]
Ack
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38899 )
Change subject: util/docker: Use more stable URL ......................................................................
Patch Set 2: Code-Review+2
Thanks Patrick.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38899 )
Change subject: util/docker: Use more stable URL ......................................................................
util/docker: Use more stable URL
The pgeorgi namespace is my own and things could change without notice there. To overcome this issue, encapsulate is now maintained on review.coreboot.org/encapsulate.git and mirrored over to github, so let's use that.
Change-Id: I12e43f61f693a6b0392b84dd56ede665a1a2129a Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38899 Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/docker/coreboot-jenkins-node/Dockerfile 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/util/docker/coreboot-jenkins-node/Dockerfile b/util/docker/coreboot-jenkins-node/Dockerfile index cfe5abb..73f7f18 100644 --- a/util/docker/coreboot-jenkins-node/Dockerfile +++ b/util/docker/coreboot-jenkins-node/Dockerfile @@ -45,7 +45,7 @@ echo "tmpfs /home/coreboot/.ccache tmpfs rw,mode=1777 0 0" >> /etc/fstab
# Build encapsulate tool -ADD https://raw.githubusercontent.com/pgeorgi/encapsulate/master/encapsulate.c /tmp/encapsulate.c +ADD https://raw.githubusercontent.com/coreboot/encapsulate/master/encapsulate.c /tmp/encapsulate.c RUN gcc -o /usr/sbin/encapsulate /tmp/encapsulate.c && \ chown root /usr/sbin/encapsulate && \ chmod +s /usr/sbin/encapsulate
-
Angel Pons (Code Review) -
Martin Roth (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)