Attention is currently required from: Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/80705?usp=email )
Change subject: mb/starlabs/byte_adl: Add Alder Lake N Byte Mk II ......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80705/comment/30a580ce_162de794?usp... : PS7, Line 4: SaGv_Enabled
You mean remove it? I thought it didn't limit performance
it doesn't limit performance, but it does increase RAM training time since it trains at multiple frequencies (low/mid/high, IIRC). It's a change I'd made to Chromeboxes based on reviewer feedback so was suggesting it here. I don't think removing the entry is sufficient unless the default has changed since I last checked
-
Matt DeVillier (Code Review)