Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/80705?usp=email ) Change subject: mb/starlabs/byte_adl: Add Alder Lake N Byte Mk II ...................................................................... Patch Set 7: (1 comment) File src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb: https://review.coreboot.org/c/coreboot/+/80705/comment/30a580ce_162de794?usp... : PS7, Line 4: SaGv_Enabled
You mean remove it? I thought it didn't limit performance it doesn't limit performance, but it does increase RAM training time since it trains at multiple frequencies (low/mid/high, IIRC). It's a change I'd made to Chromeboxes based on reviewer feedback so was suggesting it here. I don't think removing the entry is sufficient unless the default has changed since I last checked
-- To view, visit https://review.coreboot.org/c/coreboot/+/80705?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idff2d883a8c29f0fee9d633708aac92061a45132 Gerrit-Change-Number: 80705 Gerrit-PatchSet: 7 Gerrit-Owner: Sean Rhodes <sean@starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Sean Rhodes <sean@starlabs.systems> Gerrit-Comment-Date: Mon, 01 Jul 2024 00:06:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <sean@starlabs.systems> Comment-In-Reply-To: Matt DeVillier <matt.devillier@gmail.com>