Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34684 )
Change subject: lib/spd_bin: Fix bug with rank parsing for DDR4 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34684/1/src/lib/spd_bin.c File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/34684/1/src/lib/spd_bin.c@a76 PS1, Line 76:
However it should be ranks = spd_ranks[(spd[12] >> 3) & 7] + 1; because in spec 00 is 1 and 01 is 2 etc
Right. Either you need ((spd[12] >> 3) & 7) + 1 or you need spd_ranks_ddr4[] = {1, 2, 3, 4, 5, 6, 7, 8}
Actually, it might be a good exercise to check if other arrays[] at the start of this function look good for DDR4.
-
Furquan Shaikh (Code Review)