View Change
1 comment:
File src/lib/spd_bin.c:
Patch Set #1, Line 76:
However it should be ranks = spd_ranks[(spd[12] >> 3) & 7] + 1; because in spec 00 is 1 and 01 is 2 etc
Right. Either you need ((spd[12] >> 3) & 7) + 1 or you need spd_ranks_ddr4[] = {1, 2, 3, 4, 5, 6, 7, 8}
Actually, it might be a good exercise to check if other arrays[] at the start of this function look good for DDR4.
To view, visit change 34684. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3184c5a7fd4b5ae5882914e62d1cb0c28bb881e7
Gerrit-Change-Number: 34684
Gerrit-PatchSet: 1
Gerrit-Owner: Andrey Petrov <anpetrov@fb.com>
Gerrit-Reviewer: Andrey Petrov <anpetrov@fb.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Wed, 07 Aug 2019 00:43:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Andrey Petrov <anpetrov@fb.com>
Comment-In-Reply-To: Furquan Shaikh <furquan@google.com>
Gerrit-MessageType: comment